From: Jaroslav Kysela <perex@perex.cz>
To: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, pierre-louis.bossart@linux.intel.com
Subject: Re: [alsa-devel] [PATCH v2 2/2] ASoC: SOF: topology: set trigger order for FE DAI link
Date: Mon, 18 Nov 2019 23:44:05 +0100 [thread overview]
Message-ID: <a87bce63-0413-d475-9b3c-19aa0f803232@perex.cz> (raw)
In-Reply-To: <20191104224812.3393-3-ranjani.sridharan@linux.intel.com>
Dne 04. 11. 19 v 23:48 Ranjani Sridharan napsal(a):
> Set trigger order for FE DAI links to SND_SOC_DPCM_TRIGGER_POST
> to trigger the BE DAI's before the FE DAI's. This prevents the
> xruns seen on playback pipelines using the link DMA.
>
> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/sof/topology.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
> index e0e2ae734632..e7076692119b 100644
> --- a/sound/soc/sof/topology.c
> +++ b/sound/soc/sof/topology.c
> @@ -2951,6 +2951,10 @@ static int sof_link_load(struct snd_soc_component *scomp, int index,
> if (!link->no_pcm) {
> link->nonatomic = true;
>
> + /* set trigger order */
> + link->trigger[0] = SND_SOC_DPCM_TRIGGER_POST;
> + link->trigger[1] = SND_SOC_DPCM_TRIGGER_POST;
> +
> /* nothing more to do for FE dai links */
> return 0;
> }
>
It seems that this patch breaks the signed 1.3 firmware. Tested on Lenovo
Carbon X1 7th gen.
https://github.com/thesofproject/sof/issues/2102
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-18 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 22:48 [alsa-devel] [PATCH v2 0/2] Update FE/BE trigger order based on the command Ranjani Sridharan
2019-11-04 22:48 ` [alsa-devel] [PATCH v2 1/2] ASoC: pcm: update " Ranjani Sridharan
2019-11-05 18:55 ` [alsa-devel] Applied "ASoC: pcm: update FE/BE trigger order based on the command" to the asoc tree Mark Brown
2019-11-04 22:48 ` [alsa-devel] [PATCH v2 2/2] ASoC: SOF: topology: set trigger order for FE DAI link Ranjani Sridharan
2019-11-05 18:55 ` [alsa-devel] Applied "ASoC: SOF: topology: set trigger order for FE DAI link" to the asoc tree Mark Brown
2019-11-18 22:44 ` Jaroslav Kysela [this message]
2020-02-09 9:31 ` [alsa-devel] [PATCH v2 2/2] ASoC: SOF: topology: set trigger order for FE DAI link Hui Wang
2020-02-09 12:45 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a87bce63-0413-d475-9b3c-19aa0f803232@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.