From: James Smart <jsmart2021@gmail.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH 03/14] lpfc: Fix first-burst driver implementation.
Date: Wed, 1 Jul 2020 22:30:58 -0700 [thread overview]
Message-ID: <a8d5e44a-df9c-ed98-2020-a4ec2f75791c@gmail.com> (raw)
In-Reply-To: <yq1o8oyaaeh.fsf@ca-mkp.ca.oracle.com>
On 7/1/2020 8:05 PM, Martin K. Petersen wrote:
>
> James,
>
>> - Upon PRLI completion, if first-burst is enabled and the target supports
>> first burst, the driver will issue a modesense6 scsi command to obtain
>> the disconnect-reconnect page that has transport specific limits. This
>> page reports the max first-burst size supported on the target. The size
>> supported is saved in the target node structure.
>
> I didn't make it beyond this patch :(
>
> Why do this in the driver? If you need the Disconnect-Reconnect page,
> then let's ask for it in the core code. Maybe in the fc transport so we
> don't risk upsetting USB devices, etc. See sas_read_port_mode_page().
>
Because it was rather awkward to coordinate, snoop, sample at the right
time, and a lot more work when implemented in the midlayer. I really
don't like that scsi put transport controls in a scsi mode page.
I will take another look at it. It should be queried about the same time
as when luns are first probed - lun 0 or report luns, or on the first
lun probed as it's an I_T set of parameters. Not sure if it should be
saved in the starget (fields are defined generically) or in the transport.
Please review the rest and I can repost for any comments on the other
patches and I'll remove this patch.
-- james
next prev parent reply other threads:[~2020-07-02 5:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 21:49 [PATCH 00/14] lpfc: Update lpfc to revision 12.8.0.2 James Smart
2020-06-30 21:49 ` [PATCH 01/14] lpfc: Fix unused assignment in lpfc_sli4_bsg_link_diag_test James Smart
2020-06-30 21:49 ` [PATCH 02/14] lpfc: Fix missing MDS functionality James Smart
2020-06-30 21:49 ` [PATCH 03/14] lpfc: Fix first-burst driver implementation James Smart
2020-07-02 3:05 ` Martin K. Petersen
2020-07-02 5:30 ` James Smart [this message]
2020-06-30 21:49 ` [PATCH 04/14] lpfc: Fix NVME rport deregister and registration during ADISC James Smart
2020-06-30 21:49 ` [PATCH 05/14] lpfc: Fix oops due to overrun when reading SLI3 data James Smart
2020-06-30 21:49 ` [PATCH 06/14] lpfc: Fix stack trace seen while setting rrq active James Smart
2020-06-30 21:49 ` [PATCH 07/14] lpfc: Fix shost refcount mismatch when deleting vport James Smart
2020-06-30 21:49 ` [PATCH 08/14] lpfc: Fix kdump hang on PPC James Smart
2020-06-30 21:49 ` [PATCH 09/14] lpfc: Fix language in 0373 message to reflect non-error message James Smart
2020-06-30 21:49 ` [PATCH 10/14] lpfc: Allow applications to issue Common Set Features mailbox command James Smart
2020-06-30 21:49 ` [PATCH 11/14] lpfc: Add support to display if adapter dumps are available James Smart
2020-06-30 21:49 ` [PATCH 12/14] lpfc: Add blk_io_poll support for latency improvment James Smart
2020-06-30 21:50 ` [PATCH 13/14] lpfc: Add an internal trace log buffer James Smart
2020-06-30 21:50 ` [PATCH 14/14] lpfc: Update lpfc version to 12.8.0.2 James Smart
2020-07-03 4:03 ` [PATCH 00/14] lpfc: Update lpfc to revision 12.8.0.2 Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8d5e44a-df9c-ed98-2020-a4ec2f75791c@gmail.com \
--to=jsmart2021@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.