From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Ye Xiang <xiang.ye@intel.com>, jikos@kernel.org, jic23@kernel.org
Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: add custom hinge sensor support
Date: Fri, 04 Dec 2020 03:46:08 -0800 [thread overview]
Message-ID: <a921aecf97915bd7c618e99e8959f6bf60ea7f6d.camel@linux.intel.com> (raw)
In-Reply-To: <20201203035352.13918-1-xiang.ye@intel.com>
On Thu, 2020-12-03 at 11:53 +0800, Ye Xiang wrote:
> Here three separate iio devices are presented which presents angle
> for
> hinge, keyboard and screen.
You are presenting one IIO device now with three channels.
>
> This driver works on devices with Intel integrated sensor hub, where
> hinge sensor is presented using a custom sensor usage id.
>
> Here the angle is presented in degrees, which is converted to
> radians.
>
> Changes since v2:
> - use 1 iio device instead of 3 for hinge sensor.
> - use indexed channel instead of modified channel and added channel
> labels.
> - remove 2,3 patch in last version, add a document patch to
> describe the
> hinge channels.
> - hid-sensor-custom: use meaningful return value in
> get_known_custom_sensor_index and checked in call side.
> - hid-sensor-ids.h: use HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x)
> to
> define custom sensor value.
>
> Changes since v1:
> - fixed errors reported by lkp
>
> Ye Xiang (3):
> HID: hid-sensor-custom: Add custom sensor iio support
> iio: hid-sensors: Add hinge sensor driver
> iio:Documentation: Add documentation for hinge sensor channels
>
> Documentation/ABI/testing/sysfs-bus-iio | 17 +
> drivers/hid/hid-sensor-custom.c | 181 ++++++++
> .../hid-sensors/hid-sensor-attributes.c | 2 +
> drivers/iio/position/Kconfig | 16 +
> drivers/iio/position/Makefile | 1 +
> .../position/hid-sensor-custom-intel-hinge.c | 393
> ++++++++++++++++++
> include/linux/hid-sensor-ids.h | 14 +
> 7 files changed, 624 insertions(+)
> create mode 100644 drivers/iio/position/hid-sensor-custom-intel-
> hinge.c
>
prev parent reply other threads:[~2020-12-04 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:53 add custom hinge sensor support Ye Xiang
2020-12-03 3:53 ` [PATCH v3 1/3] HID: hid-sensor-custom: Add custom sensor iio support Ye Xiang
2020-12-05 16:00 ` Jonathan Cameron
2020-12-03 3:53 ` [PATCH v3 2/3] iio: hid-sensors: Add hinge sensor driver Ye Xiang
2020-12-05 16:27 ` Jonathan Cameron
2020-12-03 3:53 ` [PATCH v3 3/3] iio:Documentation: Add documentation for hinge sensor channels Ye Xiang
2020-12-04 11:40 ` Srinivas Pandruvada
2020-12-05 15:52 ` Jonathan Cameron
2020-12-05 16:05 ` Jonathan Cameron
2020-12-07 9:18 ` Ye, Xiang
2020-12-13 14:15 ` Jonathan Cameron
2020-12-14 6:16 ` Ye, Xiang
2020-12-04 11:46 ` Srinivas Pandruvada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a921aecf97915bd7c618e99e8959f6bf60ea7f6d.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.