From: Sinan Kaya <okaya@kernel.org>
To: Keith Busch <keith.busch@intel.com>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Tai <thomas.tai@oracle.com>,
poza@codeaurora.org, Lukas Wunner <lukas@wunner.de>,
Christoph Hellwig <hch@lst.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 11/12] PCI/AER: Use managed resource allocations
Date: Wed, 19 Sep 2018 13:36:33 -0400 [thread overview]
Message-ID: <a956bdf7-e901-e1ad-57ea-868835d94beb@kernel.org> (raw)
In-Reply-To: <20180919172526.GB28310@localhost.localdomain>
On 9/19/2018 1:25 PM, Keith Busch wrote:
> On Wed, Sep 19, 2018 at 12:29:15PM -0400, Sinan Kaya wrote:
>> On 9/18/2018 7:58 PM, Keith Busch wrote:
>>> if (status) {
>>> dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n",
>>> dev->irq);
>>> - aer_remove(dev);
>>> return status;
>>> }
>>
>> Don't we still need to call aer_remove() here?
>>
>> Old code would call aer_disable_rootport(rpc) via aer_remove() on IRQ allocation
>> failure. We are no longer doing this.
>
> We need to call aer_disable_rootport only if aer_enable_rootport was
> called, but that happens *after* irq allocation.
>
I see. Thanks for clarification.
next prev parent reply other threads:[~2018-09-19 23:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 23:58 [PATCH 00/12] error handling and pciehp maintenance Keith Busch
2018-09-18 23:58 ` [PATCH 01/12] PCI: Set PCI bus accessors to noinline Keith Busch
2018-09-18 23:58 ` [PATCH 02/12] PCI/AER: Covertly inject errors Keith Busch
2018-09-18 23:58 ` [PATCH 03/12] PCI/AER: Reuse existing service device lookup Keith Busch
2018-09-18 23:58 ` [PATCH 04/12] PCI/AER: Abstract AER interrupt handling Keith Busch
2018-09-18 23:58 ` [PATCH 05/12] PCI/AER: Remove dead code Keith Busch
2018-09-18 23:58 ` [PATCH 06/12] PCI/AER: Remove error source from aer struct Keith Busch
2018-09-18 23:58 ` [PATCH 07/12] PCI/AER: Use kfifo for tracking events Keith Busch
2018-09-18 23:58 ` [PATCH 08/12] PCI/AER: Use kfifo helper inserting locked elements Keith Busch
2018-09-18 23:58 ` [PATCH 09/12] PCI/AER: Don't read upstream ports below fatal errors Keith Busch
2018-09-18 23:58 ` [PATCH 10/12] PCI/AER: Use threaded IRQ for bottom half Keith Busch
2018-09-18 23:58 ` [PATCH 11/12] PCI/AER: Use managed resource allocations Keith Busch
2018-09-19 16:29 ` Sinan Kaya
2018-09-19 17:25 ` Keith Busch
2018-09-19 17:36 ` Sinan Kaya [this message]
2018-09-25 1:13 ` Benjamin Herrenschmidt
2018-09-25 14:17 ` Keith Busch
2018-09-18 23:58 ` [PATCH 12/12] PCI/pciehp: Use device managed allocations Keith Busch
2018-09-19 15:11 ` Sinan Kaya
2018-09-19 16:17 ` Keith Busch
2018-09-22 18:10 ` Lukas Wunner
2018-09-24 23:43 ` Bjorn Helgaas
2018-09-25 7:13 ` Lukas Wunner
2018-10-04 21:40 ` [PATCH 00/12] error handling and pciehp maintenance Bjorn Helgaas
2018-10-04 22:11 ` Keith Busch
2018-10-05 17:31 ` Bjorn Helgaas
2018-10-05 17:31 ` Bjorn Helgaas
2018-10-08 16:18 ` Keith Busch
2018-10-08 16:18 ` Keith Busch
2018-10-08 17:23 ` Bjorn Helgaas
2018-10-08 17:23 ` Bjorn Helgaas
2018-11-06 16:34 ` Lorenzo Pieralisi
2018-11-06 16:34 ` Lorenzo Pieralisi
2018-11-06 16:47 ` Keith Busch
2018-11-06 16:47 ` Keith Busch
2018-11-06 17:21 ` Lorenzo Pieralisi
2018-11-06 17:21 ` Lorenzo Pieralisi
2018-11-06 17:26 ` Keith Busch
2018-11-06 17:26 ` Keith Busch
2018-10-09 16:03 ` Will Deacon
2018-10-09 16:03 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a956bdf7-e901-e1ad-57ea-868835d94beb@kernel.org \
--to=okaya@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=poza@codeaurora.org \
--cc=thomas.tai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.