From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 11/12] btrfs: make extent_range_redirty_for_io return void
Date: Thu, 3 Dec 2015 17:56:55 +0100 [thread overview]
Message-ID: <a9a852192fa3d43a0f17fe8d5e69ec2fd8537c01.1449161602.git.dsterba@suse.com> (raw)
In-Reply-To: <cover.1449161602.git.dsterba@suse.com>
Does not return any errors, nor anything from the callgraph. There's a
BUG_ON but it's a sanity check and not an error condition we could
recover from.
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/extent_io.c | 3 +--
fs/btrfs/extent_io.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index e55a728408bb..f06800e48f97 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -1466,7 +1466,7 @@ void extent_range_clear_dirty_for_io(struct inode *inode, u64 start, u64 end)
}
}
-int extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end)
+void extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end)
{
unsigned long index = start >> PAGE_CACHE_SHIFT;
unsigned long end_index = end >> PAGE_CACHE_SHIFT;
@@ -1480,7 +1480,6 @@ int extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end)
page_cache_release(page);
index++;
}
- return 0;
}
/*
diff --git a/fs/btrfs/extent_io.h b/fs/btrfs/extent_io.h
index b0b2d20ffd3c..fbc6448e70e4 100644
--- a/fs/btrfs/extent_io.h
+++ b/fs/btrfs/extent_io.h
@@ -339,7 +339,7 @@ int map_private_extent_buffer(struct extent_buffer *eb, unsigned long offset,
unsigned long *map_start,
unsigned long *map_len);
void extent_range_clear_dirty_for_io(struct inode *inode, u64 start, u64 end);
-int extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end);
+void extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end);
void extent_clear_unlock_delalloc(struct inode *inode, u64 start, u64 end,
struct page *locked_page,
unsigned bits_to_clear,
--
2.6.2
next prev parent reply other threads:[~2015-12-03 16:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 16:56 [PULL][PATCH 00/12] Minor cleanups and code simplifications David Sterba
2015-12-03 16:56 ` [PATCH 01/12] btrfs: make btrfs_close_one_device static David Sterba
2015-12-03 16:56 ` [PATCH 02/12] btrfs: sink parameter wait to btrfs_alloc_delalloc_work David Sterba
2015-12-03 16:56 ` [PATCH 03/12] btrfs: remove wait from struct btrfs_delalloc_work David Sterba
2015-12-03 16:56 ` [PATCH 04/12] btrfs: change how delay_iput is tracked in btrfs_delalloc_work David Sterba
2015-12-04 2:25 ` Liu Bo
2015-12-04 12:36 ` David Sterba
2015-12-04 12:50 ` Holger Hoffstätte
2015-12-07 14:23 ` David Sterba
2015-12-04 13:08 ` Filipe Manana
2015-12-07 13:52 ` David Sterba
2015-12-03 16:56 ` [PATCH 05/12] btrfs: remove a trivial helper btrfs_set_buffer_uptodate David Sterba
2015-12-03 16:56 ` [PATCH 06/12] btrfs: make set_extent_buffer_uptodate return void David Sterba
2015-12-03 16:56 ` [PATCH 07/12] btrfs: make clear_extent_buffer_uptodate " David Sterba
2015-12-03 16:56 ` [PATCH 08/12] btrfs: make extent_clear_unlock_delalloc " David Sterba
2015-12-03 16:56 ` [PATCH 09/12] btrfs: make end_extent_writepage " David Sterba
2015-12-03 16:56 ` [PATCH 10/12] btrfs: make extent_range_clear_dirty_for_io " David Sterba
2015-12-03 16:56 ` David Sterba [this message]
2015-12-03 16:56 ` [PATCH 12/12] btrfs: make set_range_writeback " David Sterba
2015-12-07 14:16 ` [PULL][PATCH 00/12] Minor cleanups and code simplifications David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9a852192fa3d43a0f17fe8d5e69ec2fd8537c01.1449161602.git.dsterba@suse.com \
--to=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.