From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
stefanha@redhat.com, fam@euphon.net, armbru@redhat.com,
jsnow@redhat.com, eblake@redhat.com, den@openvz.org
Subject: Re: [PATCH v13 00/10] Apply COR-filter to the block-stream permanently
Date: Sat, 5 Dec 2020 00:36:24 +0300 [thread overview]
Message-ID: <aa39bd4b-a5aa-47c4-c360-23970dea7bfc@virtuozzo.com> (raw)
In-Reply-To: <1606933861-297777-1-git-send-email-andrey.shinkevich@virtuozzo.com>
I still think we should keep dropped iotest by introducing "bottom" interface for stream job. And deprecate old interfaces.
Patch is better than arguing, so I decided to try it myself. Now I'm close to complete v14, so, will send it soon.
02.12.2020 21:30, Andrey Shinkevich wrote:
> The previous version 12 was discussed in the email thread:
> Message-Id: <1603390423-980205-1-git-send-email-andrey.shinkevich@virtuozzo.com>
>
> v13:
> 02: The bdrv_remove_node() was dropped.
> 05: Three patches with fixes were merged into one.
> 06: Minor changes based on Vladimir's suggestions.
> 08: Three patches with fixes were merged into one.
> 09: The search for format_name of backing file was added.
> 10: The flag BLK_PERM_GRAPH_MOD was removed.
>
> Andrey Shinkevich (10):
> copy-on-read: support preadv/pwritev_part functions
> block: add API function to insert a node
> copy-on-read: add filter drop function
> qapi: add filter-node-name to block-stream
> qapi: create BlockdevOptionsCor structure for COR driver
> iotests: add #310 to test bottom node in COR driver
> block: include supported_read_flags into BDS structure
> copy-on-read: skip non-guest reads if no copy needed
> stream: skip filters when writing backing file name to QCOW2 header
> block: apply COR-filter to block-stream jobs
>
> block.c | 25 +++++++
> block/copy-on-read.c | 143 +++++++++++++++++++++++++++++++++++++----
> block/copy-on-read.h | 32 +++++++++
> block/io.c | 12 +++-
> block/monitor/block-hmp-cmds.c | 4 +-
> block/stream.c | 120 +++++++++++++++++++++++-----------
> blockdev.c | 12 ++--
> include/block/block.h | 10 ++-
> include/block/block_int.h | 11 +++-
> qapi/block-core.json | 27 +++++++-
> tests/qemu-iotests/030 | 51 ++-------------
> tests/qemu-iotests/030.out | 4 +-
> tests/qemu-iotests/141.out | 2 +-
> tests/qemu-iotests/245 | 22 +++++--
> tests/qemu-iotests/310 | 114 ++++++++++++++++++++++++++++++++
> tests/qemu-iotests/310.out | 15 +++++
> tests/qemu-iotests/group | 1 +
> 17 files changed, 484 insertions(+), 121 deletions(-)
> create mode 100644 block/copy-on-read.h
> create mode 100755 tests/qemu-iotests/310
> create mode 100644 tests/qemu-iotests/310.out
>
--
Best regards,
Vladimir
prev parent reply other threads:[~2020-12-04 21:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 18:30 [PATCH v13 00/10] Apply COR-filter to the block-stream permanently Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 01/10] copy-on-read: support preadv/pwritev_part functions Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 02/10] block: add API function to insert a node Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 03/10] copy-on-read: add filter drop function Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 04/10] qapi: add filter-node-name to block-stream Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 05/10] qapi: create BlockdevOptionsCor structure for COR driver Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 06/10] iotests: add #310 to test bottom node in " Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 07/10] block: include supported_read_flags into BDS structure Andrey Shinkevich via
2020-12-02 18:30 ` [PATCH v13 08/10] copy-on-read: skip non-guest reads if no copy needed Andrey Shinkevich via
2020-12-03 12:53 ` Vladimir Sementsov-Ogievskiy
2020-12-02 18:31 ` [PATCH v13 09/10] stream: skip filters when writing backing file name to QCOW2 header Andrey Shinkevich via
2020-12-03 19:11 ` Vladimir Sementsov-Ogievskiy
2020-12-02 18:31 ` [PATCH v13 10/10] block: apply COR-filter to block-stream jobs Andrey Shinkevich via
2020-12-04 21:36 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa39bd4b-a5aa-47c4-c360-23970dea7bfc@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.