Re: [PATCH v2] dmaengine: ptdma: Fix the error handling path in pt_core_init()

From: Sanjay R Mehta <sanmehta@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Sanjay R Mehta <sanju.mehta@amd.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: ptdma: Fix the error handling path in pt_core_init()
Date: Tue, 8 Feb 2022 09:54:06 +0530	[thread overview]
Message-ID: <aa78a0f9-9bd1-5c24-f834-61085d9fe3a4@amd.com> (raw)
In-Reply-To: <20220207165117.GH1951@kadam>

On 2/7/2022 10:21 PM, Dan Carpenter wrote:
> On Sat, Feb 05, 2022 at 07:58:44AM +0100, Christophe JAILLET wrote:
>> In order to free resources correctly in the error handling path of
>> pt_core_init(), 2 goto's have to be switched. Otherwise, some resources
>> will leak and we will try to release things that have not been allocated
>> yet.
>>
>> Also move a dev_err() to a place where it is more meaningful.
>>
>> Fixes: fa5d823b16a9 ("dmaengine: ptdma: Initial driver for the AMD PTDMA")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> v2: update label names
>>     move dev_err(dev, "unable to allocate an IRQ\n");
> 
> Awesome.  Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

Thank you!

Acked-by: Sanjay R Mehta <sanju.mehta@amd.com>
> 
> regards,
> dan carpenter
> 