From: "Jan Kundrát" <jan.kundrat@cesnet.cz>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <linux-hwmon@vger.kernel.org>, Jean Delvare <jdelvare@suse.com>,
<kubernat@cesnet.cz>
Subject: Re: [PATCH 1/7] hwmon: (max31790) Fix fan speed reporting for fan7..12
Date: Wed, 02 Jun 2021 14:27:01 +0200 [thread overview]
Message-ID: <aac9fe15-f123-460c-8583-65f96103a1c6@cesnet.cz> (raw)
In-Reply-To: <20210526154022.3223012-2-linux@roeck-us.net>
On středa 26. května 2021 17:40:16 CEST, Guenter Roeck wrote:
> Fans 7..12 do not have their own set of configuration registers.
> So far the code ignored that and read beyond the end of the configuration
> register range to get the tachometer period. This resulted in more or less
> random fan speed values for those fans.
>
> The datasheet is quite vague when it comes to defining the tachometer
> period for fans 7..12. Experiments confirm that the period is the same
> for both fans associated with a given set of configuration registers.
>
> Fixes: 54187ff9d766 ("hwmon: (max31790) Convert to use new
> hwmon registration API")
> Fixes: 195a4b4298a7 ("hwmon: Driver for Maxim MAX31790")
> Cc: Jan Kundrát <jan.kundrat@cesnet.cz>
> Cc: Václav Kubernát <kubernat@cesnet.cz>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Cheers,
Jan
next prev parent reply other threads:[~2021-06-02 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 15:40 [PATCH 0/7] hwmon: (max31790) Fixes and improvements Guenter Roeck
2021-05-26 15:40 ` [PATCH 1/7] hwmon: (max31790) Fix fan speed reporting for fan7..12 Guenter Roeck
2021-06-02 12:27 ` Jan Kundrát [this message]
2021-05-26 15:40 ` [PATCH 2/7] hwmon: (max31790) Report correct current pwm duty cycles Guenter Roeck
2021-06-01 7:51 ` Václav Kubernát
2021-06-02 12:36 ` Jan Kundrát
2021-05-26 15:40 ` [PATCH 3/7] hwmon: (max31790) Fix pwmX_enable attributes Guenter Roeck
2021-06-01 8:01 ` Václav Kubernát
2021-06-02 10:47 ` Guenter Roeck
2021-06-02 12:44 ` Jan Kundrát
2021-05-26 15:40 ` [PATCH 4/7] hwmon: (max31790) Add support for fanX_enable attributes Guenter Roeck
2021-06-01 8:02 ` Václav Kubernát
2021-06-02 13:04 ` Jan Kundrát
2021-06-02 16:43 ` Guenter Roeck
2021-05-26 15:40 ` [PATCH 5/7] hwmon: (max31790) Clear fan fault after reporting it Guenter Roeck
2021-06-01 8:08 ` Václav Kubernát
2021-05-26 15:40 ` [PATCH 6/7] hwmon: (max31790) Detect and report zero fan speed Guenter Roeck
2021-06-01 8:11 ` Václav Kubernát
2021-05-26 15:40 ` [PATCH 7/7] hwmon: (max31790) Add support for fanX_min attributes Guenter Roeck
2021-06-01 8:19 ` Václav Kubernát
2021-06-01 8:29 ` [PATCH 0/7] hwmon: (max31790) Fixes and improvements Václav Kubernát
2021-06-01 12:08 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aac9fe15-f123-460c-8583-65f96103a1c6@cesnet.cz \
--to=jan.kundrat@cesnet.cz \
--cc=jdelvare@suse.com \
--cc=kubernat@cesnet.cz \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.