Re: [Qemu-devel] [PATCH 1/6] mips: Express dependencies of the MIPSsim machine with kconfig - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Yang Zhong" <yang.zhong@intel.com>,
	"Paul Burton" <pburton@wavecomp.com>,
	"Aleksandar Rikalo" <arikalo@wavecomp.com>,
	"James Hogan" <jhogan@kernel.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 1/6] mips: Express dependencies of the MIPSsim machine with kconfig
Date: Mon, 4 Feb 2019 12:05:16 +0100	[thread overview]
Message-ID: <aaee9b37-72b7-7c9b-9b79-e1cc1590b07a@redhat.com> (raw)
In-Reply-To: <54a0c271-c499-eeea-7344-68f68c010f7b@redhat.com>

Hi Thomas,

On 2/4/19 9:36 AM, Thomas Huth wrote:
> On 2019-02-04 09:31, Thomas Huth wrote:
>> On 2019-02-03 23:07, Philippe Mathieu-Daudé wrote:
>>> The MIPSsim machine only emulates an 8250 UART and a simple network
>>> controller, connected via an ISA bus.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>>>  default-configs/mips-softmmu-common.mak | 2 --
>>>  hw/mips/Kconfig                         | 3 +++
>>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
>>> index 0795d522db..aa73a4a822 100644
>>> --- a/default-configs/mips-softmmu-common.mak
>>> +++ b/default-configs/mips-softmmu-common.mak
>>> @@ -26,7 +26,6 @@ CONFIG_PIIX4=y
>>>  CONFIG_IDE_ISA=y
>>>  CONFIG_IDE_PIIX=y
>>>  CONFIG_NE2000_ISA=y
>>> -CONFIG_MIPSNET=y
>>>  CONFIG_PFLASH_CFI01=y
>>>  CONFIG_I8259=y
>>>  CONFIG_MC146818RTC=y
>>> @@ -35,7 +34,6 @@ CONFIG_MIPS_CPS=y
>>>  CONFIG_MIPS_ITU=y
>>>  CONFIG_R4K=y
>>>  CONFIG_MALTA=y
>>> -CONFIG_MIPSSIM=y
>>>  CONFIG_ACPI_SMBUS=y
>>>  CONFIG_SMBUS_EEPROM=y
>>>  CONFIG_TEST_DEVICES=y
>>> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
>>> index cdc07e59b6..3433e97e1a 100644
>>> --- a/hw/mips/Kconfig
>>> +++ b/hw/mips/Kconfig
>>> @@ -6,6 +6,9 @@ config MALTA
>>>  
>>>  config MIPSSIM
>>>      bool
>>> +    select ISA_BUS
>>> +    select SERIAL_ISA
>>> +    select MIPSNET
>>>  
>>>  config JAZZ
>>>      bool
>>>
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> Scratch that. I think you have to keep CONFIG_MIPSSIM=y enabled in the
> default-configs, don't you?

I guess I misunderstood --without-default-devices with --no-defaults,
where you'd manually select the machines you want.

Thanks for the review!

Phil.