Re: [PATCH v3 1/5] dt-bindings: Powerzone new bindings

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: robh@kernel.org, arnd@linaro.org, heiko@sntech.de,
	rjw@rjwysocki.net, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	lukasz.luba@arm.com, Arnd Bergmann <arnd@arndb.de>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 1/5] dt-bindings: Powerzone new bindings
Date: Thu, 2 Dec 2021 17:25:37 +0100	[thread overview]
Message-ID: <ab3b53c0-a765-ad4b-2017-e4a42e73fe42@linaro.org> (raw)
In-Reply-To: <CAPDyKFor=OCOYqY2K9WyOa5FrM+tCE8KR8CuBOxHdz-ch9Tzkg@mail.gmail.com>

On 02/12/2021 15:42, Ulf Hansson wrote:
> On Wed, 1 Dec 2021 at 17:41, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>
>> The proposed bindings are describing a set of powerzones.
>>
>> A power zone is the logical name for a component which is capable of
>> power capping and where we can measure the power consumption.
>>
>> A power zone can aggregate several power zones in terms of power
>> measurement and power limitations. That allows to apply power
>> constraint to a group of components and let the system balance the
>> allocated power in order to comply with the constraint.
>>
>> The ARM System Control and Management Interface (SCMI) can provide a
>> power zone description.
>>
>> The powerzone semantic is also found on the Intel platform with the
>> RAPL register.
>>
>> The Linux kernel powercap framework deals with the powerzones:
>>
>> https://www.kernel.org/doc/html/latest/power/powercap/powercap.html
>>
>> The powerzone can also represent a group of children powerzones, hence
>> the description can result on a hierarchy. Such hierarchy already
>> exists with the hardware or can be represented and computed from the
>> kernel.
>>
>> The hierarchical description was initially proposed but not desired
>> given there are other descriptions like the power domain proposing
>> almost the same description.
>>
>> https://lore.kernel.org/all/CAL_JsqLuLcHj7525tTUmh7pLqe7T2j6UcznyhV7joS8ipyb_VQ@mail.gmail.com/
>>
>> The description gives the power constraint dependencies to apply on a
>> specific group of logically or physically aggregated devices. They do
>> not represent the physical location or the power domains of the SoC
>> even if the description could be similar.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> This looks good to me, feel free to add:
> 
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Thanks Ulf for your time to review these bindings


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog