From: Dragan Simic <dsimic@manjaro.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com, jn.avila@free.fr
Subject: Re: [PATCH v2 1/3] grep: perform some minor code and comment cleanups
Date: Mon, 25 Mar 2024 22:17:40 +0100 [thread overview]
Message-ID: <ab5145b696565ba170c90e2fc1b9a7e1@manjaro.org> (raw)
In-Reply-To: <xmqq5xxahvmi.fsf@gitster.g>
On 2024-03-25 22:03, Junio C Hamano wrote:
> Dragan Simic <dsimic@manjaro.org> writes:
>
>> Move some variable definitions around, and reflow one comment block,
>> to
>> make the code a bit neater after spotting those slightly unpolished
>> areas.
>> There are no functional changes to the source code.
>
> It cannot be objectively better than the original as "neater" and
> 'unpolished" are fairly subjective. Let's leave this out and take
> the two "obviously good" documentation improvements for now.
That's fine with me. This "experiment", so to speak, has also taught me
not to pay attention to making the code "neater".
next prev parent reply other threads:[~2024-03-25 21:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 17:51 [PATCH v2 0/3] Assorted improvements salvaged from an earlier series Dragan Simic
2024-03-24 17:51 ` [PATCH v2 1/3] grep: perform some minor code and comment cleanups Dragan Simic
2024-03-25 21:03 ` Junio C Hamano
2024-03-25 21:17 ` Dragan Simic [this message]
2024-03-25 21:28 ` Junio C Hamano
2024-03-24 17:51 ` [PATCH v2 2/3] grep docs: describe --recurse-submodules further and improve formatting a bit Dragan Simic
2024-03-25 19:06 ` Junio C Hamano
2024-03-25 19:46 ` Dragan Simic
2024-03-24 17:51 ` [PATCH v2 3/3] grep docs: describe --no-index " Dragan Simic
2024-03-25 19:18 ` Junio C Hamano
2024-03-25 19:53 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5145b696565ba170c90e2fc1b9a7e1@manjaro.org \
--to=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.