Re: [External] [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support

From: Paolo Bonzini <pbonzini@redhat.com>
To: zhenwei pi <pizhenwei@bytedance.com>,
	Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [External] [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support
Date: Mon, 9 Nov 2020 14:47:51 +0100	[thread overview]
Message-ID: <ab669f03-195a-b2fa-bc04-ac35ea7b6452@redhat.com> (raw)
In-Reply-To: <a595f137-b1d2-56b6-9391-f1c5c80beabf@bytedance.com>

On 09/11/20 12:40, zhenwei pi wrote:
> Hi, Paolo
> 
> This patch seems getting ignored. Because no maintainers found for 
> hw/misc/pvpanic.c, I also send this to you(hope it doesn't disturb you).
> 
> 
> About this patch:
> Looks good. And also test it, works fine.
> 
> Reviewed-by: zhenwei pi <pizhenwei@bytedance.com>
> 
> On 11/3/20 3:50 AM, Alejandro Jimenez wrote:
>> Advertise both types of events supported when the guest OS
>> queries the pvpanic device. Currently only PVPANIC_PANICKED is
>> exposed; PVPANIC_CRASHLOADED must also be advertised.
>>
>> Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling")
>> Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
>> Acked-by: Mark Kanda <mark.kanda@oracle.com>
>> ---
>>   hw/misc/pvpanic.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
>> index 598d547..a55ce8e 100644
>> --- a/hw/misc/pvpanic.c
>> +++ b/hw/misc/pvpanic.c
>> @@ -66,7 +66,7 @@ struct PVPanicState {
>>   /* return supported events on read */
>>   static uint64_t pvpanic_ioport_read(void *opaque, hwaddr addr, 
>> unsigned size)
>>   {
>> -    return PVPANIC_PANICKED;
>> +    return PVPANIC_PANICKED | PVPANIC_CRASHLOADED;
>>   }
>>   static void pvpanic_ioport_write(void *opaque, hwaddr addr, uint64_t 
>> val,
>>
> 

Queued now, thanks Zhenwei.

Paolo