Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for Toshiba Encore WT8-A tablet - Pierre-Louis Bossart

From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for Toshiba Encore WT8-A tablet
Date: Mon, 18 May 2020 09:52:52 -0500	[thread overview]
Message-ID: <ab73e509-deaa-d5ea-46ed-b54713eca474@linux.intel.com> (raw)
In-Reply-To: <20200518072416.5348-1-hdegoede@redhat.com>

On 5/18/20 2:24 AM, Hans de Goede wrote:
> The Toshiba Encore WT8-A tablet almost fully works with the default
> settings for non-CR Bay Trail devices. The only problem is that its
> jack-detect switch is not inverted (it is active high instead of
> the normal active low).
> 
> Add a quirk for this model using the default settings +
> BYT_RT5640_JD_NOT_INV.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks Hans!

> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 08f4ae964b02..fbfd53874b47 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -742,6 +742,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   					BYT_RT5640_SSP0_AIF1 |
>   					BYT_RT5640_MCLK_EN),
>   	},
> +	{	/* Toshiba Encore WT8-A */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "TOSHIBA WT8-A"),
> +		},
> +		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP |
> +					BYT_RT5640_JD_SRC_JD2_IN4N |
> +					BYT_RT5640_OVCD_TH_2000UA |
> +					BYT_RT5640_OVCD_SF_0P75 |
> +					BYT_RT5640_JD_NOT_INV |
> +					BYT_RT5640_MCLK_EN),
> +	},
>   	{	/* Catch-all for generic Insyde tablets, must be last */
>   		.matches = {
>   			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
> 