From: Jens Axboe <axboe@kernel.dk>
To: Coly Li <colyli@suse.de>,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/1] bcache: use llist_for_each_entry_safe() in __closure_wake_up()
Date: Wed, 27 Sep 2017 22:29:06 +0200 [thread overview]
Message-ID: <abf60c6e-f735-739d-7341-280659760f61@kernel.dk> (raw)
In-Reply-To: <20170926095412.74028-2-colyli@suse.de>
On 09/26/2017 11:54 AM, Coly Li wrote:
> Commit 09b3efec ("bcache: Don't reinvent the wheel but use existing llist
> API") replaces the following while loop by llist_for_each_entry(),
If it's fixing a specific commit, please add a proper
Fixes: sha ("title")
line to your patch. That way automated scripts can pick it up, if they
backport the problematic patch.
Also, as mentioned in the other email, this is technically a
use-after-free problem, not a race.
Can you resend with commit message fixed up?
--
Jens Axboe
prev parent reply other threads:[~2017-09-27 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 9:54 [PATCH 0/1] bcache fix for 4.14-rc4 Coly Li
2017-09-26 9:54 ` [PATCH 1/1] bcache: use llist_for_each_entry_safe() in __closure_wake_up() Coly Li
2017-09-27 19:16 ` Coly Li
2017-09-27 20:27 ` Jens Axboe
2017-09-27 20:48 ` Michael Lyle
2017-09-27 20:52 ` Jens Axboe
2017-09-28 0:46 ` Coly Li
2017-09-27 20:29 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf60c6e-f735-739d-7341-280659760f61@kernel.dk \
--to=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.