From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, alistair23@gmail.com
Subject: Re: [PATCH] tcg: Restart code generation when we run out of temps
Date: Sun, 24 Jan 2021 01:27:21 +0100 [thread overview]
Message-ID: <ac08bcf3-4c2f-c74f-9135-f7e21f728e54@amsat.org> (raw)
In-Reply-To: <20210123230105.2076270-1-richard.henderson@linaro.org>
On 1/24/21 12:01 AM, Richard Henderson wrote:
> Some large translation blocks can generate so many unique
> constants that we run out of temps to hold them. In this
> case, longjmp back to the start of code generation and
> restart with a smaller translation block.
Clever and way nicer.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Buglink: https://bugs.launchpad.net/bugs/1912065
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> This replaces both the patch to increase the number of temps,
> and the buggy patch set that dynamically allocated the temps.
>
>
> r~
>
> ---
> include/tcg/tcg.h | 3 +++
> accel/tcg/translate-all.c | 15 ++++++++++++++-
> tcg/tcg.c | 11 ++++++++---
> 3 files changed, 25 insertions(+), 4 deletions(-)
next prev parent reply other threads:[~2021-01-24 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 23:01 [PATCH] tcg: Restart code generation when we run out of temps Richard Henderson
2021-01-24 0:27 ` Philippe Mathieu-Daudé [this message]
2021-01-24 13:48 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac08bcf3-4c2f-c74f-9135-f7e21f728e54@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair23@gmail.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.