Re: [PATCH net] selftests: netdevsim: add a config file

From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	 shuah@kernel.org, jiri@resnulli.us,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: netdevsim: add a config file
Date: Thu, 18 Jan 2024 11:49:58 +0100	[thread overview]
Message-ID: <ac41b2993cd2c77332ba0fe57ae4a5433cf9a2fe.camel@redhat.com> (raw)
In-Reply-To: <20240117073957.783fbe2a@kernel.org>

On Wed, 2024-01-17 at 07:39 -0800, Jakub Kicinski wrote:
> On Wed, 17 Jan 2024 10:32:19 +0100 Paolo Abeni wrote:
> > 
> > I think something like the following should do:
> > 
> > cd tools/testing/selftests
> > make TARGETS="net drivers/net/bonding <...full relevant targets list>" O=<kst_dir> install
> > cd <kst_dir>
> > 
> > ARGS=""
> > for t in $(./run_kselftest.sh -l| sed -n '/<test name>/,$p'); do
> > 	ARGS="$ARGS -t $t"
> > done
> > ./run_kselftest.sh $ARGS # run all tests after <test name>
> > 
> > Probably it would be nice to add to the kselftest runner the ability to
> > check for kernel oops after each test and ev. stop.
> 
> I wasn't aware there's a way to list tests! That should work well
> enough we can run them one by one with make, that's fine.
> 
> ./run_kselftest.sh only seems to work for installed tests, tho,
> in tree it says:
> ./run_kselftest.sh: Could not find list of tests to run (~linux/tools/testing/selftests/kselftest-list.txt)
> So perhaps the wishlist item would be "make list_tests"?

Yes, kselftest-list.txt is created on the fly by make install.

As such step could be constrained to the relevant selftests directories
(see the above code snippet), and a 'make' step is required anyway to
run the tests, what about using directly such target?

In any case I don't mean to block this patch, let me apply it...

Cheers,

Paolo