From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Harrison, John C" <john.c.harrison@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Fix GuC error capture sizing estimation and reporting
Date: Fri, 30 Sep 2022 21:08:57 +0000 [thread overview]
Message-ID: <acdf464bc515f0489c70c9282dcccce1cc2e85ca.camel@intel.com> (raw)
In-Reply-To: <49be7acd-79b8-2937-96ec-5a9728006d76@intel.com>
I disagree because its unlikely that all engines can reset all at once (we probably have bigger problems at the at
point) and if they all occurred within the same G2H handler scheduled worker run, our current gpu_coredump framework
would just discard the ones after the first one and so it wouldnt even matter if we did catch it.
But I'll go ahead and re-rev this.
...alan
On Fri, 2022-09-30 at 10:48 -0700, Harrison, John C wrote:
> Isn't min_size the bare minimum to get a valid capture? Surely this
> still needs to be a warning not a debug. If we can't manage a basic
> working error capture then there is a problem. This needs to be caught
> by CI and logged as a bug if it is ever hit. And that means an end user
> should never see it fire because we won't let a driver out the door
> unless the default buffer size is sufficient.
next prev parent reply other threads:[~2022-09-30 21:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 1:05 [Intel-gfx] [PATCH 0/1] Fix Guc-Err-Capture sizing warning Alan Previn
2022-09-30 1:05 ` [Intel-gfx] [PATCH 1/1] drm/i915/guc: Fix GuC error capture sizing estimation and reporting Alan Previn
2022-09-30 17:48 ` John Harrison
2022-09-30 21:08 ` Teres Alexis, Alan Previn [this message]
2022-09-30 22:35 ` John Harrison
2022-10-03 18:28 ` Teres Alexis, Alan Previn
2022-10-03 19:47 ` John Harrison
2022-10-03 21:10 ` Teres Alexis, Alan Previn
2022-10-03 23:51 ` John Harrison
2022-10-04 0:46 ` Teres Alexis, Alan Previn
2022-10-04 1:51 ` John Harrison
2022-10-05 23:31 ` Teres Alexis, Alan Previn
2022-09-30 2:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Fix Guc-Err-Capture sizing warning Patchwork
2022-10-01 3:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acdf464bc515f0489c70c9282dcccce1cc2e85ca.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.