All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Evan Benn <evanbenn@chromium.org>, LKML <linux-kernel@vger.kernel.org>
Cc: jwerner@chromium.org, xingyu.chen@amlogic.com,
	"David S. Miller" <davem@davemloft.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: watchdog: Add ARM smc wdt for mt8173 watchdog
Date: Wed, 6 May 2020 06:45:46 -0700	[thread overview]
Message-ID: <adbf700e-20e6-47db-a674-f965f65818c6@roeck-us.net> (raw)
In-Reply-To: <20200505131242.v6.1.Id96574f1f52479d7a2f3b866b8a0552ab8c03d7f@changeid>

On 5/4/20 8:13 PM, Evan Benn wrote:
> This watchdog can be used on ARM systems with a Secure
> Monitor firmware to forward watchdog operations to
> firmware via a Secure Monitor Call.
> 
> Signed-off-by: Evan Benn <evanbenn@chromium.org>
> 
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
> Changes in v6:
> - Don't use dt default
> 
> Changes in v5:
> - Change compatible to arm,smc-wdt
> 
> Changes in v4:
> - Add arm,smc-id property
> 
> Changes in v3:
> - Change name back to arm
> 
> Changes in v2:
> - Change name arm > mt8173
> 
>  .../bindings/watchdog/arm-smc-wdt.yaml        | 37 +++++++++++++++++++
>  MAINTAINERS                                   |  6 +++
>  2 files changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml b/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
> new file mode 100644
> index 0000000000000..bec651541e0c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/arm-smc-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM Secure Monitor Call based watchdog
> +
> +allOf:
> +  - $ref: "watchdog.yaml#"
> +
> +maintainers:
> +  - Julius Werner <jwerner@chromium.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - arm,smc-wdt
> +  arm,smc-id:
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      The ATF smc function id used by the firmware.
> +      Defaults to 0x82003D06 if unset.
> +
> +required:
> +  - compatible
> +
> +examples:
> +  - |
> +    watchdog {
> +      compatible = "arm,smc-wdt";
> +      arm,smc-id = <0x82003D06>;
> +      timeout-sec = <15>;
> +    };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b816a453b10eb..0f2b39767bfa9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1457,6 +1457,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
>  F:	drivers/irqchip/irq-vic.c
>  
> +ARM SMC WATCHDOG DRIVER
> +M:	Julius Werner <jwerner@chromium.org>
> +R:	Evan Benn <evanbenn@chromium.org>
> +S:	Maintained
> +F:	devicetree/bindings/watchdog/arm-smc-wdt.yaml
> +
>  ARM SMMU DRIVERS
>  M:	Will Deacon <will@kernel.org>
>  R:	Robin Murphy <robin.murphy@arm.com>
> 


  parent reply	other threads:[~2020-05-06 13:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05  3:13 [PATCH v6 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-05-05  3:13 ` Evan Benn
2020-05-05  3:13 ` Evan Benn
2020-05-05  3:13 ` [PATCH v6 1/2] dt-bindings: watchdog: Add ARM smc wdt for mt8173 watchdog Evan Benn
2020-05-05 19:09   ` Rob Herring
2020-05-06 13:45   ` Guenter Roeck [this message]
2020-05-05  3:13 ` [PATCH v6 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn
2020-05-05  3:13   ` Evan Benn
2020-05-05  3:13   ` Evan Benn
2020-05-05 20:09   ` Julius Werner
2020-05-05 20:09     ` Julius Werner
2020-05-05 20:09     ` Julius Werner
2020-05-06  6:21   ` Xingyu Chen
2020-05-06  6:21     ` Xingyu Chen
2020-05-06  6:21     ` Xingyu Chen
2020-05-06 13:46   ` Guenter Roeck
2020-05-06 13:46     ` Guenter Roeck
2020-05-06 13:46     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adbf700e-20e6-47db-a674-f965f65818c6@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=evanbenn@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=xingyu.chen@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.