All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Wang Yugui <wangyugui@e16-tech.com>
Cc: David Sterba <dsterba@suse.com>,
	Nikolay Borisov <nborisov@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs-progs: read device fsid from the sysfs
Date: Fri, 26 Aug 2022 18:18:12 +0800	[thread overview]
Message-ID: <ae82f677-42dc-fe00-d7f9-0b9a71ebb16e@oracle.com> (raw)
In-Reply-To: <20220826081444.A633.409509F4@e16-tech.com>

It worked on my end. I am on 6.0.0-rc1+.

Without the btrfs-progs patch mentioned in the test case:

----------------
btrfs/249       [failed, exit status 1]- output mismatch (see 
/xfstests-dev/results//btrfs/249.out.bad)
     --- tests/btrfs/249.out	2022-03-19 20:34:36.307019541 +0800
     +++ /xfstests-dev/results//btrfs/249.out.bad	2022-08-26 
17:23:53.912993906 +0800
     @@ -1,2 +1,5 @@
      QA output created by 249
     -Silence is golden
     +ERROR: unexpected number of devices: 1 >= 1
     +ERROR: if seed device is used, try running this command as root
     +FAILED: btrfs filesystem usage, ret 1. Check btrfs.ko and 
btrfs-progs version.
     +(see /xfstests-dev/results//btrfs/249.full for details)
     ...
     (Run 'diff -u /xfstests-dev/tests/btrfs/249.out 
/xfstests-dev/results//btrfs/249.out.bad'  to see the entire diff)
Ran: btrfs/249
Failures: btrfs/249
Failed 1 of 1 tests
----------------


With the btrfs-progs patch mentioned in the test case:

----------------
btrfs/249        1s
Ran: btrfs/249
Passed all 1 tests
----------------


> [ 1064.768430] BTRFS: device fsid 00ebd666-e838-4377-b9b6-aa69449297af devid 1 transid 6 /dev/sdb2 scanned by systemd-udevd (3602)
> [ 1064.781504] BTRFS: device fsid 00ebd666-e838-4377-b9b6-aa69449297af devid 2 transid 6 /dev/sdb3 scanned by systemd-udevd (3605)
> [ 1065.065938] BTRFS: device fsid 00ebd666-e838-4377-b9b6-aa69449297af devid 2 transid 7 /dev/sdb3 scanned by systemd-udevd (3602)

Two processes 3605 and 3602 are scanning the same device /dev/sdb3.
One finds transid 6, and the other 7.

You may want to re-test on a clean machine again.

Thanks, Anand


  reply	other threads:[~2022-08-26 10:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  0:23 [PATCH 0/2] btrfs-progs: read device fsid from the sysfs Anand Jain
2021-10-19  0:23 ` [PATCH 1/2] btrfs-progs: prepare helper device_is_seed Anand Jain
2021-10-19  0:23 ` [PATCH 2/2] btrfs-progs: read fsid from the sysfs in device_is_seed Anand Jain
2021-10-19 14:03   ` Josef Bacik
2021-10-20  2:40     ` Anand Jain
2021-10-20 13:47       ` Josef Bacik
2021-10-19 14:04 ` [PATCH 0/2] btrfs-progs: read device fsid from the sysfs Josef Bacik
2021-10-20  2:41   ` Anand Jain
2022-01-06  0:04 ` Anand Jain
2022-01-11 15:19   ` Nikolay Borisov
2022-01-21  9:29     ` Anand Jain
2022-08-26  0:14       ` Wang Yugui
2022-08-26 10:18         ` Anand Jain [this message]
2022-08-27  0:52           ` Wang Yugui
2022-08-10 10:18 ` Qu Wenruo
2022-08-10 11:18   ` Anand Jain
2022-08-10 11:43     ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae82f677-42dc-fe00-d7f9-0b9a71ebb16e@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    --cc=wangyugui@e16-tech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.