All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: clkfw: Moved the .init callback in the clk_register
Date: Wed, 13 May 2009 10:51:54 +0000	[thread overview]
Message-ID: <aec7e5c30905130351p22e72f3as8887177f013669eb@mail.gmail.com> (raw)
In-Reply-To: <1242050283-7986-1-git-send-email-francesco.virlinzi@st.com>

Hi Francesco,

On Wed, May 13, 2009 at 3:08 PM, Francesco VIRLINZI
<francesco.virlinzi@st.com> wrote:
> This patch moves the .init callback in the clk_register function.
> Moreover not the .init callback return a value:
>  - zero means the initialization is ok and the clock can be registered.
>  - any value not zero means there is a problem in the initialization and
>   the clkfw rejects the clock registration
>
> Signed-off-by: Francesco Virlinzi <francesco.virlinzi@st.com>

Thanks for submitting patches and doing so inline. =) Very good! I
have no major objections to this patch, but I'm not sure how well it
will apply to the future tree. I think Paul is doing some
restructuring of the clock framework in a separate branch so you may
want to have a look at that (in sh-2.6.git).

Cheers,

/ magnus

  parent reply	other threads:[~2009-05-13 10:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 13:58 [PATCH] sh: clkfw: Moved the .init callback in the clk_regsiter Francesco VIRLINZI
2009-05-12 21:42 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-13  6:08 ` [PATCH] sh: clkfw: Moved the .init callback in the clk_register function [v3] Francesco VIRLINZI
2009-05-13  7:32 ` [PATCH] sh: clkfw: Moved the .init callback in the clk_regsiter Francesco VIRLINZI
2009-05-13 10:51 ` Magnus Damm [this message]
2009-05-13 12:27 ` [PATCH] sh: clkfw: Moved the .init callback in the clk_register function [v4] Francesco VIRLINZI
2009-05-13 14:12 ` [PATCH] sh: clkfw: Moved the .init callback in the Jean-Christophe PLAGNIOL-VILLARD
2009-05-13 14:20 ` [PATCH] sh: clkfw: Moved the .init callback in the clk_register Francesco VIRLINZI
2009-05-14  3:52 ` [PATCH] sh: clkfw: Moved the .init callback in the clk_register function [v4] Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30905130351p22e72f3as8887177f013669eb@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.