All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: sh7724 clock framework rewrite
Date: Thu, 04 Jun 2009 07:53:54 +0000	[thread overview]
Message-ID: <aec7e5c30906040053k4247052fof8ada2fdad482b95@mail.gmail.com> (raw)
In-Reply-To: <20090602103459.13411.85023.sendpatchset@rx1.opensource.se>

Hi Morimoto-san,

Thanks for checking the patch!

On Wed, Jun 3, 2009 at 2:04 PM, Kuninori Morimoto
<morimoto.kuninori@renesas.com> wrote:
> on new clock-sh7724.c
>
>> +static unsigned long pll_recalc(struct clk *clk)
>> +{
>> +     return clk->parent->rate * (((__raw_readl(FRQCRA) >> 24) & 0x3f) + 1);
>> +}
>
> sh7724 needs "* 2" here.
> please check old clock-sh7722.c

Yes, you are correct. Thanks for finding this problem.

I've fixed this in V2 that I posted yesterday. Let me know if you find
any other issues.

Thanks,

/ magnus

  parent reply	other threads:[~2009-06-04  7:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 10:34 [PATCH] sh: sh7724 clock framework rewrite Magnus Damm
2009-06-03  5:04 ` Kuninori Morimoto
2009-06-03  8:43 ` [PATCH] sh: sh7724 clock framework rewrite V2 Magnus Damm
2009-06-04  7:53 ` Magnus Damm [this message]
2009-06-04  8:08 ` [PATCH] sh: sh7724 clock framework rewrite Kuninori Morimoto
2009-06-08 10:03 ` [PATCH] sh: sh7724 clock framework rewrite V2 Kuninori Morimoto
2009-06-09  8:04 ` Magnus Damm
2009-06-10 11:31 ` [PATCH] sh: sh7724 clock framework rewrite V3 Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30906040053k4247052fof8ada2fdad482b95@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.