From: Divyesh Shah <dpshah-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dhaval-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org,
fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org,
jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 02/19] io-controller: Common flat fair queuing code in elevaotor layer
Date: Tue, 16 Jun 2009 12:44:58 -0700 [thread overview]
Message-ID: <af41c7c40906161244q61fd47c5u1a10243c8839938__36450.8259146989$1245181626$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <1244513342-11758-3-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Mon, Jun 8, 2009 at 7:08 PM, Vivek Goyal<vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> void elv_deactivate_ioq(struct elv_fq_data *efqd, struct io_queue *ioq,
> + int requeue)
> +{
> + if (ioq == efqd->active_queue)
> + elv_reset_active_ioq(efqd);
> +
> + bfq_deactivate_entity(&ioq->entity, requeue);
> +}
The check for ioq == efqd->active_queue and the call to
elv_reset_active_ioq() seem to be unnecessary. This gets called from
elv_del_ioq_busy() which has 2 callers which:
- either explicitly check for ioq != efqd->active_queue
- or call elv_reset_active_ioq() right before invoking this function
This was needed earlier as the io_ioq_move() function didn't fall in
one of the 2 categories above. This has been done away with the ref
counting patch, AFAICT.
-Divyesh
next prev parent reply other threads:[~2009-06-16 19:44 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 2:08 [RFC] IO scheduler based IO controller V4 Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 01/19] io-controller: Documentation Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 02/19] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 8:45 ` Gui Jianfeng
2009-06-09 8:45 ` Gui Jianfeng
2009-06-16 3:54 ` Gui Jianfeng
2009-06-16 3:54 ` Gui Jianfeng
2009-06-16 13:02 ` Vivek Goyal
2009-06-16 13:02 ` Vivek Goyal
[not found] ` <4A37175C.80906-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-16 13:02 ` Vivek Goyal
[not found] ` <1244513342-11758-3-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-09 8:45 ` Gui Jianfeng
2009-06-16 3:54 ` Gui Jianfeng
2009-06-16 19:44 ` Divyesh Shah [this message]
2009-06-16 19:44 ` Divyesh Shah
2009-06-16 19:44 ` Divyesh Shah
2009-06-17 12:59 ` Vivek Goyal
2009-06-17 12:59 ` Vivek Goyal
[not found] ` <af41c7c40906161244q61fd47c5u1a10243c8839938-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-17 12:59 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 03/19] io-controller: Charge for time slice based on average disk rate Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 04/19] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-11 6:12 ` Gui Jianfeng
2009-06-11 14:21 ` Vivek Goyal
2009-06-11 14:21 ` Vivek Goyal
[not found] ` <4A30A05C.4060703-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-11 14:21 ` Vivek Goyal
[not found] ` <1244513342-11758-5-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-11 6:12 ` Gui Jianfeng
2009-06-15 8:56 ` Gui Jianfeng
2009-06-17 2:22 ` Gui Jianfeng
2009-06-15 8:56 ` Gui Jianfeng
2009-06-15 8:56 ` Gui Jianfeng
2009-06-15 13:02 ` Vivek Goyal
2009-06-15 13:02 ` Vivek Goyal
[not found] ` <4A360CD2.8060707-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-15 13:02 ` Vivek Goyal
2009-06-17 2:22 ` Gui Jianfeng
[not found] ` <4A385374.7060708-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-17 13:00 ` Vivek Goyal
2009-06-17 13:00 ` Vivek Goyal
2009-06-17 13:00 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 05/19] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 06/19] io-controller: cfq changes to use " Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 07/19] io-controller: Export disk time used and nr sectors dipatched through cgroups Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 08/19] io-controller: idle for sometime on sync queue before expiring it Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
[not found] ` <1244513342-11758-1-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-09 2:08 ` [PATCH 01/19] io-controller: Documentation Vivek Goyal
2009-06-09 2:08 ` [PATCH 02/19] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal
2009-06-09 2:08 ` [PATCH 03/19] io-controller: Charge for time slice based on average disk rate Vivek Goyal
2009-06-09 2:08 ` [PATCH 04/19] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal
2009-06-09 2:08 ` [PATCH 05/19] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal
2009-06-09 2:08 ` [PATCH 06/19] io-controller: cfq changes to use " Vivek Goyal
2009-06-09 2:08 ` [PATCH 07/19] io-controller: Export disk time used and nr sectors dipatched through cgroups Vivek Goyal
2009-06-09 2:08 ` [PATCH 08/19] io-controller: idle for sometime on sync queue before expiring it Vivek Goyal
2009-06-09 2:08 ` [PATCH 09/19] io-controller: Separate out queue and data Vivek Goyal
2009-06-09 2:08 ` [PATCH 10/19] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal
2009-06-09 2:08 ` [PATCH 11/19] io-controller: noop changes for hierarchical fair queuing Vivek Goyal
2009-06-09 2:08 ` [PATCH 12/19] io-controller: deadline " Vivek Goyal
2009-06-09 2:08 ` [PATCH 13/19] io-controller: anticipatory " Vivek Goyal
2009-06-09 2:08 ` [PATCH 14/19] blkio_cgroup patches from Ryo to track async bios Vivek Goyal
2009-06-09 2:08 ` [PATCH 15/19] io-controller: map async requests to appropriate cgroup Vivek Goyal
2009-06-09 2:08 ` [PATCH 16/19] io-controller: Per cgroup request descriptor support Vivek Goyal
2009-06-09 2:09 ` [PATCH 17/19] io-controller: Support per cgroup per device weights and io class Vivek Goyal
2009-06-09 2:09 ` [PATCH 18/19] io-controller: Debug hierarchical IO scheduling Vivek Goyal
2009-06-09 2:09 ` [PATCH 19/19] io-controller: experimental debug patch for async queue wait before expiry Vivek Goyal
2009-06-09 4:22 ` [RFC] IO scheduler based IO controller V4 Gui Jianfeng
2009-06-09 2:08 ` [PATCH 09/19] io-controller: Separate out queue and data Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 10/19] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-11 8:10 ` Gui Jianfeng
[not found] ` <4A30BC0F.3000401-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-11 14:41 ` Vivek Goyal
2009-06-11 14:41 ` Vivek Goyal
2009-06-11 14:41 ` Vivek Goyal
[not found] ` <20090611144136.GC27892-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-12 0:37 ` Gui Jianfeng
2009-06-12 0:37 ` Gui Jianfeng
2009-06-15 13:00 ` Vivek Goyal
2009-06-15 13:00 ` Vivek Goyal
[not found] ` <4A31A345.50705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-15 13:00 ` Vivek Goyal
[not found] ` <1244513342-11758-11-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-11 8:10 ` Gui Jianfeng
2009-06-09 2:08 ` [PATCH 11/19] io-controller: noop changes for hierarchical fair queuing Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 12/19] io-controller: deadline " Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 13/19] io-controller: anticipatory " Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 14/19] blkio_cgroup patches from Ryo to track async bios Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 15/19] io-controller: map async requests to appropriate cgroup Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
[not found] ` <1244513342-11758-16-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-17 9:17 ` Gui Jianfeng
2009-06-17 9:17 ` Gui Jianfeng
2009-06-17 9:17 ` Gui Jianfeng
2009-06-17 13:00 ` Vivek Goyal
2009-06-17 13:00 ` Vivek Goyal
[not found] ` <4A38B4B4.7060101-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-17 13:00 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 16/19] io-controller: Per cgroup request descriptor support Vivek Goyal
2009-06-09 2:08 ` Vivek Goyal
2009-06-09 2:09 ` [PATCH 17/19] io-controller: Support per cgroup per device weights and io class Vivek Goyal
2009-06-09 2:09 ` Vivek Goyal
[not found] ` <1244513342-11758-18-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-10 7:44 ` Gui Jianfeng
2009-06-10 7:44 ` Gui Jianfeng
2009-06-10 13:22 ` Vivek Goyal
2009-06-10 13:22 ` Vivek Goyal
[not found] ` <4A2F646A.8070403-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-10 13:22 ` Vivek Goyal
2009-06-09 2:09 ` [PATCH 18/19] io-controller: Debug hierarchical IO scheduling Vivek Goyal
2009-06-09 2:09 ` Vivek Goyal
2009-06-19 1:40 ` Gui Jianfeng
2009-06-19 14:05 ` Vivek Goyal
2009-06-19 14:05 ` Vivek Goyal
[not found] ` <4A3AEC96.7050500-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-19 14:05 ` Vivek Goyal
2009-06-19 6:26 ` Gui Jianfeng
2009-06-19 6:26 ` Gui Jianfeng
[not found] ` <4A3B2F7E.10405-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-19 14:08 ` Vivek Goyal
2009-06-19 14:08 ` Vivek Goyal
2009-06-19 14:08 ` Vivek Goyal
[not found] ` <1244513342-11758-19-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-19 1:40 ` Gui Jianfeng
2009-06-19 6:26 ` Gui Jianfeng
2009-06-09 2:09 ` [PATCH 19/19] io-controller: experimental debug patch for async queue wait before expiry Vivek Goyal
2009-06-09 2:09 ` Vivek Goyal
2009-06-09 4:22 ` [RFC] IO scheduler based IO controller V4 Gui Jianfeng
2009-06-09 4:22 ` Gui Jianfeng
[not found] ` <4A2DE381.6090205-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-09 13:52 ` Vivek Goyal
2009-06-09 13:52 ` Vivek Goyal
2009-06-09 13:52 ` Vivek Goyal
[not found] ` <20090609135256.GA13476-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-10 1:05 ` Gui Jianfeng
2009-06-10 1:05 ` Gui Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='af41c7c40906161244q61fd47c5u1a10243c8839938__36450.8259146989$1245181626$gmane$org@mail.gmail.com' \
--to=dpshah-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
--cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dhaval-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org \
--cc=jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org \
--cc=righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.