Re: [PATCH v3] mfd: cros: Update EC protocol to match current EC code

From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Gwendal Grignou <gwendal@chromium.org>,
	bleung@chromium.org, groeck@chromium.org, lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: cros: Update EC protocol to match current EC code
Date: Fri, 29 Mar 2019 14:36:30 +0100	[thread overview]
Message-ID: <af561dfd-ae1d-16a6-ed2b-b3876486e5e0@collabora.com> (raw)
In-Reply-To: <CAPUE2uvhfwwt31=AMKvH-kPGYZsjpGqbetGJ46sBU4owFPRgsg@mail.gmail.com>

Hi Gwendal,

After fix my problems manually ...

On 28/3/19 22:52, Gwendal Grignou wrote:
> Chromebook Embedded Controller protocol is defined in the kernel at
> cros_ec_commands.h.
> The source of trust for the EC protocol is at
> https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h
> 
> Only needed changes have been picked up from this file to the kernel
> include file leading to gaps between the upstream version and what the
> latest ECs can do.
> 
> Fill the gaps to ease future integrations. Changes from the original
> files is header/footer for license and include files for alignment.
> 
> Check this include file works on ChomeOS kernel 4.14 and 4.19 on eve.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes in v3:
> - No changes, resending
> 
> Changes in v2:
> - Replace 1 << with BIT()
> - Check checkpatch warning/errors are outside kernel scope.
> - Update .h with latest changes.
> 
>  include/linux/mfd/cros_ec_commands.h | 3723 +++++++++++++++++++++-----
>  1 file changed, 2992 insertions(+), 731 deletions(-)
> 
> diff --git a/include/linux/mfd/cros_ec_commands.h
> b/include/linux/mfd/cros_ec_commands.h
> index fc91082d4c35..5c4764e3db6f 100644
> --- a/include/linux/mfd/cros_ec_commands.h
> +++ b/include/linux/mfd/cros_ec_commands.h

[snip]

> 
>  /*
> - * For subcommand EC_CODEC_GET_GAIN.
> + * Entering Verified Boot Mode Command
> + * Default mode is VBOOT_MODE_NORMAL if EC did not receive this command.
> + * Valid Modes are: normal, developer, and recovery.
>   */
> -struct ec_response_codec_gain {
> -	uint8_t left;
> -	uint8_t right;
> -} __packed;

This causes a build problem in mainline as ec_response_codec_gain is used in
sound/soc/codecs/cros_ec_codec.c file, I don't see this struct anymore.

Apart from this the patch looks good to me.

Thanks,
 Enric