From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0474598330630764658==" MIME-Version: 1.0 From: Damien Le Moal To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/2] zonefs: Fix O_APPEND async write handling Date: Tue, 16 Mar 2021 01:11:57 +0000 Message-ID: < > In-Reply-To: <20210315170855.tguqrsl7wsbjojib@archlinux-ax161> List-Id: --===============0474598330630764658== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 2021/03/16 2:09, Nathan Chancellor wrote: > On Mon, Mar 15, 2021 at 07:22:56AM +0000, Damien Le Moal wrote: >> On 2021/03/15 16:21, Johannes Thumshirn wrote: >>> On 15/03/2021 08:16, kernel test robot wrote: >>>> 818 static ssize_t zonefs_file_dio_write(struct kiocb *iocb, struct io= v_iter *from) >>>> 819 { >>>> 820 struct inode *inode =3D file_inode(iocb->ki_filp); >>>> 821 struct zonefs_inode_info *zi =3D ZONEFS_I(inode); >>>> 822 struct super_block *sb =3D inode->i_sb; >>>> 823 bool sync =3D is_sync_kiocb(iocb); >>>> 824 bool append =3D false; >>>> 825 ssize_t ret, count; >>> >>>> 843 count =3D zonefs_write_checks(iocb, from); >>>> > 844 if (count <=3D 0) >>>> 845 goto inode_unlock; >>> >>> Args that needs to be: >>> if (count <=3D 0) { >>> ret =3D count; >>> goto inode_unlock; >>> } >>> >>> Sorry for not spotting it. >> >> Yep. Sending v2. Weird that gcc does not complain on my local compile... > = > Unfortunately, GCC's version of this warning was disabled for default > compiles by Linus in commit 78a5255ffb6a ("Stop the ad-hoc games with > -Wno-maybe-initialized"). W=3D2 is required, which can be quite noisy from > my understanding. KCFLAGS=3D-Wmaybe-uninitialized is a good option. I was not aware of that change. Thanks for the information ! -- = Damien Le Moal Western Digital Research --===============0474598330630764658==--