From: Sandor Yu <sandor.yu@nxp.com>
To: kbuild-all@lists.01.org
Subject: Re: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
Date: Fri, 22 Apr 2022 00:15:34 +0000 [thread overview]
Message-ID: < <DB7PR04MB545078BA054E5C78C5CCF9DBF4F79@DB7PR04MB5450.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <YmFzutFV/iDyEQF2@dd18de969aa6>
[-- Attachment #1: Type: text/plain, Size: 3538 bytes --]
> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: 2022年4月21日 23:10
> To: Sandor Yu <sandor.yu@nxp.com>
> Cc: kbuild-all(a)lists.01.org; Linux Memory Management List
> <linux-mm@kvack.org>; Robert Foss <robert.foss@linaro.org>; S.J. Wang
> <shengjiu.wang@nxp.com>; Neil Armstrong <narmstrong@baylibre.com>;
> Andrzej Hajda <andrzej.hajda@intel.com>; Laurent Pinchart
> <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>;
> Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel(a)lists.freedesktop.org;
> linux-kernel(a)vger.kernel.org
> Subject: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci
> warnings
>
> Caution: EXT Email
>
> From: kernel test robot <lkp@intel.com>
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded
> variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded
> variable: "ret". Return "0" on line 112
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&a
> mp;data=05%7C01%7CSandor.yu%40nxp.com%7C7028c89ce23940ff081408d
> a23a911c8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637861
> 506299960569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&am
> p;sdata=P1pum2Ur3I8occ5f1WAnVhnIIGB0Q1HXc2GsRbUx8p0%3D&res
> erved=0 master
> head: 65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm:
> bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
> struct hdmi_codec_params *params) {
> struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> - int ret = 0;
> u8 ca;
>
> dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
> params->iec.status[0] &
> IEC958_AES0_NONAUDIO);
> dw_hdmi_set_sample_width(dw->data.hdmi,
> params->sample_width);
>
> - return ret;
> + return 0;
> }
>
> static void audio_shutdown(struct device *dev, void *data) @@ -102,14
> +101,13 @@ static int audio_mute_stream(struct devi
> bool enable, int direction) {
> struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> - int ret = 0;
>
> if (!enable)
> dw_hdmi_audio_enable(dw->data.hdmi);
> else
> dw_hdmi_audio_disable(dw->data.hdmi);
>
> - return ret;
> + return 0;
> }
>
> static int audio_get_eld(struct device *dev, void *data,
Reviewed-by: Sandor Yu <Sandor.yu@nxp.com>
next prev parent reply other threads:[~2022-04-22 0:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 15:23 [linux-next:master 4441/5346] drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94 kernel test robot
2022-04-21 15:09 ` [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings kernel test robot
2022-04-21 15:09 ` kernel test robot
2022-04-21 16:47 ` Neil Armstrong
2022-04-21 16:47 ` Neil Armstrong
2022-04-21 16:47 ` Neil Armstrong
2022-04-22 0:15 ` Sandor Yu [this message]
2022-04-22 0:15 ` [EXT] " Sandor Yu
2022-04-22 0:15 ` Sandor Yu
2022-04-22 8:44 ` Neil Armstrong
2022-04-22 8:44 ` Neil Armstrong
2022-04-22 8:44 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=' <DB7PR04MB545078BA054E5C78C5CCF9DBF4F79@DB7PR04MB5450.eurprd04.prod.outlook.com' \
--to=sandor.yu@nxp.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.