All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sa, Nuno <Nuno.Sa@analog.com>
To: kbuild-all@lists.01.org
Subject: Re: [jic23-iio:testing 149/150] drivers/iio/dac/ad5593r.c:87 ad5593r_gpio_read() error: uninitialized symbol 'val'.
Date: Fri, 16 Sep 2022 07:11:54 +0000	[thread overview]
Message-ID: < <SJ0PR03MB6778F73D1F3C08012C6B277299489@SJ0PR03MB6778.namprd03.prod.outlook.com> (raw)
In-Reply-To: <202209160614.IE7ciPMN-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2492 bytes --]

Hi Dan,

> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Friday, September 16, 2022 8:56 AM
> To: kbuild(a)lists.01.org; Hennerich, Michael
> <Michael.Hennerich@analog.com>
> Cc: lkp(a)intel.com; kbuild-all(a)lists.01.org; linux-kernel(a)vger.kernel.org;
> Jonathan Cameron <Jonathan.Cameron@huawei.com>; Sa, Nuno
> <Nuno.Sa@analog.com>
> Subject: [jic23-iio:testing 149/150] drivers/iio/dac/ad5593r.c:87
> ad5593r_gpio_read() error: uninitialized symbol 'val'.
> 
> [External]
> 
> tree:
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/g
> it/jic23/iio.git__;!!A3Ni8CS0y2Y!94Jf_eIoy5zwbmsSRdWgugxbqkbgHFd0A88T
> z4SKRufGLX24YYSEzKlB13AXeYzsBWzd5HW-SqPpIzc8hvh-6w$   testing
> head:   62a6e699f4669b2c51f408273756f93b21c9f1a1
> commit: 53b6e3b2164c5807669fbf6b3df0e1494b4d03b8 [149/150] iio: dac:
> ad5593r: Fix i2c read protocol requirements
> config: x86_64-randconfig-m001
> compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> drivers/iio/dac/ad5593r.c:87 ad5593r_gpio_read() error: uninitialized symbol
> 'val'.
> 
> vim +/val +87 drivers/iio/dac/ad5593r.c
> 
> 56ca9db862bf3d7 Paul Cercueil     2016-04-05  79  static int
> ad5593r_gpio_read(struct ad5592r_state *st, u8 *value)
> 56ca9db862bf3d7 Paul Cercueil     2016-04-05  80  {
> 56ca9db862bf3d7 Paul Cercueil     2016-04-05  81  	struct i2c_client *i2c =
> to_i2c_client(st->dev);
> 53b6e3b2164c580 Michael Hennerich 2022-09-13  82  	u16 val;
> 53b6e3b2164c580 Michael Hennerich 2022-09-13  83  	int ret;
> 56ca9db862bf3d7 Paul Cercueil     2016-04-05  84
> 53b6e3b2164c580 Michael Hennerich 2022-09-13  85  	ret =
> ad5593r_read_word(i2c, AD5593R_MODE_GPIO_READBACK, &val);
> 56ca9db862bf3d7 Paul Cercueil     2016-04-05  86
> 56ca9db862bf3d7 Paul Cercueil     2016-04-05 @87  	*value = (u8) val;
> 
> 
> In the original code the error checking prevented reading uninitialized
> variables.  It's not really a problem, because ad5593r_read_word() can't
> actually fail but, you know?  Technically the checker is correct.

Hmm, in theory, it can if one of the i2c functions (for some reason) return error.
Not sure how to handle this... Given this is still in the testing branch should I
just re-spin another version of the series? Jonathan?

- Nuno Sá

      parent reply	other threads:[~2022-09-16  7:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 22:05 [jic23-iio:testing 149/150] drivers/iio/dac/ad5593r.c:87 ad5593r_gpio_read() error: uninitialized symbol 'val' kernel test robot
2022-09-16  6:55 ` Dan Carpenter
2022-09-16  6:55 ` Dan Carpenter
2022-09-16  7:11 ` Sa, Nuno
2022-09-16  8:38   ` Jonathan Cameron
2022-09-16  8:38     ` Jonathan Cameron
2022-09-16  8:58     ` Sa, Nuno
2022-09-16  8:58     ` Sa, Nuno
2022-09-16  7:11 ` Sa, Nuno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=' <SJ0PR03MB6778F73D1F3C08012C6B277299489@SJ0PR03MB6778.namprd03.prod.outlook.com' \
    --to=nuno.sa@analog.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.