[syzbot] [btrfs?] kernel BUG in btrfs_ioctl_add_dev

[syzbot] [btrfs?] kernel BUG in btrfs_ioctl_add_dev

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    c9c3395d5e3d Linux 6.2
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1216e630c80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=f4a1b2323673cc82
dashboard link: https://syzkaller.appspot.com/bug?extid=afdee14f9fd3d20448e7
compiler:       Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14c9a378c80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14e5c044c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/26e9c877102c/disk-c9c3395d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9e3e3feba050/vmlinux-c9c3395d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/21beac50cf7f/bzImage-c9c3395d.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/9f00aa255474/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+afdee14f9fd3d20448e7@syzkaller.appspotmail.com

assertion failed: fs_info->exclusive_operation == BTRFS_EXCLOP_BALANCE || fs_info->exclusive_operation == BTRFS_EXCLOP_DEV_ADD, in fs/btrfs/ioctl.c:457
------------[ cut here ]------------
kernel BUG at fs/btrfs/messages.c:259!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 6416 Comm: syz-executor132 Not tainted 6.2.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023
RIP: 0010:btrfs_assertfail+0x18/0x20 fs/btrfs/messages.c:259
Code: df e8 0c 2d 3c f7 e9 50 fb ff ff e8 e2 7e 01 00 66 90 66 0f 1f 00 89 d1 48 89 f2 48 89 fe 48 c7 c7 20 16 2c 8b e8 38 62 ff ff <0f> 0b 66 0f 1f 44 00 00 66 0f 1f 00 53 48 89 fb e8 03 f4 e6 f6 48
RSP: 0018:ffffc9000ca0fea0 EFLAGS: 00010246
RAX: 0000000000000097 RBX: 00000000fffffff2 RCX: eb26e11d15dcfa00
RDX: 0000000000000000 RSI: 0000000080000001 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff816efb3c R09: fffff52001941f8d
R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000
R13: 0000000000000003 R14: ffff888029d64680 R15: 1ffff110053acc1a
FS:  00007f9e79ad6700(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000077d02000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 btrfs_exclop_balance fs/btrfs/ioctl.c:456 [inline]
 btrfs_ioctl_add_dev+0x347/0x480 fs/btrfs/ioctl.c:2660
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f9e80f4b589
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 71 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9e79ad62f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f9e80fd57b0 RCX: 00007f9e80f4b589
RDX: 0000000000000000 RSI: 000000005000940a RDI: 0000000000000004
RBP: 00007f9e80fd57bc R08: 00007f9e79ad6700 R09: 0000000000000000
R10: 00007f9e79ad6700 R11: 0000000000000246 R12: 00007f9e80fa2660
R13: 01c8dfb098cf77b9 R14: 0030656c69662f2e R15: 00007f9e80fd57b8
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:btrfs_assertfail+0x18/0x20 fs/btrfs/messages.c:259
Code: df e8 0c 2d 3c f7 e9 50 fb ff ff e8 e2 7e 01 00 66 90 66 0f 1f 00 89 d1 48 89 f2 48 89 fe 48 c7 c7 20 16 2c 8b e8 38 62 ff ff <0f> 0b 66 0f 1f 44 00 00 66 0f 1f 00 53 48 89 fb e8 03 f4 e6 f6 48
RSP: 0018:ffffc9000ca0fea0 EFLAGS: 00010246
RAX: 0000000000000097 RBX: 00000000fffffff2 RCX: eb26e11d15dcfa00
RDX: 0000000000000000 RSI: 0000000080000001 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff816efb3c R09: fffff52001941f8d
R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000
R13: 0000000000000003 R14: ffff888029d64680 R15: 1ffff110053acc1a
FS:  00007f9e79ad6700(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000077d02000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: [syzbot] [btrfs?] kernel BUG in btrfs_ioctl_add_dev

[syzbot]

syzbot suspects this issue was fixed by commit:

commit ac868bc9d136cde6e3eb5de77019a63d57a540ff
Author: xiaoshoukui <xiaoshoukui@gmail.com>
Date:   Thu Apr 13 09:55:07 2023 +0000

    btrfs: fix assertion of exclop condition when starting balance

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12bdc3a3280000
start commit:   04a357b1f6f0 Merge tag 'mips_6.3_1' of git://git.kernel.or..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=f763d89e26d3d4c4
dashboard link: https://syzkaller.appspot.com/bug?extid=afdee14f9fd3d20448e7
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11f043b0c80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=15d2ea9cc80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: btrfs: fix assertion of exclop condition when starting balance

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: [syzbot] [btrfs?] kernel BUG in btrfs_ioctl_add_dev

[David Sterba]

On Tue, Jun 06, 2023 at 02:55:38AM -0700, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
> 
> commit ac868bc9d136cde6e3eb5de77019a63d57a540ff
> Author: xiaoshoukui <xiaoshoukui@gmail.com>
> Date:   Thu Apr 13 09:55:07 2023 +0000
> 
>     btrfs: fix assertion of exclop condition when starting balance
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12bdc3a3280000
> start commit:   04a357b1f6f0 Merge tag 'mips_6.3_1' of git://git.kernel.or..
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=f763d89e26d3d4c4
> dashboard link: https://syzkaller.appspot.com/bug?extid=afdee14f9fd3d20448e7
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11f043b0c80000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=15d2ea9cc80000
> 
> If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: btrfs: fix assertion of exclop condition when starting balance