[syzbot] [kernfs?] WARNING in kernfs_new_node (2)

[syzbot <syzbot+8db86fbe642e61a8ee00@syzkaller.appspotmail.com>]

Hello,

syzbot found the following issue on:

HEAD commit:    3d25a941ea50 Merge tag 'block-6.9-20240503' of git://git.k..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=177ed51f180000
kernel config:  https://syzkaller.appspot.com/x/.config?x=3714fc09f933e505
dashboard link: https://syzkaller.appspot.com/bug?extid=8db86fbe642e61a8ee00
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/e03ace4a616f/disk-3d25a941.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/14bf616395b8/vmlinux-3d25a941.xz
kernel image: https://storage.googleapis.com/syzbot-assets/197f0e10a223/bzImage-3d25a941.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8db86fbe642e61a8ee00@syzkaller.appspotmail.com

usb 1-1: Direct firmware load for ueagle-atm/eagleI.fw failed with error -2
usb 1-1: Falling back to sysfs fallback for: ueagle-atm/eagleI.fw
------------[ cut here ]------------
WARNING: CPU: 1 PID: 5150 at fs/kernfs/dir.c:526 kernfs_get fs/kernfs/dir.c:526 [inline]
WARNING: CPU: 1 PID: 5150 at fs/kernfs/dir.c:526 kernfs_new_node+0x1d8/0x240 fs/kernfs/dir.c:703
Modules linked in:
CPU: 1 PID: 5150 Comm: kworker/1:4 Not tainted 6.9.0-rc6-syzkaller-00227-g3d25a941ea50 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Workqueue: events request_firmware_work_func
RIP: 0010:kernfs_get fs/kernfs/dir.c:526 [inline]
RIP: 0010:kernfs_new_node+0x1d8/0x240 fs/kernfs/dir.c:703
Code: 74 08 48 89 ef e8 08 18 c4 ff 48 89 5d 00 4c 89 f0 48 83 c4 10 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc e8 59 6c 5f ff 90 <0f> 0b 90 eb a0 89 e9 80 e1 07 fe c1 38 c1 0f 8c 62 fe ff ff 48 89
RSP: 0018:ffffc900042bf578 EFLAGS: 00010293
RAX: ffffffff8236a467 RBX: ffff8880665f0d20 RCX: ffff88807cd43c00
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff8236a404 R09: 1ffff1100ccbe1a4
R10: dffffc0000000000 R11: ffffed100ccbe1a5 R12: 00000000000041ed
R13: 0000000000000000 R14: ffff88807bf364b0 R15: dffffc0000000000
FS:  0000000000000000(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055abc7e81a18 CR3: 000000007e9fe000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 kernfs_create_dir_ns+0x43/0x120 fs/kernfs/dir.c:1061
 sysfs_create_dir_ns+0x189/0x3a0 fs/sysfs/dir.c:59
 create_dir lib/kobject.c:73 [inline]
 kobject_add_internal+0x435/0x8d0 lib/kobject.c:240
 kobject_add_varg lib/kobject.c:374 [inline]
 kobject_add+0x152/0x220 lib/kobject.c:426
 class_dir_create_and_add drivers/base/core.c:3263 [inline]
 get_device_parent+0x391/0x410 drivers/base/core.c:3314
 device_add+0x331/0xca0 drivers/base/core.c:3644
 fw_load_sysfs_fallback drivers/base/firmware_loader/fallback.c:86 [inline]
 fw_load_from_user_helper drivers/base/firmware_loader/fallback.c:162 [inline]
 firmware_fallback_sysfs+0x307/0x9e0 drivers/base/firmware_loader/fallback.c:238
 _request_firmware+0xcf5/0x12b0 drivers/base/firmware_loader/main.c:914
 request_firmware_work_func+0x12a/0x280 drivers/base/firmware_loader/main.c:1165
 process_one_work kernel/workqueue.c:3267 [inline]
 process_scheduled_works+0xa10/0x17c0 kernel/workqueue.c:3348
 worker_thread+0x86d/0xd70 kernel/workqueue.c:3429
 kthread+0x2f0/0x390 kernel/kthread.c:388
 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup