From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E0BC64EC7 for ; Sat, 25 Feb 2023 15:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbjBYPUz (ORCPT ); Sat, 25 Feb 2023 10:20:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjBYPUy (ORCPT ); Sat, 25 Feb 2023 10:20:54 -0500 Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D3F9E39F for ; Sat, 25 Feb 2023 07:20:48 -0800 (PST) Received: by mail-io1-f69.google.com with SMTP id g21-20020a6be615000000b0074cb292f57dso1065435ioh.17 for ; Sat, 25 Feb 2023 07:20:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CfXn2umQQaWezeF7y9XIAa2NUnaytgkeNQPlI66Edsg=; b=E0HueDNkowecpmBZJgWxUbYADWhTEQIlYtaTBVz9L2BH1/zguEAJmZPZTRWXuzJ/MH ceLDIbZ8XJ7rajBowl+oeLgGcbyv7OV7FLjG3LHrTbyUl/T9bJX6bOODFiU8CoNxsUwL ilT9vz9hgrMffRmi4uJtlV4NI/qAJ5DnoeUn0i5AcuEJX4UAlCm13RWTw4te2vchrvdv fvDhzH3aUzluDpq+FttNCo6ZxLMthg2natjezhCOC+5NpXI1KPXS+zlrQLmC0FmcauFv E4DYJuPeGOPn5Ymj5SfyAYPL6L0SzB7eIiZ+5jdwneiTu4rxVnF3diKCV4yH1hs659d1 f+ag== X-Gm-Message-State: AO0yUKXk99iJPbnQy/4Q2PhlnyfY5vXhOOgzKuil0mdd0/KWJKunrCUa QFym1ZTb2bTKNcqM+7h2vehjVvIujJT+dOc9KAlQY9ZXJ91b X-Google-Smtp-Source: AK7set/+/FC0OZcIyVhxIQ0dl3Lz+7iSxgpFWoiAiDVDYBJ5cRQ2UiA1af1sn1/Rs13SNLPU9XP/ddf5tBct4mZXg30a8I16YdSZ MIME-Version: 1.0 X-Received: by 2002:a05:6638:2185:b0:3c2:c1c9:8bca with SMTP id s5-20020a056638218500b003c2c1c98bcamr2096487jaj.2.1677338447922; Sat, 25 Feb 2023 07:20:47 -0800 (PST) Date: Sat, 25 Feb 2023 07:20:47 -0800 In-Reply-To: <0000000000001b987605f47b72d3@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000005b4dd905f587caf8@google.com> Subject: Re: [syzbot] [overlayfs?] WARNING: locking bug in take_dentry_name_snapshot From: syzbot To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org, miklos@szeredi.hu, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org syzbot has found a reproducer for the following issue on: HEAD commit: 8232539f864c Add linux-next specific files for 20230225 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1774fe18c80000 kernel config: https://syzkaller.appspot.com/x/.config?x=4fe68735401a6111 dashboard link: https://syzkaller.appspot.com/bug?extid=5a195884ee3ad761db4e compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=144580a8c80000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/4259815e0cee/disk-8232539f.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/5ea6ea28200d/vmlinux-8232539f.xz kernel image: https://storage.googleapis.com/syzbot-assets/e461f15ffd6b/bzImage-8232539f.xz mounted in repro: https://storage.googleapis.com/syzbot-assets/c143f8fb2778/mount_0.gz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+5a195884ee3ad761db4e@syzkaller.appspotmail.com overlayfs: upper fs does not support tmpfile. ------------[ cut here ]------------ DEBUG_LOCKS_WARN_ON(1) WARNING: CPU: 1 PID: 6867 at kernel/locking/lockdep.c:232 hlock_class kernel/locking/lockdep.c:232 [inline] WARNING: CPU: 1 PID: 6867 at kernel/locking/lockdep.c:232 hlock_class kernel/locking/lockdep.c:221 [inline] WARNING: CPU: 1 PID: 6867 at kernel/locking/lockdep.c:232 check_wait_context kernel/locking/lockdep.c:4730 [inline] WARNING: CPU: 1 PID: 6867 at kernel/locking/lockdep.c:232 __lock_acquire+0x1615/0x5d40 kernel/locking/lockdep.c:5006 Modules linked in: CPU: 1 PID: 6867 Comm: syz-executor.1 Not tainted 6.2.0-next-20230225-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023 RIP: 0010:hlock_class kernel/locking/lockdep.c:232 [inline] RIP: 0010:hlock_class kernel/locking/lockdep.c:221 [inline] RIP: 0010:check_wait_context kernel/locking/lockdep.c:4730 [inline] RIP: 0010:__lock_acquire+0x1615/0x5d40 kernel/locking/lockdep.c:5006 Code: 08 84 d2 0f 85 b4 3d 00 00 8b 15 22 11 13 0d 85 d2 0f 85 31 fb ff ff 48 c7 c6 a0 74 4c 8a 48 c7 c7 e0 68 4c 8a e8 5b 4f e6 ff <0f> 0b 31 ed e9 e9 ed ff ff e8 2d 6f b3 02 85 c0 0f 84 c1 fa ff ff RSP: 0018:ffffc90008c877f8 EFLAGS: 00010086 RAX: 0000000000000000 RBX: ffffffff920012df RCX: 0000000000000000 RDX: ffff888018c1d7c0 RSI: ffffffff814c1907 RDI: 0000000000000001 RBP: 0000000000000f17 R08: 0000000000000001 R09: 0000000000000000 R10: 0000000000000000 R11: 000000002d2d2d2d R12: ffff888018c1e270 R13: ffff888018c1d7c0 R14: 0000000000040000 R15: 0000000000040f17 FS: 00007fe856e5e700(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f7e765fe000 CR3: 0000000077055000 CR4: 00000000003506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: lock_acquire.part.0+0x11a/0x370 kernel/locking/lockdep.c:5669 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:350 [inline] take_dentry_name_snapshot+0x2b/0x170 fs/dcache.c:315 ovl_check_rename_whiteout fs/overlayfs/super.c:1207 [inline] ovl_make_workdir fs/overlayfs/super.c:1329 [inline] ovl_get_workdir fs/overlayfs/super.c:1444 [inline] ovl_fill_super+0x2090/0x7270 fs/overlayfs/super.c:2000 mount_nodev+0x64/0x120 fs/super.c:1417 legacy_get_tree+0x109/0x220 fs/fs_context.c:610 vfs_get_tree+0x8d/0x350 fs/super.c:1501 do_new_mount fs/namespace.c:3042 [inline] path_mount+0x1342/0x1e40 fs/namespace.c:3372 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount fs/namespace.c:3571 [inline] __x64_sys_mount+0x283/0x300 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fe85608c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe856e5e168 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007fe8561abf80 RCX: 00007fe85608c0f9 RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000 RBP: 00007fe8560e7ae9 R08: 0000000020000480 R09: 0000000000000000 R10: 000000000000000b R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc3063990f R14: 00007fe856e5e300 R15: 0000000000022000