All of lore.kernel.org
 help / color / mirror / Atom feed
* [syzbot] [wireless?] WARNING in ieee80211_link_release_channel
@ 2023-09-03  1:48 syzbot
  2023-09-04  6:57 ` Johannes Berg
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: syzbot @ 2023-09-03  1:48 UTC (permalink / raw)
  To: davem, edumazet, johannes, kuba, linux-kernel, linux-wireless,
	netdev, pabeni, syzkaller-bugs

Hello,

syzbot found the following issue on:

HEAD commit:    d68b4b6f307d Merge tag 'mm-nonmm-stable-2023-08-28-22-48' ..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=147267b7a80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=c45ae22e154d76fa
dashboard link: https://syzkaller.appspot.com/bug?extid=9817a610349542589c42
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=128eab18680000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/eaa3c711dd68/disk-d68b4b6f.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/3ed6d023ff63/vmlinux-d68b4b6f.xz
kernel image: https://storage.googleapis.com/syzbot-assets/cc05f8831f38/bzImage-d68b4b6f.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9817a610349542589c42@syzkaller.appspotmail.com

RBP: 00007f64c7d70120 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 000000000000006e R14: 00007f64c719c050 R15: 00007f64c72bfa48
 </TASK>
wlan1: failed to insert STA entry for the AP (error -12)
------------[ cut here ]------------
WARNING: CPU: 0 PID: 7597 at net/mac80211/chan.c:2021 ieee80211_link_release_channel+0x19f/0x200 net/mac80211/chan.c:2021
Modules linked in:
CPU: 0 PID: 7597 Comm: syz-executor.5 Not tainted 6.5.0-syzkaller-04592-gd68b4b6f307d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
RIP: 0010:ieee80211_link_release_channel+0x19f/0x200 net/mac80211/chan.c:2021
Code: ff ff ff ff 48 8d b8 f0 1c 00 00 e8 3b 33 79 00 31 ff 41 89 c5 89 c6 e8 cf 7e c7 f7 45 85 ed 0f 85 6d ff ff ff e8 51 83 c7 f7 <0f> 0b e9 61 ff ff ff 48 c7 c7 d0 28 ad 8e e8 6e 2f 1d f8 e9 3a ff
RSP: 0018:ffffc9000a0d6b08 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffff88806730e3a8 RCX: 0000000000000000
RDX: ffff8880271ebb80 RSI: ffffffff89c00a5f RDI: 0000000000000005
RBP: ffff88806730cc80 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000001 R12: ffff88806730d580
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
FS:  00007f64c7d706c0(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f5579f1bff8 CR3: 0000000075757000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 ieee80211_prep_connection+0x62a/0x14f0 net/mac80211/mlme.c:7065
 ieee80211_mgd_auth+0xa1a/0x1490 net/mac80211/mlme.c:7205
 rdev_auth net/wireless/rdev-ops.h:481 [inline]
 cfg80211_mlme_auth+0x551/0x910 net/wireless/mlme.c:289
 cfg80211_conn_do_work+0x64e/0xfe0 net/wireless/sme.c:181
 cfg80211_sme_connect net/wireless/sme.c:638 [inline]
 cfg80211_connect+0xf07/0x20c0 net/wireless/sme.c:1528
 nl80211_connect+0x13ef/0x1d50 net/wireless/nl80211.c:12018
 genl_family_rcv_msg_doit+0x1fc/0x2e0 net/netlink/genetlink.c:971
 genl_family_rcv_msg net/netlink/genetlink.c:1051 [inline]
 genl_rcv_msg+0x55c/0x800 net/netlink/genetlink.c:1066
 netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2545
 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1075
 netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
 netlink_unicast+0x536/0x810 net/netlink/af_netlink.c:1368
 netlink_sendmsg+0x93c/0xe40 net/netlink/af_netlink.c:1910
 sock_sendmsg_nosec net/socket.c:728 [inline]
 sock_sendmsg+0xd9/0x180 net/socket.c:751
 ____sys_sendmsg+0x6ac/0x940 net/socket.c:2538
 ___sys_sendmsg+0x135/0x1d0 net/socket.c:2592
 __sys_sendmsg+0x117/0x1e0 net/socket.c:2621
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f64c707cae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f64c7d700c8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f64c719c050 RCX: 00007f64c707cae9
RDX: 0000000000000000 RSI: 00000000200001c0 RDI: 0000000000000003
RBP: 00007f64c7d70120 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 000000000000006e R14: 00007f64c719c050 R15: 00007f64c72bfa48
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [syzbot] [wireless?] WARNING in ieee80211_link_release_channel
  2023-09-03  1:48 [syzbot] [wireless?] WARNING in ieee80211_link_release_channel syzbot
@ 2023-09-04  6:57 ` Johannes Berg
  2023-11-07  8:25 ` syzbot
  2023-12-03 17:12 ` syzbot
  2 siblings, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2023-09-04  6:57 UTC (permalink / raw)
  To: syzbot, davem, edumazet, kuba, linux-kernel, linux-wireless,
	netdev, pabeni, syzkaller-bugs

On Sat, 2023-09-02 at 18:48 -0700, syzbot wrote:
> 
> WARNING: CPU: 0 PID: 7597 at net/mac80211/chan.c:2021 ieee80211_link_release_channel+0x19f/0x200 net/mac80211/chan.c:2021
> 

That's a lockdep warning, so it's kind of a known issue. I don't know if
I've yet encountered this specific way to get the locking checks
screaming, but generally we knew for a while that the locking was a bit
messy and possibly to some extent broken (*).

Anyway, point is - this is basically the reason I did this series:
https://lore.kernel.org/linux-wireless/20230828115927.116700-41-johannes@sipsolutions.net/

so this should go away - though sadly only in -next. Per the footnote, I
believe that the issue in the current kernel is mostly not an issue, and
it should only happen with multi-link in the first place. There may be
an issue in what syzbot found, processing a multi-link response or
something though.

johannes

(*) in many cases it's not _actually_ broken because we hold some common
outer lock anyway, so no data races are possible

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [syzbot] [wireless?] WARNING in ieee80211_link_release_channel
  2023-09-03  1:48 [syzbot] [wireless?] WARNING in ieee80211_link_release_channel syzbot
  2023-09-04  6:57 ` Johannes Berg
@ 2023-11-07  8:25 ` syzbot
  2023-12-03 17:12 ` syzbot
  2 siblings, 0 replies; 4+ messages in thread
From: syzbot @ 2023-11-07  8:25 UTC (permalink / raw)
  To: davem, edumazet, jiri, johannes, kuba, linux-kernel,
	linux-wireless, netdev, pabeni, syzkaller-bugs

syzbot has bisected this issue to:

commit c2368b19807affd7621f7c4638cd2e17fec13021
Author: Jiri Pirko <jiri@nvidia.com>
Date:   Fri Jul 29 07:10:35 2022 +0000

    net: devlink: introduce "unregistering" mark and use it during devlinks iteration

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1734cd60e80000
start commit:   d68b4b6f307d Merge tag 'mm-nonmm-stable-2023-08-28-22-48' ..
git tree:       upstream
final oops:     https://syzkaller.appspot.com/x/report.txt?x=14b4cd60e80000
console output: https://syzkaller.appspot.com/x/log.txt?x=10b4cd60e80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=c45ae22e154d76fa
dashboard link: https://syzkaller.appspot.com/bug?extid=9817a610349542589c42
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=128eab18680000

Reported-by: syzbot+9817a610349542589c42@syzkaller.appspotmail.com
Fixes: c2368b19807a ("net: devlink: introduce "unregistering" mark and use it during devlinks iteration")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [syzbot] [wireless?] WARNING in ieee80211_link_release_channel
  2023-09-03  1:48 [syzbot] [wireless?] WARNING in ieee80211_link_release_channel syzbot
  2023-09-04  6:57 ` Johannes Berg
  2023-11-07  8:25 ` syzbot
@ 2023-12-03 17:12 ` syzbot
  2 siblings, 0 replies; 4+ messages in thread
From: syzbot @ 2023-12-03 17:12 UTC (permalink / raw)
  To: davem, edumazet, emmanuel.grumbach, gregory.greenman, jiri,
	johannes.berg, johannes, kuba, linux-kernel, linux-wireless,
	netdev, pabeni, syzkaller-bugs

syzbot suspects this issue was fixed by commit:

commit 88717def36f7b19f12d6ad6644e73bf91cf86375
Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Date:   Wed Sep 13 11:56:51 2023 +0000

    wifi: iwlwifi: mvm: add a debug print when we get a BAR

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=161d9230e80000
start commit:   d68b4b6f307d Merge tag 'mm-nonmm-stable-2023-08-28-22-48' ..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=c45ae22e154d76fa
dashboard link: https://syzkaller.appspot.com/bug?extid=9817a610349542589c42
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=128eab18680000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: wifi: iwlwifi: mvm: add a debug print when we get a BAR

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-12-03 17:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-03  1:48 [syzbot] [wireless?] WARNING in ieee80211_link_release_channel syzbot
2023-09-04  6:57 ` Johannes Berg
2023-11-07  8:25 ` syzbot
2023-12-03 17:12 ` syzbot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.