[syzbot] memory leak in kvm_vcpu_ioctl_set_cpuid2

[syzbot] memory leak in kvm_vcpu_ioctl_set_cpuid2

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    0809edbae347 Merge tag 'devicetree-fixes-for-5.17-1' of gi..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17982967b00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=cc8d6c95ce1d56de
dashboard link: https://syzkaller.appspot.com/bug?extid=ead0473557070d5432cd
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1402f91fb00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17ba591fb00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ead0473557070d5432cd@syzkaller.appspotmail.com

BUG: memory leak
unreferenced object 0xffff88810963a800 (size 2048):
  comm "syz-executor025", pid 3610, jiffies 4294944928 (age 8.080s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 0d 00 00 00  ................
    47 65 6e 75 6e 74 65 6c 69 6e 65 49 00 00 00 00  GenuntelineI....
  backtrace:
    [<ffffffff814948ee>] kmalloc_node include/linux/slab.h:604 [inline]
    [<ffffffff814948ee>] kvmalloc_node+0x3e/0x100 mm/util.c:580
    [<ffffffff814950f2>] kvmalloc include/linux/slab.h:732 [inline]
    [<ffffffff814950f2>] vmemdup_user+0x22/0x100 mm/util.c:199
    [<ffffffff8109f5ff>] kvm_vcpu_ioctl_set_cpuid2+0x8f/0xf0 arch/x86/kvm/cpuid.c:423
    [<ffffffff810711b9>] kvm_arch_vcpu_ioctl+0xb99/0x1e60 arch/x86/kvm/x86.c:5251
    [<ffffffff8103e92d>] kvm_vcpu_ioctl+0x4ad/0x950 arch/x86/kvm/../../../virt/kvm/kvm_main.c:4066
    [<ffffffff815afacc>] vfs_ioctl fs/ioctl.c:51 [inline]
    [<ffffffff815afacc>] __do_sys_ioctl fs/ioctl.c:874 [inline]
    [<ffffffff815afacc>] __se_sys_ioctl fs/ioctl.c:860 [inline]
    [<ffffffff815afacc>] __x64_sys_ioctl+0xfc/0x140 fs/ioctl.c:860
    [<ffffffff844a3335>] do_syscall_x64 arch/x86/entry/common.c:50 [inline]
    [<ffffffff844a3335>] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
    [<ffffffff84600068>] entry_SYSCALL_64_after_hwframe+0x44/0xae



---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: [syzbot] memory leak in kvm_vcpu_ioctl_set_cpuid2

[Sean Christopherson]

On Wed, Jan 26, 2022, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    0809edbae347 Merge tag 'devicetree-fixes-for-5.17-1' of gi..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=17982967b00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=cc8d6c95ce1d56de
> dashboard link: https://syzkaller.appspot.com/bug?extid=ead0473557070d5432cd
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1402f91fb00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17ba591fb00000
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+ead0473557070d5432cd@syzkaller.appspotmail.com

#syz fix: KVM: x86: Free kvm_cpuid_entry2 array on post-KVM_RUN KVM_SET_CPUID{,2}