All of lore.kernel.org
 help / color / mirror / Atom feed
* [syzbot] BUG: unable to handle kernel paging request in ovl_set_acl
@ 2022-11-02 16:35 syzbot
  2022-11-03  2:35 ` syzbot
  0 siblings, 1 reply; 5+ messages in thread
From: syzbot @ 2022-11-02 16:35 UTC (permalink / raw)
  To: linux-kernel, linux-unionfs, miklos, syzkaller-bugs

Hello,

syzbot found the following issue on:

HEAD commit:    61c3426aca2c Add linux-next specific files for 20221102
git tree:       linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=178f72ac880000
kernel config:  https://syzkaller.appspot.com/x/.config?x=acb529cc910d907c
dashboard link: https://syzkaller.appspot.com/bug?extid=3f6ef1c4586bb6fd1f61
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/cc56d88dd6a3/disk-61c3426a.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/5921b65b080f/vmlinux-61c3426a.xz
kernel image: https://storage.googleapis.com/syzbot-assets/39cbd355fedd/bzImage-61c3426a.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+3f6ef1c4586bb6fd1f61@syzkaller.appspotmail.com

BUG: unable to handle page fault for address: ffffffffffffffc3
#PF: supervisor write access in kernel mode
#PF: error_code(0x0002) - not-present page
PGD bc8f067 P4D bc8f067 PUD bc91067 PMD 0 
Oops: 0002 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 25127 Comm: syz-executor.4 Not tainted 6.1.0-rc3-next-20221102-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
RIP: 0010:arch_atomic_fetch_sub arch/x86/include/asm/atomic.h:190 [inline]
RIP: 0010:atomic_fetch_sub_release include/linux/atomic/atomic-instrumented.h:177 [inline]
RIP: 0010:__refcount_sub_and_test include/linux/refcount.h:272 [inline]
RIP: 0010:__refcount_dec_and_test include/linux/refcount.h:315 [inline]
RIP: 0010:refcount_dec_and_test include/linux/refcount.h:333 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:57 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:55 [inline]
RIP: 0010:ovl_set_or_remove_acl fs/overlayfs/inode.c:624 [inline]
RIP: 0010:ovl_set_acl+0x730/0x910 fs/overlayfs/inode.c:685
Code: a3 24 ff 4c 89 ff 49 89 c4 e8 cc 2f 81 fe 4d 85 e4 74 7f e8 52 e9 ac fe be 04 00 00 00 4c 89 e7 bb ff ff ff ff e8 60 7a f9 fe <f0> 41 0f c1 1c 24 bf 01 00 00 00 89 de e8 fe e5 ac fe 83 fb 01 0f
RSP: 0018:ffffc9001264fad8 EFLAGS: 00010246
RAX: 0000000000000001 RBX: 00000000ffffffff RCX: ffffffff82cff810
RDX: fffffbfffffffff9 RSI: 0000000000000004 RDI: ffffffffffffffc3
RBP: ffff88804ebd2bc0 R08: 0000000000000001 R09: ffffffffffffffc6
R10: fffffbfffffffff8 R11: 0000000000000001 R12: ffffffffffffffc3
R13: ffff88804e8985f8 R14: 1ffff920024c9f60 R15: ffff88801f580100
FS:  00007fb9df1ff700(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffc3 CR3: 000000004dcf4000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 set_posix_acl+0x257/0x320 fs/posix_acl.c:957
 vfs_remove_acl+0x272/0x630 fs/posix_acl.c:1209
 removexattr+0x12a/0x1b0 fs/xattr.c:894
 path_removexattr+0x174/0x1a0 fs/xattr.c:910
 __do_sys_removexattr fs/xattr.c:924 [inline]
 __se_sys_removexattr fs/xattr.c:921 [inline]
 __x64_sys_removexattr+0x55/0x80 fs/xattr.c:921
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fb9dfe8b5a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb9df1ff168 EFLAGS: 00000246 ORIG_RAX: 00000000000000c5
RAX: ffffffffffffffda RBX: 00007fb9dffabf80 RCX: 00007fb9dfe8b5a9
RDX: 0000000000000000 RSI: 0000000020000040 RDI: 0000000020000000
RBP: 00007fb9dfee67b0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffdbc7f682f R14: 00007fb9df1ff300 R15: 0000000000022000
 </TASK>
Modules linked in:
CR2: ffffffffffffffc3
---[ end trace 0000000000000000 ]---
RIP: 0010:arch_atomic_fetch_sub arch/x86/include/asm/atomic.h:190 [inline]
RIP: 0010:atomic_fetch_sub_release include/linux/atomic/atomic-instrumented.h:177 [inline]
RIP: 0010:__refcount_sub_and_test include/linux/refcount.h:272 [inline]
RIP: 0010:__refcount_dec_and_test include/linux/refcount.h:315 [inline]
RIP: 0010:refcount_dec_and_test include/linux/refcount.h:333 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:57 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:55 [inline]
RIP: 0010:ovl_set_or_remove_acl fs/overlayfs/inode.c:624 [inline]
RIP: 0010:ovl_set_acl+0x730/0x910 fs/overlayfs/inode.c:685
Code: a3 24 ff 4c 89 ff 49 89 c4 e8 cc 2f 81 fe 4d 85 e4 74 7f e8 52 e9 ac fe be 04 00 00 00 4c 89 e7 bb ff ff ff ff e8 60 7a f9 fe <f0> 41 0f c1 1c 24 bf 01 00 00 00 89 de e8 fe e5 ac fe 83 fb 01 0f
RSP: 0018:ffffc9001264fad8 EFLAGS: 00010246
RAX: 0000000000000001 RBX: 00000000ffffffff RCX: ffffffff82cff810
RDX: fffffbfffffffff9 RSI: 0000000000000004 RDI: ffffffffffffffc3
RBP: ffff88804ebd2bc0 R08: 0000000000000001 R09: ffffffffffffffc6
R10: fffffbfffffffff8 R11: 0000000000000001 R12: ffffffffffffffc3
R13: ffff88804e8985f8 R14: 1ffff920024c9f60 R15: ffff88801f580100
FS:  00007fb9df1ff700(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffc3 CR3: 000000004dcf4000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	a3 24 ff 4c 89 ff 49 	movabs %eax,0xc48949ff894cff24
   7:	89 c4
   9:	e8 cc 2f 81 fe       	callq  0xfe812fda
   e:	4d 85 e4             	test   %r12,%r12
  11:	74 7f                	je     0x92
  13:	e8 52 e9 ac fe       	callq  0xfeace96a
  18:	be 04 00 00 00       	mov    $0x4,%esi
  1d:	4c 89 e7             	mov    %r12,%rdi
  20:	bb ff ff ff ff       	mov    $0xffffffff,%ebx
  25:	e8 60 7a f9 fe       	callq  0xfef97a8a
* 2a:	f0 41 0f c1 1c 24    	lock xadd %ebx,(%r12) <-- trapping instruction
  30:	bf 01 00 00 00       	mov    $0x1,%edi
  35:	89 de                	mov    %ebx,%esi
  37:	e8 fe e5 ac fe       	callq  0xfeace63a
  3c:	83 fb 01             	cmp    $0x1,%ebx
  3f:	0f                   	.byte 0xf


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] BUG: unable to handle kernel paging request in ovl_set_acl
  2022-11-02 16:35 [syzbot] BUG: unable to handle kernel paging request in ovl_set_acl syzbot
@ 2022-11-03  2:35 ` syzbot
  2022-11-03  7:25   ` Christian Brauner
  0 siblings, 1 reply; 5+ messages in thread
From: syzbot @ 2022-11-03  2:35 UTC (permalink / raw)
  To: linux-kernel, linux-unionfs, miklos, syzkaller-bugs

syzbot has found a reproducer for the following issue on:

HEAD commit:    61c3426aca2c Add linux-next specific files for 20221102
git tree:       linux-next
console+strace: https://syzkaller.appspot.com/x/log.txt?x=118e21de880000
kernel config:  https://syzkaller.appspot.com/x/.config?x=acb529cc910d907c
dashboard link: https://syzkaller.appspot.com/bug?extid=3f6ef1c4586bb6fd1f61
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1620a689880000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=153fb2a9880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/cc56d88dd6a3/disk-61c3426a.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/5921b65b080f/vmlinux-61c3426a.xz
kernel image: https://storage.googleapis.com/syzbot-assets/39cbd355fedd/bzImage-61c3426a.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+3f6ef1c4586bb6fd1f61@syzkaller.appspotmail.com

BUG: unable to handle page fault for address: ffffffffffffffc3
#PF: supervisor write access in kernel mode
#PF: error_code(0x0002) - not-present page
PGD bc8f067 P4D bc8f067 PUD bc91067 PMD 0 
Oops: 0002 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 5240 Comm: syz-executor244 Not tainted 6.1.0-rc3-next-20221102-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
RIP: 0010:arch_atomic_fetch_sub arch/x86/include/asm/atomic.h:190 [inline]
RIP: 0010:atomic_fetch_sub_release include/linux/atomic/atomic-instrumented.h:177 [inline]
RIP: 0010:__refcount_sub_and_test include/linux/refcount.h:272 [inline]
RIP: 0010:__refcount_dec_and_test include/linux/refcount.h:315 [inline]
RIP: 0010:refcount_dec_and_test include/linux/refcount.h:333 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:57 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:55 [inline]
RIP: 0010:ovl_set_or_remove_acl fs/overlayfs/inode.c:624 [inline]
RIP: 0010:ovl_set_acl+0x730/0x910 fs/overlayfs/inode.c:685
Code: a3 24 ff 4c 89 ff 49 89 c4 e8 cc 2f 81 fe 4d 85 e4 74 7f e8 52 e9 ac fe be 04 00 00 00 4c 89 e7 bb ff ff ff ff e8 60 7a f9 fe <f0> 41 0f c1 1c 24 bf 01 00 00 00 89 de e8 fe e5 ac fe 83 fb 01 0f
RSP: 0018:ffffc90003c0fad8 EFLAGS: 00010246
RAX: 0000000000000001 RBX: 00000000ffffffff RCX: ffffffff82cff810
RDX: fffffbfffffffff9 RSI: 0000000000000004 RDI: ffffffffffffffc3
RBP: ffff888078a5ca48 R08: 0000000000000001 R09: ffffffffffffffc6
R10: fffffbfffffffff8 R11: 0000000000000001 R12: ffffffffffffffc3
R13: ffff8880764ba330 R14: 1ffff92000781f60 R15: ffff888024e04f00
FS:  0000555555b7c300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffc3 CR3: 0000000026941000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 set_posix_acl+0x257/0x320 fs/posix_acl.c:957
 vfs_remove_acl+0x272/0x630 fs/posix_acl.c:1209
 removexattr+0x12a/0x1b0 fs/xattr.c:894
 path_removexattr+0x174/0x1a0 fs/xattr.c:910
 __do_sys_removexattr fs/xattr.c:924 [inline]
 __se_sys_removexattr fs/xattr.c:921 [inline]
 __x64_sys_removexattr+0x55/0x80 fs/xattr.c:921
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f653cc6fbf9
Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffffec22658 EFLAGS: 00000246 ORIG_RAX: 00000000000000c5
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f653cc6fbf9
RDX: 00007f653cc6fbf9 RSI: 0000000020000040 RDI: 0000000020000000
RBP: 00007f653cc33da0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020000280 R11: 0000000000000246 R12: 00007f653cc33e30
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
 </TASK>
Modules linked in:
CR2: ffffffffffffffc3
---[ end trace 0000000000000000 ]---
RIP: 0010:arch_atomic_fetch_sub arch/x86/include/asm/atomic.h:190 [inline]
RIP: 0010:atomic_fetch_sub_release include/linux/atomic/atomic-instrumented.h:177 [inline]
RIP: 0010:__refcount_sub_and_test include/linux/refcount.h:272 [inline]
RIP: 0010:__refcount_dec_and_test include/linux/refcount.h:315 [inline]
RIP: 0010:refcount_dec_and_test include/linux/refcount.h:333 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:57 [inline]
RIP: 0010:posix_acl_release include/linux/posix_acl.h:55 [inline]
RIP: 0010:ovl_set_or_remove_acl fs/overlayfs/inode.c:624 [inline]
RIP: 0010:ovl_set_acl+0x730/0x910 fs/overlayfs/inode.c:685
Code: a3 24 ff 4c 89 ff 49 89 c4 e8 cc 2f 81 fe 4d 85 e4 74 7f e8 52 e9 ac fe be 04 00 00 00 4c 89 e7 bb ff ff ff ff e8 60 7a f9 fe <f0> 41 0f c1 1c 24 bf 01 00 00 00 89 de e8 fe e5 ac fe 83 fb 01 0f
RSP: 0018:ffffc90003c0fad8 EFLAGS: 00010246
RAX: 0000000000000001 RBX: 00000000ffffffff RCX: ffffffff82cff810
RDX: fffffbfffffffff9 RSI: 0000000000000004 RDI: ffffffffffffffc3
RBP: ffff888078a5ca48 R08: 0000000000000001 R09: ffffffffffffffc6
R10: fffffbfffffffff8 R11: 0000000000000001 R12: ffffffffffffffc3
R13: ffff8880764ba330 R14: 1ffff92000781f60 R15: ffff888024e04f00
FS:  0000555555b7c300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffc3 CR3: 0000000026941000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	a3 24 ff 4c 89 ff 49 	movabs %eax,0xc48949ff894cff24
   7:	89 c4
   9:	e8 cc 2f 81 fe       	callq  0xfe812fda
   e:	4d 85 e4             	test   %r12,%r12
  11:	74 7f                	je     0x92
  13:	e8 52 e9 ac fe       	callq  0xfeace96a
  18:	be 04 00 00 00       	mov    $0x4,%esi
  1d:	4c 89 e7             	mov    %r12,%rdi
  20:	bb ff ff ff ff       	mov    $0xffffffff,%ebx
  25:	e8 60 7a f9 fe       	callq  0xfef97a8a
* 2a:	f0 41 0f c1 1c 24    	lock xadd %ebx,(%r12) <-- trapping instruction
  30:	bf 01 00 00 00       	mov    $0x1,%edi
  35:	89 de                	mov    %ebx,%esi
  37:	e8 fe e5 ac fe       	callq  0xfeace63a
  3c:	83 fb 01             	cmp    $0x1,%ebx
  3f:	0f                   	.byte 0xf


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] BUG: unable to handle kernel paging request in ovl_set_acl
  2022-11-03  2:35 ` syzbot
@ 2022-11-03  7:25   ` Christian Brauner
  2022-11-03 11:40     ` syzbot
  0 siblings, 1 reply; 5+ messages in thread
From: Christian Brauner @ 2022-11-03  7:25 UTC (permalink / raw)
  To: syzbot; +Cc: linux-kernel, linux-unionfs, miklos, syzkaller-bugs

On Wed, Nov 02, 2022 at 07:35:42PM -0700, syzbot wrote:
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    61c3426aca2c Add linux-next specific files for 20221102
> git tree:       linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=118e21de880000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=acb529cc910d907c
> dashboard link: https://syzkaller.appspot.com/bug?extid=3f6ef1c4586bb6fd1f61
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1620a689880000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=153fb2a9880000
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/cc56d88dd6a3/disk-61c3426a.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/5921b65b080f/vmlinux-61c3426a.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/39cbd355fedd/bzImage-61c3426a.xz
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+3f6ef1c4586bb6fd1f61@syzkaller.appspotmail.com

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git/ 5b52aebef8954cadff29918bb61d7fdc7be07837

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] BUG: unable to handle kernel paging request in ovl_set_acl
  2022-11-03  7:25   ` Christian Brauner
@ 2022-11-03 11:40     ` syzbot
  2022-11-03 14:23       ` Christian Brauner
  0 siblings, 1 reply; 5+ messages in thread
From: syzbot @ 2022-11-03 11:40 UTC (permalink / raw)
  To: brauner, linux-kernel, linux-unionfs, miklos, syzkaller-bugs

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

ut Driver Registering...
[    7.160509][    T1] Key type cifs.spnego registered
[    7.161598][    T1] Key type cifs.idmap registered
[    7.162926][    T1] ntfs: driver 2.1.32 [Flags: R/W].
[    7.165563][    T1] ntfs3: Max link count 4000
[    7.167071][    T1] ntfs3: Enabled Linux POSIX ACLs support
[    7.167935][    T1] ntfs3: Read-only LZX/Xpress compression included
[    7.170325][    T1] efs: 1.0a - http://aeschi.ch.eu.org/efs/
[    7.171768][    T1] jffs2: version 2.2. (NAND) (SUMMARY)  © 2001-2006 Red Hat, Inc.
[    7.177918][    T1] romfs: ROMFS MTD (C) 2007 Red Hat, Inc.
[    7.179712][    T1] QNX4 filesystem 0.2.3 registered.
[    7.180796][    T1] qnx6: QNX6 filesystem 1.0.0 registered.
[    7.182825][    T1] fuse: init (API version 7.37)
[    7.188322][    T1] orangefs_debugfs_init: called with debug mask: :none: :0:
[    7.190047][    T1] orangefs_init: module version upstream loaded
[    7.192129][    T1] JFS: nTxBlock = 8192, nTxLock = 65536
[    7.210458][    T1] SGI XFS with ACLs, security attributes, realtime, quota, fatal assert, debug enabled
[    7.225322][    T1] 9p: Installing v9fs 9p2000 file system support
[    7.228885][    T1] NILFS version 2 loaded
[    7.230107][    T1] befs: version: 0.9.3
[    7.232727][    T1] ocfs2: Registered cluster interface o2cb
[    7.235500][    T1] ocfs2: Registered cluster interface user
[    7.237529][    T1] OCFS2 User DLM kernel interface loaded
[    7.250453][    T1] gfs2: GFS2 installed
[    7.264209][    T1] ceph: loaded (mds proto 32)
[    7.278952][    T1] NET: Registered PF_ALG protocol family
[    7.280354][    T1] xor: automatically using best checksumming function   avx       
[    7.281560][    T1] async_tx: api initialized (async)
[    7.282618][    T1] Key type asymmetric registered
[    7.283598][    T1] Asymmetric key parser 'x509' registered
[    7.284695][    T1] Asymmetric key parser 'pkcs8' registered
[    7.285759][    T1] Key type pkcs7_test registered
[    7.290183][    T1] alg: self-tests for CTR-KDF (hmac(sha256)) passed
[    7.291911][    T1] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 240)
[    7.294225][    T1] io scheduler mq-deadline registered
[    7.295495][    T1] io scheduler kyber registered
[    7.297344][    T1] io scheduler bfq registered
[    7.309105][    T1] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input0
[    7.346741][    T1] ACPI: button: Power Button [PWRF]
[    7.349041][    T1] input: Sleep Button as /devices/LNXSYSTM:00/LNXSLPBN:00/input/input1
[    7.351595][    T1] ACPI: button: Sleep Button [SLPF]
[    7.377641][    T1] ACPI: \_SB_.LNKC: Enabled at IRQ 11
[    7.378625][    T1] virtio-pci 0000:00:03.0: virtio_pci: leaving for legacy driver
[    7.396163][    T1] ACPI: \_SB_.LNKD: Enabled at IRQ 10
[    7.397343][    T1] virtio-pci 0000:00:04.0: virtio_pci: leaving for legacy driver
[    7.417084][    T1] ACPI: \_SB_.LNKB: Enabled at IRQ 10
[    7.418128][    T1] virtio-pci 0000:00:06.0: virtio_pci: leaving for legacy driver
[    7.431573][    T1] virtio-pci 0000:00:07.0: virtio_pci: leaving for legacy driver
[    7.467042][  T220] kworker/u4:1 (220) used greatest stack depth: 27056 bytes left
[    7.472746][  T221] kworker/u4:1 (221) used greatest stack depth: 26960 bytes left
[    7.880988][    T1] N_HDLC line discipline registered with maxframe=4096
[    7.882545][    T1] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
[    7.884539][    T1] 00:03: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
[    7.893541][    T1] 00:04: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A
[    7.903006][    T1] 00:05: ttyS2 at I/O 0x3e8 (irq = 6, base_baud = 115200) is a 16550A
[    7.910260][    T1] 00:06: ttyS3 at I/O 0x2e8 (irq = 7, base_baud = 115200) is a 16550A
[    7.930315][    T1] Non-volatile memory driver v1.3
[    7.944423][    T1] Linux agpgart interface v0.103
[    7.947331][    T1] ACPI: bus type drm_connector registered
[    7.954182][    T1] [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0
[    7.964299][    T1] [drm] Initialized vkms 1.0.0 20180514 for vkms on minor 1
[    8.028476][    T1] Console: switching to colour frame buffer device 128x48
[    8.046434][    T1] platform vkms: [drm] fb0: vkmsdrmfb frame buffer device
[    8.047778][    T1] usbcore: registered new interface driver udl
[    8.112535][    T1] brd: module loaded
[    8.178418][    T1] loop: module loaded
[    8.269685][    T1] zram: Added device: zram0
[    8.277914][    T1] null_blk: disk nullb0 created
[    8.279227][    T1] null_blk: module loaded
[    8.280291][    T1] Guest personality initialized and is inactive
[    8.282253][    T1] VMCI host device registered (name=vmci, major=10, minor=119)
[    8.283868][    T1] Initialized host personality
[    8.285398][    T1] usbcore: registered new interface driver rtsx_usb
[    8.288036][    T1] usbcore: registered new interface driver viperboard
[    8.290550][    T1] usbcore: registered new interface driver dln2
[    8.292673][    T1] usbcore: registered new interface driver pn533_usb
[    8.299242][    T1] nfcsim 0.2 initialized
[    8.300323][    T1] usbcore: registered new interface driver port100
[    8.301868][    T1] usbcore: registered new interface driver nfcmrvl
[    8.308006][    T1] Loading iSCSI transport class v2.0-870.
[    8.345112][    T1] scsi host0: Virtio SCSI HBA
[    8.389808][    T1] st: Version 20160209, fixed bufsize 32768, s/g segs 256
[    8.394047][   T11] scsi 0:0:1:0: Direct-Access     Google   PersistentDisk   1    PQ: 0 ANSI: 6
[    8.427169][    T1] Rounding down aligned max_sectors from 4294967295 to 4294967288
[    8.430280][    T1] db_root: cannot open: /etc/target
[    8.432877][    T1] slram: not enough parameters.
[    8.441807][    T1] ftl_cs: FTL header not found.
[    8.500648][    T1] wireguard: WireGuard 1.0.0 loaded. See www.wireguard.com for information.
[    8.502726][    T1] wireguard: Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
[    8.505442][    T1] eql: Equalizer2002: Simon Janes (simon@ncm.com) and David S. Miller (davem@redhat.com)
[    8.516453][    T1] MACsec IEEE 802.1AE
[    8.525424][    T1] tun: Universal TUN/TAP device driver, 1.6
[    8.571093][    T1] ------------[ cut here ]------------
[    8.572622][    T1] WARNING: CPU: 0 PID: 1 at include/linux/cpumask.h:110 __netif_set_xps_queue+0x88e/0x1f30
[    8.574863][    T1] Modules linked in:
[    8.575981][    T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc1-syzkaller-00034-g5b52aebef895 #0
[    8.578509][    T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
[    8.581053][    T1] RIP: 0010:__netif_set_xps_queue+0x88e/0x1f30
[    8.582714][    T1] Code: fa 48 c7 c2 a0 a8 f4 8a be 2e 0a 00 00 48 c7 c7 40 a7 f4 8a c6 05 c2 40 74 06 01 e8 52 ca f1 01 e9 ef fd ff ff e8 d2 81 24 fa <0f> 0b e9 8e fa ff ff 8b 6c 24 38 e8 c2 81 24 fa 49 8d 7c 24 04 48
[    8.587669][    T1] RSP: 0000:ffffc90000067898 EFLAGS: 00010293
[    8.589339][    T1] RAX: 0000000000000000 RBX: 0000000000000002 RCX: 0000000000000000
[    8.591592][    T1] RDX: ffff88813fe50000 RSI: ffffffff875805ae RDI: 0000000000000004
[    8.593717][    T1] RBP: 0000000000000002 R08: 0000000000000004 R09: 0000000000000002
[    8.595628][    T1] R10: 0000000000000002 R11: 000000000008c07e R12: ffff88801ce1c280
[    8.597437][    T1] R13: 0000000000000003 R14: ffff88801ce1c298 R15: 0000000000000002
[    8.599572][    T1] FS:  0000000000000000(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000
[    8.601992][    T1] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    8.603566][    T1] CR2: ffff88823ffff000 CR3: 000000000bc8e000 CR4: 00000000003506f0
[    8.605629][    T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[    8.607162][    T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[    8.608617][    T1] Call Trace:
[    8.609378][    T1]  <TASK>
[    8.610085][    T1]  ? vp_bus_name+0xc0/0xc0
[    8.611086][    T1]  virtnet_set_affinity+0x4f0/0x750
[    8.612333][    T1]  ? skb_recv_done+0x120/0x120
[    8.613675][    T1]  virtnet_probe+0x12ae/0x31e0
[    8.614678][    T1]  ? virtnet_find_vqs+0xc30/0xc30
[    8.615861][    T1]  virtio_dev_probe+0x577/0x870
[    8.617108][    T1]  ? virtio_features_ok+0x1e0/0x1e0
[    8.618369][    T1]  really_probe+0x249/0xb90
[    8.619549][    T1]  __driver_probe_device+0x1df/0x4d0
[    8.621025][    T1]  driver_probe_device+0x4c/0x1a0
[    8.622503][    T1]  __driver_attach+0x1d0/0x550
[    8.623795][    T1]  ? __device_attach_driver+0x2e0/0x2e0
[    8.625384][    T1]  bus_for_each_dev+0x147/0x1d0
[    8.626734][    T1]  ? subsys_dev_iter_exit+0x20/0x20
[    8.628079][    T1]  bus_add_driver+0x4c9/0x640
[    8.629430][    T1]  driver_register+0x220/0x3a0
[    8.630693][    T1]  ? veth_init+0x11/0x11
[    8.631946][    T1]  virtio_net_driver_init+0x93/0xd2
[    8.633254][    T1]  do_one_initcall+0x13d/0x780
[    8.634741][    T1]  ? trace_event_raw_event_initcall_level+0x1f0/0x1f0
[    8.636673][    T1]  ? parameq+0x140/0x170
[    8.637876][    T1]  kernel_init_freeable+0x6ff/0x788
[    8.639145][    T1]  ? rest_init+0x270/0x270
[    8.640483][    T1]  kernel_init+0x1a/0x1d0
[    8.641440][    T1]  ? rest_init+0x270/0x270
[    8.642564][    T1]  ret_from_fork+0x1f/0x30
[    8.643863][    T1]  </TASK>
[    8.644754][    T1] Kernel panic - not syncing: panic_on_warn set ...
[    8.646087][    T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc1-syzkaller-00034-g5b52aebef895 #0
[    8.646528][    T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
[    8.646528][    T1] Call Trace:
[    8.646528][    T1]  <TASK>
[    8.646528][    T1]  dump_stack_lvl+0xcd/0x134
[    8.646528][    T1]  panic+0x2c8/0x622
[    8.646528][    T1]  ? panic_print_sys_info.part.0+0x110/0x110
[    8.646528][    T1]  ? __warn.cold+0x24b/0x350
[    8.646528][    T1]  ? __netif_set_xps_queue+0x88e/0x1f30
[    8.646528][    T1]  __warn.cold+0x25c/0x350
[    8.646528][    T1]  ? __netif_set_xps_queue+0x88e/0x1f30
[    8.646528][    T1]  report_bug+0x1bc/0x210
[    8.646528][    T1]  handle_bug+0x3c/0x70
[    8.646528][    T1]  exc_invalid_op+0x14/0x40
[    8.646528][    T1]  asm_exc_invalid_op+0x16/0x20
[    8.646528][    T1] RIP: 0010:__netif_set_xps_queue+0x88e/0x1f30
[    8.646528][    T1] Code: fa 48 c7 c2 a0 a8 f4 8a be 2e 0a 00 00 48 c7 c7 40 a7 f4 8a c6 05 c2 40 74 06 01 e8 52 ca f1 01 e9 ef fd ff ff e8 d2 81 24 fa <0f> 0b e9 8e fa ff ff 8b 6c 24 38 e8 c2 81 24 fa 49 8d 7c 24 04 48
[    8.646528][    T1] RSP: 0000:ffffc90000067898 EFLAGS: 00010293
[    8.646528][    T1] RAX: 0000000000000000 RBX: 0000000000000002 RCX: 0000000000000000
[    8.646528][    T1] RDX: ffff88813fe50000 RSI: ffffffff875805ae RDI: 0000000000000004
[    8.646528][    T1] RBP: 0000000000000002 R08: 0000000000000004 R09: 0000000000000002
[    8.646528][    T1] R10: 0000000000000002 R11: 000000000008c07e R12: ffff88801ce1c280
[    8.646528][    T1] R13: 0000000000000003 R14: ffff88801ce1c298 R15: 0000000000000002
[    8.646528][    T1]  ? __netif_set_xps_queue+0x88e/0x1f30
[    8.646528][    T1]  ? __netif_set_xps_queue+0x88e/0x1f30
[    8.646528][    T1]  ? vp_bus_name+0xc0/0xc0
[    8.646528][    T1]  virtnet_set_affinity+0x4f0/0x750
[    8.646528][    T1]  ? skb_recv_done+0x120/0x120
[    8.646528][    T1]  virtnet_probe+0x12ae/0x31e0
[    8.646528][    T1]  ? virtnet_find_vqs+0xc30/0xc30
[    8.646528][    T1]  virtio_dev_probe+0x577/0x870
[    8.646528][    T1]  ? virtio_features_ok+0x1e0/0x1e0
[    8.646528][    T1]  really_probe+0x249/0xb90
[    8.694969][    T1]  __driver_probe_device+0x1df/0x4d0
[    8.694969][    T1]  driver_probe_device+0x4c/0x1a0
[    8.694969][    T1]  __driver_attach+0x1d0/0x550
[    8.694969][    T1]  ? __device_attach_driver+0x2e0/0x2e0
[    8.699777][ T1090] sd 0:0:1:0: [sda] 4194304 512-byte logical blocks: (2.15 GB/2.00 GiB)
[    8.699831][ T1090] sd 0:0:1:0: [sda] 4096-byte physical blocks
[    8.699980][ T1090] sd 0:0:1:0: [sda] Write Protect is off
[    8.700013][ T1090] sd 0:0:1:0: [sda] Mode Sense: 1f 00 00 08
[    8.700333][ T1090] sd 0:0:1:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
[    8.703866][    T1]  bus_for_each_dev+0x147/0x1d0
[    8.703866][    T1]  ? subsys_dev_iter_exit+0x20/0x20
[    8.711881][   T11] sd 0:0:1:0: Attached scsi generic sg0 type 0
[    8.711687][    T1]  bus_add_driver+0x4c9/0x640
[    8.711687][    T1]  driver_register+0x220/0x3a0
[    8.715821][    T1]  ? veth_init+0x11/0x11
[    8.715821][    T1]  virtio_net_driver_init+0x93/0xd2
[    8.715821][    T1]  do_one_initcall+0x13d/0x780
[    8.715821][    T1]  ? trace_event_raw_event_initcall_level+0x1f0/0x1f0
[    8.715821][    T1]  ? parameq+0x140/0x170
[    8.715821][    T1]  kernel_init_freeable+0x6ff/0x788
[    8.715821][    T1]  ? rest_init+0x270/0x270
[    8.715821][    T1]  kernel_init+0x1a/0x1d0
[    8.715821][    T1]  ? rest_init+0x270/0x270
[    8.715821][    T1]  ret_from_fork+0x1f/0x30
[    8.715821][    T1]  </TASK>
[    8.715821][    T1] Kernel Offset: disabled
[    8.715821][    T1] Rebooting in 86400 seconds..


syzkaller build log:
go env (err=<nil>)
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOCACHE="/syzkaller/.cache/go-build"
GOENV="/syzkaller/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/syzkaller/jobs/linux/gopath/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/syzkaller/jobs/linux/gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/syzkaller/jobs/linux/gopath/src/github.com/google/syzkaller/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1866141968=/tmp/go-build -gno-record-gcc-switches"

git status (err=<nil>)
HEAD detached at 08977f5d5
nothing to commit, working tree clean


tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:32: run command via tools/syz-env for best compatibility, see:
Makefile:33: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
go list -f '{{.Stale}}' ./sys/syz-sysgen | grep -q false || go install ./sys/syz-sysgen
make .descriptions
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
bin/syz-sysgen
touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=08977f5d5e344fa0ac0b80af0b72fc3f1468d6a5 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20221101-102309'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-fuzzer github.com/google/syzkaller/syz-fuzzer
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=08977f5d5e344fa0ac0b80af0b72fc3f1468d6a5 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20221101-102309'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-execprog github.com/google/syzkaller/tools/syz-execprog
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=08977f5d5e344fa0ac0b80af0b72fc3f1468d6a5 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20221101-102309'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-stress github.com/google/syzkaller/tools/syz-stress
mkdir -p ./bin/linux_amd64
gcc -o ./bin/linux_amd64/syz-executor executor/executor.cc \
	-m64 -O2 -pthread -Wall -Werror -Wparentheses -Wunused-const-variable -Wframe-larger-than=16384 -Wno-stringop-overflow -Wno-array-bounds -Wno-format-overflow -static-pie -fpermissive -w -DGOOS_linux=1 -DGOARCH_amd64=1 \
	-DHOSTGOOS_linux=1 -DGIT_REVISION=\"08977f5d5e344fa0ac0b80af0b72fc3f1468d6a5\"


Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=14d2420a880000


Tested on:

commit:         5b52aebe ovl: call posix_acl_release() after error che..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git/
kernel config:  https://syzkaller.appspot.com/x/.config?x=551658738d0ad6d
dashboard link: https://syzkaller.appspot.com/bug?extid=3f6ef1c4586bb6fd1f61
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] BUG: unable to handle kernel paging request in ovl_set_acl
  2022-11-03 11:40     ` syzbot
@ 2022-11-03 14:23       ` Christian Brauner
  0 siblings, 0 replies; 5+ messages in thread
From: Christian Brauner @ 2022-11-03 14:23 UTC (permalink / raw)
  To: syzbot; +Cc: linux-kernel, linux-unionfs, miklos, syzkaller-bugs

On Thu, Nov 03, 2022 at 04:40:22AM -0700, syzbot wrote:
> Hello,
> 
> syzbot tried to test the proposed patch but the build/boot failed:

Unrelated failure. I've reproduced the issue manually and verified that
the patch I wanted to test fixes it. Patch is in the relevant branch an
in for-next:

https://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git/commit/?h=fs.acl.rework&id=5b52aebef8954cadff29918bb61d7fdc7be07837

This is only relevant for the next mw so nothing in ovl in mainline.
Fwiw, this is the fix:

From 5b52aebef8954cadff29918bb61d7fdc7be07837 Mon Sep 17 00:00:00 2001
From: Christian Brauner <brauner@kernel.org>
Date: Thu, 3 Nov 2022 08:18:46 +0100
Subject: [PATCH] ovl: call posix_acl_release() after error checking

The current placement of posix_acl_release() in ovl_set_or_remove_acl()
means it can be called on an error pointer instead of actual acls.
Fix this by moving the posix_acl_release() call after the error handling.

Fixes: 0e641857322f ("ovl: implement set acl method") # mainline only
Reported-by: syzbot+3f6ef1c4586bb6fd1f61@syzkaller.appspotmail.com
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
---
 fs/overlayfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 77a77fd7a77b..ee6dfa577c93 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -621,11 +621,11 @@ static int ovl_set_or_remove_acl(struct dentry *dentry, struct inode *inode,
 		real_acl = vfs_get_acl(mnt_user_ns(realpath.mnt), realdentry,
 				       acl_name);
 		revert_creds(old_cred);
-		posix_acl_release(real_acl);
 		if (IS_ERR(real_acl)) {
 			err = PTR_ERR(real_acl);
 			goto out_drop_write;
 		}
+		posix_acl_release(real_acl);
 	}
 
 	if (!upperdentry) {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-03 14:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 16:35 [syzbot] BUG: unable to handle kernel paging request in ovl_set_acl syzbot
2022-11-03  2:35 ` syzbot
2022-11-03  7:25   ` Christian Brauner
2022-11-03 11:40     ` syzbot
2022-11-03 14:23       ` Christian Brauner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.