From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E47C4332F for ; Wed, 9 Nov 2022 17:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231796AbiKIREO (ORCPT ); Wed, 9 Nov 2022 12:04:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231623AbiKIRDr (ORCPT ); Wed, 9 Nov 2022 12:03:47 -0500 Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A242A419 for ; Wed, 9 Nov 2022 09:02:57 -0800 (PST) Received: by mail-il1-f198.google.com with SMTP id 15-20020a056e0220cf00b0030099e75602so14098749ilq.21 for ; Wed, 09 Nov 2022 09:02:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:message-id:date:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BYKpzzDL3Cm1dNXSP8aW0qOYbhQreeE+PnHW9Us4/gE=; b=m2l6xVo0UEHMOogZS+gb5WQDKTOtI17Y6Dwev//su+zzsBNncV28K3ISPAcsFMoKs1 KX3E9MVfVuYIoUryqSi6dacf+GDN2H6EjuILxClYTRsMYoQRtc2SyQF0nEp9x1dsDqPs MCYh9s8c8Yb15Suve090ItNFheqa4yaMzdrqM53q8d5aRrRsX36nRNXgdV+9yvYi61x+ PanDU+1qrXqnOC5qn4fffx8Ql+hvatOgcyMJ8q+QDDHick3QzHTwiJKhrVPFc7fphi3Z YKyEMlGyxpbyJcOqu4nTb/ZqiCxgsMps3qBUFxl9XgAV3A3XkwenH+m0u0TzALwhvwgr w0yQ== X-Gm-Message-State: ACrzQf1sWg6+UZActer3cs6hv4R46NP4qf9cIkd/winhI23bJ0BH5REJ 6DzaXwKLy6t1JsOWnh0yTw7bDTS8gmJrdfwo7UWWgVHyzPRs X-Google-Smtp-Source: AMsMyM5EKAZNkZu8zbsIBKx4a7ct9oPCnmagC9D1jZJjhHf7+lMozHYt8gmn9Iaxb36vtPI+VJAqQX1CO24T5BEmK6CG6fj9nHIm MIME-Version: 1.0 X-Received: by 2002:a02:95e7:0:b0:363:ae32:346f with SMTP id b94-20020a0295e7000000b00363ae32346fmr2130426jai.31.1668013376669; Wed, 09 Nov 2022 09:02:56 -0800 (PST) Date: Wed, 09 Nov 2022 09:02:56 -0800 X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <000000000000cc15ee05ed0ca085@google.com> Subject: [syzbot] possible deadlock in filename_create From: syzbot To: linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, syzbot found the following issue on: HEAD commit: f141df371335 Merge tag 'audit-pr-20221107' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11802789880000 kernel config: https://syzkaller.appspot.com/x/.config?x=771b06c41e08f95b dashboard link: https://syzkaller.appspot.com/bug?extid=95cb07e3840546a4827b compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 Unfortunately, I don't have any reproducer for this issue yet. Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/25bd3ddd1720/disk-f141df37.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/e2a12f518443/vmlinux-f141df37.xz kernel image: https://storage.googleapis.com/syzbot-assets/09ba7134ea9d/bzImage-f141df37.xz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+95cb07e3840546a4827b@syzkaller.appspotmail.com ====================================================== WARNING: possible circular locking dependency detected 6.1.0-rc4-syzkaller-00015-gf141df371335 #0 Not tainted ------------------------------------------------------ syz-executor.3/25735 is trying to acquire lock: ffff88807a8a8090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x77/0xd0 fs/reiserfs/lock.c:27 but task is already holding lock: ffff8880361c0980 (&type->i_mutex_dir_key#19/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] ffff8880361c0980 (&type->i_mutex_dir_key#19/1){+.+.}-{3:3}, at: filename_create+0x22a/0x4f0 fs/namei.c:3806 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&type->i_mutex_dir_key#19/1){+.+.}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write_nested+0xa2/0x280 kernel/locking/rwsem.c:1672 inode_lock_nested include/linux/fs.h:791 [inline] filename_create+0x22a/0x4f0 fs/namei.c:3806 do_symlinkat+0xe4/0x600 fs/namei.c:4419 __do_sys_symlinkat fs/namei.c:4446 [inline] __se_sys_symlinkat fs/namei.c:4443 [inline] __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4443 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (sb_writers#28){.+.+}-{0:0}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_write+0x4d/0x1a0 include/linux/fs.h:1901 mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:437 reiserfs_ioctl+0x16e/0x340 fs/reiserfs/ioctl.c:103 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&sbi->lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 reiserfs_write_lock+0x77/0xd0 fs/reiserfs/lock.c:27 reiserfs_lookup+0x147/0x490 fs/reiserfs/namei.c:364 __lookup_hash+0x115/0x240 fs/namei.c:1601 filename_create+0x25f/0x4f0 fs/namei.c:3807 do_symlinkat+0xe4/0x600 fs/namei.c:4419 __do_sys_symlinkat fs/namei.c:4446 [inline] __se_sys_symlinkat fs/namei.c:4443 [inline] __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4443 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &sbi->lock --> sb_writers#28 --> &type->i_mutex_dir_key#19/1 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#19/1); lock(sb_writers#28); lock(&type->i_mutex_dir_key#19/1); lock(&sbi->lock); *** DEADLOCK *** 2 locks held by syz-executor.3/25735: #0: ffff888075a1e460 (sb_writers#28){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff8880361c0980 (&type->i_mutex_dir_key#19/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #1: ffff8880361c0980 (&type->i_mutex_dir_key#19/1){+.+.}-{3:3}, at: filename_create+0x22a/0x4f0 fs/namei.c:3806 stack backtrace: CPU: 0 PID: 25735 Comm: syz-executor.3 Not tainted 6.1.0-rc4-syzkaller-00015-gf141df371335 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 reiserfs_write_lock+0x77/0xd0 fs/reiserfs/lock.c:27 reiserfs_lookup+0x147/0x490 fs/reiserfs/namei.c:364 __lookup_hash+0x115/0x240 fs/namei.c:1601 filename_create+0x25f/0x4f0 fs/namei.c:3807 do_symlinkat+0xe4/0x600 fs/namei.c:4419 __do_sys_symlinkat fs/namei.c:4446 [inline] __se_sys_symlinkat fs/namei.c:4443 [inline] __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4443 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fb4f468b639 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb4f399c168 EFLAGS: 00000246 ORIG_RAX: 000000000000010a RAX: ffffffffffffffda RBX: 00007fb4f47ac2c0 RCX: 00007fb4f468b639 RDX: 0000000020000980 RSI: 0000000000000007 RDI: 00000000200001c0 RBP: 00007fb4f46e67e1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc2217a09f R14: 00007fb4f399c300 R15: 0000000000022000 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot.