From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757933Ab2JSTeR (ORCPT ); Fri, 19 Oct 2012 15:34:17 -0400 Received: from a193-30.smtp-out.amazonses.com ([199.255.193.30]:20419 "EHLO a193-30.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757107Ab2JSTeP (ORCPT ); Fri, 19 Oct 2012 15:34:15 -0400 Date: Fri, 19 Oct 2012 19:34:14 +0000 From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Glauber Costa cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal Subject: Re: [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy In-Reply-To: <1350656442-1523-5-git-send-email-glommer@parallels.com> Message-ID: <0000013a7a84cb28-334eab12-33c4-4a92-bd9c-e5ad938f83d0-000000@email.amazonses.com> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-5-git-send-email-glommer@parallels.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SES-Outgoing: 199.255.193.30 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Oct 2012, Glauber Costa wrote: > I, however, see no reason why we need to do so, since we are now locked > during the whole deletion (which wasn't necessarily true before). I > propose a simplification in which we delete it only when there is no > more going back, so we don't need to add it again. Ok lets hope that holding the lock does not cause issues. Acked-by: Christoph Lameter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx189.postini.com [74.125.245.189]) by kanga.kvack.org (Postfix) with SMTP id 9A7C86B0070 for ; Fri, 19 Oct 2012 15:34:15 -0400 (EDT) Date: Fri, 19 Oct 2012 19:34:14 +0000 From: Christoph Lameter Subject: Re: [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy In-Reply-To: <1350656442-1523-5-git-send-email-glommer@parallels.com> Message-ID: <0000013a7a84cb28-334eab12-33c4-4a92-bd9c-e5ad938f83d0-000000@email.amazonses.com> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-5-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal On Fri, 19 Oct 2012, Glauber Costa wrote: > I, however, see no reason why we need to do so, since we are now locked > during the whole deletion (which wasn't necessarily true before). I > propose a simplification in which we delete it only when there is no > more going back, so we don't need to add it again. Ok lets hope that holding the lock does not cause issues. Acked-by: Christoph Lameter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: Re: [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy Date: Fri, 19 Oct 2012 19:34:14 +0000 Message-ID: <0000013a7a84cb28-334eab12-33c4-4a92-bd9c-e5ad938f83d0-000000@email.amazonses.com> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-5-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Return-path: In-Reply-To: <1350656442-1523-5-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, David Rientjes , Pekka Enberg , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Pekka Enberg , Suleiman Souhlal On Fri, 19 Oct 2012, Glauber Costa wrote: > I, however, see no reason why we need to do so, since we are now locked > during the whole deletion (which wasn't necessarily true before). I > propose a simplification in which we delete it only when there is no > more going back, so we don't need to add it again. Ok lets hope that holding the lock does not cause issues. Acked-by: Christoph Lameter