From: Christoph Lameter <cl@linux.com>
To: Simon Jeons <simon.jeons@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
RT <linux-rt-users@vger.kernel.org>,
Clark Williams <clark@redhat.com>, John Kacur <jkacur@gmail.com>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
Joonsoo Kim <js1304@gmail.com>,
Glauber Costa <glommer@parallels.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
elezegarcia@gmail.com
Subject: Re: FIX [1/2] slub: Do not dereference NULL pointer in node_match
Date: Fri, 25 Jan 2013 14:53:29 +0000 [thread overview]
Message-ID: <0000013c7232fa91-a8f59c62-a7c6-4937-89b9-8c53d86df7b1-000000@email.amazonses.com> (raw)
In-Reply-To: <1359101516.16101.6.camel@kernel>
On Fri, 25 Jan 2013, Simon Jeons wrote:
> >
> > node_match(NULL, xx) = 0
> >
> > ->
> >
> > call into __slab_alloc.
> >
> > __slab_alloc() will check for !c->page which requires the assignment of a
> > new per cpu slab page.
> >
>
> But there are dereference in page_to_nid path, function page_to_section:
> return (page->flags >> SECTIONS_PGSHIFT) & SECTIONS_MASK;
node_match() checks for NULL and will not invoke page_to_nid for a NULL
pointer.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-25 14:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130123214514.370647954@linux.com>
2013-01-23 21:45 ` FIX [1/2] slub: Do not dereference NULL pointer in node_match Christoph Lameter
2013-01-23 21:45 ` Christoph Lameter
2013-01-24 0:53 ` Simon Jeons
2013-01-24 0:53 ` Simon Jeons
2013-01-24 15:14 ` Christoph Lameter
2013-01-25 8:11 ` Simon Jeons
2013-01-25 8:11 ` Simon Jeons
2013-01-25 14:53 ` Christoph Lameter [this message]
2013-02-01 10:23 ` Pekka Enberg
2013-02-01 10:23 ` Pekka Enberg
2013-02-01 11:51 ` Steven Rostedt
2013-02-01 11:51 ` Steven Rostedt
2013-01-23 21:45 ` FIX [2/2] slub: tid must be retrieved from the percpu area of the current processor Christoph Lameter
2013-01-23 21:45 ` Christoph Lameter
2013-02-01 10:24 ` Pekka Enberg
2013-02-01 10:24 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000013c7232fa91-a8f59c62-a7c6-4937-89b9-8c53d86df7b1-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=clark@redhat.com \
--cc=elezegarcia@gmail.com \
--cc=glommer@parallels.com \
--cc=jkacur@gmail.com \
--cc=js1304@gmail.com \
--cc=lgoncalv@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=simon.jeons@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.