All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Tadeusz Struk'" <tadeusz.struk@linaro.org>, <linkinjeon@kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>, <stable@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sj1557.seo@samsung.com>
Subject: RE: [PATCH v2 1/2] exfat: move is_valid_cluster to a common header
Date: Sun, 15 May 2022 23:38:11 +0900	[thread overview]
Message-ID: <000001d86869$66d66110$34832330$@samsung.com> (raw)
In-Reply-To: <20220511185909.175110-1-tadeusz.struk@linaro.org>

> Move the is_valid_cluster() helper from fatent.c to a common header to
> make it reusable in other *.c files.
> 
> Cc: Namjae Jeon <linkinjeon@kernel.org>
> Cc: Sungjong Seo <sj1557.seo@samsung.com>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 
> Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>

Looks good, thanks for your patch!

Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>

> ---
>  fs/exfat/exfat_fs.h | 6 ++++++
>  fs/exfat/fatent.c   | 6 ------
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h index
> c6800b880920..42d06c68d5c5 100644
> --- a/fs/exfat/exfat_fs.h
> +++ b/fs/exfat/exfat_fs.h
> @@ -381,6 +381,12 @@ static inline int exfat_sector_to_cluster(struct
> exfat_sb_info *sbi,
>  		EXFAT_RESERVED_CLUSTERS;
>  }
> 
> +static inline bool is_valid_cluster(struct exfat_sb_info *sbi,
> +		unsigned int clus)
> +{
> +	return clus >= EXFAT_FIRST_CLUSTER && clus < sbi->num_clusters; }
> +
>  /* super.c */
>  int exfat_set_volume_dirty(struct super_block *sb);  int
> exfat_clear_volume_dirty(struct super_block *sb); diff --git
> a/fs/exfat/fatent.c b/fs/exfat/fatent.c index a3464e56a7e1..421c27353104
> 100644
> --- a/fs/exfat/fatent.c
> +++ b/fs/exfat/fatent.c
> @@ -81,12 +81,6 @@ int exfat_ent_set(struct super_block *sb, unsigned int
> loc,
>  	return 0;
>  }
> 
> -static inline bool is_valid_cluster(struct exfat_sb_info *sbi,
> -		unsigned int clus)
> -{
> -	return clus >= EXFAT_FIRST_CLUSTER && clus < sbi->num_clusters;
> -}
> -
>  int exfat_ent_get(struct super_block *sb, unsigned int loc,
>  		unsigned int *content)
>  {
> --
> 2.36.1



      parent reply	other threads:[~2022-05-15 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220511185940epcas1p3c5eb0603b969fe2753b4f16f6f8842a7@epcas1p3.samsung.com>
2022-05-11 18:59 ` Tadeusz Struk
2022-05-11 18:59   ` [PATCH v2 2/2] exfat: check if cluster num is valid Tadeusz Struk
2022-05-15 14:52     ` Sungjong Seo
2022-05-16 14:51       ` Tadeusz Struk
2022-05-16 23:31         ` Namjae Jeon
2022-05-16 23:38           ` Tadeusz Struk
2022-05-15 14:38   ` Sungjong Seo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d86869$66d66110$34832330$@samsung.com' \
    --to=sj1557.seo@samsung.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tadeusz.struk@linaro.org \
    --subject='RE: [PATCH v2 1/2] exfat: move is_valid_cluster to a common header' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.