All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Thomas Abraham' <thomas.ab@samsung.com>,
	linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board
Date: Thu, 16 Jun 2011 18:46:45 +0900	[thread overview]
Message-ID: <000101cc2c0a$51efd8f0$f5cf8ad0$%kim@samsung.com> (raw)
In-Reply-To: <1305836690-890-1-git-send-email-thomas.ab@samsung.com>

Thomas Abraham wrote:
> 
> On SMDKV310 board, a card detect gpio pin is available that is directly
> connected to the io pad of the sdhci controller. Fix incorrect value
> of cd_type field in platform data for sdhci instance 0 and 2.
> 
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
>  arch/arm/mach-exynos4/mach-smdkv310.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-
> exynos4/mach-smdkv310.c
> index 1526764..edd8141 100644
> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
> @@ -78,9 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[]
__initdata
> = {
>  };
> 
>  static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
> -	.cd_type		= S3C_SDHCI_CD_GPIO,
> -	.ext_cd_gpio		= EXYNOS4_GPK0(2),
> -	.ext_cd_gpio_invert	= 1,
> +	.cd_type		= S3C_SDHCI_CD_INTERNAL,
>  	.clk_type		= S3C_SDHCI_CLK_DIV_EXTERNAL,
>  #ifdef CONFIG_EXYNOS4_SDHCI_CH0_8BIT
>  	.max_width		= 8,
> @@ -96,9 +94,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata
> __initdata = {
>  };
> 
>  static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
> -	.cd_type		= S3C_SDHCI_CD_GPIO,
> -	.ext_cd_gpio		= EXYNOS4_GPK2(2),
> -	.ext_cd_gpio_invert	= 1,
> +	.cd_type		= S3C_SDHCI_CD_INTERNAL,
>  	.clk_type		= S3C_SDHCI_CLK_DIV_EXTERNAL,
>  #ifdef CONFIG_EXYNOS4_SDHCI_CH2_8BIT
>  	.max_width		= 8,
> --

Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2011-06-16  9:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 20:24 [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board Thomas Abraham
2011-06-16  9:46 ` Kukjin Kim [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-16 14:06 Thomas Abraham
2011-05-16 16:57 ` Marek Szyprowski
2011-05-19 20:10   ` Thomas Abraham
2011-04-12 14:03 Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101cc2c0a$51efd8f0$f5cf8ad0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.