From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A7BC433DF for ; Fri, 3 Jul 2020 14:37:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C6652070B for ; Fri, 3 Jul 2020 14:37:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C6652070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrMoY-0002uI-OP for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 10:37:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrMns-00027H-Bu; Fri, 03 Jul 2020 10:36:36 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:9443) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrMnk-00020m-VD; Fri, 03 Jul 2020 10:36:32 -0400 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R821e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01f04427; MF=guoheyi@linux.alibaba.com; NM=1; PH=DS; RN=7; SR=0; TI=SMTPD_---0U1av7be_1593786962; Received: from B-G4TALVDL-1650.local(mailfrom:guoheyi@linux.alibaba.com fp:SMTPD_---0U1av7be_1593786962) by smtp.aliyun-inc.com(127.0.0.1); Fri, 03 Jul 2020 22:36:02 +0800 Subject: Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled To: Peter Maydell References: <1593769409-13534-1-git-send-email-guoheyi@linux.alibaba.com> From: Heyi Guo Message-ID: <00016872-f1ca-5989-8ad6-28cf05ea0c57@linux.alibaba.com> Date: Fri, 3 Jul 2020 22:36:02 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=47.88.44.36; envelope-from=guoheyi@linux.alibaba.com; helo=out4436.biz.mail.alibaba.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/03 10:36:16 X-ACL-Warn: Detected OS = Linux 3.1-3.10 X-Spam_score_int: -105 X-Spam_score: -10.6 X-Spam_bar: ---------- X-Spam_report: (-10.6 / 5.0 requ) BAYES_00=-1.9, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_SPF_WL=-7.5 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yitian.ly@alibaba-inc.com, "Michael S. Tsirkin" , QEMU Developers , Shannon Zhao , qemu-arm , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2020/7/3 下午6:37, Peter Maydell 写道: > On Fri, 3 Jul 2020 at 10:44, Heyi Guo wrote: >> vms->psci_conduit being disabled only means PSCI is not implemented by >> qemu; it doesn't mean PSCI is not supported on this virtual machine. >> Actually vms->psci_conduit is set to disabled when vms->secure and >> firmware_loaded are both set, which means we will run ARM trusted >> firmware, which will definitely provide PSCI. >> >> The issue can be reproduced when running qemu in TCG mode with secure >> enabled, while using ARM trusted firmware + qemu virt UEFI as firmware >> binaries, and we can see secondary cores will not be waken up. > If you're using a real EL3 guest firmware then it's the job of > the guest firmware to provide a DTB to the guest EL2/EL1 that says > "and I support PSCI" if it supports PSCI, surely? QEMU can't tell > whether the EL3 code does or doesn't do that... Thanks, Peter. Does that mean the ACPI tables generated in qemu are only templates and firmware should update them if necessary? Heyi > > thanks > -- PMM