From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511Ab1B1Gbg (ORCPT ); Mon, 28 Feb 2011 01:31:36 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:54303 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965Ab1B1Gbf (ORCPT ); Mon, 28 Feb 2011 01:31:35 -0500 Date: Mon, 28 Feb 2011 15:31:30 +0900 From: Kukjin Kim Subject: RE: [PATCH 04/09] ARM: s3c2440: gta02: Select missing S3C_DEV_USB_HOST In-reply-to: <1297043521-21903-4-git-send-email-lars@metafoo.de> To: "'Lars-Peter Clausen'" , "'Ben Dooks'" Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-id: <000501cbd711$2499dbb0$6dcd9310$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=us-ascii Content-language: ko Content-transfer-encoding: 7BIT Thread-index: AcvGaltAVCAcFymtQya6j3Z1v03DJQQpqlqg References: <1297043521-21903-1-git-send-email-lars@metafoo.de> <1297043521-21903-4-git-send-email-lars@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lars-Peter Clausen wrote: > > The gta02 mach file references the ohci device. > So we need to select S3C_DEV_USB_HOST to have the device available. > > This fixes the following linker errors: > arch/arm/mach-s3c2440/built-in.o: In function `gta02_machine_init': > mach-gta02.c:(.init.text+0x370): undefined reference to > `s3c_ohci_set_platdata' > arch/arm/mach-s3c2440/built-in.o:(.init.data+0xac): undefined > reference to `s3c_device_ohci' > > Signed-off-by: Lars-Peter Clausen > --- > arch/arm/mach-s3c2440/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig > index a0cb258..50825a3 100644 > --- a/arch/arm/mach-s3c2440/Kconfig > +++ b/arch/arm/mach-s3c2440/Kconfig > @@ -99,6 +99,7 @@ config MACH_NEO1973_GTA02 > select POWER_SUPPLY > select MACH_NEO1973 > select S3C2410_PWM > + select S3C_DEV_USB_HOST > help > Say Y here if you are using the Openmoko GTA02 / Freerunner GSM > Phone > > -- > 1.7.2.3 Ok, applied. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Mon, 28 Feb 2011 15:31:30 +0900 Subject: [PATCH 04/09] ARM: s3c2440: gta02: Select missing S3C_DEV_USB_HOST In-Reply-To: <1297043521-21903-4-git-send-email-lars@metafoo.de> References: <1297043521-21903-1-git-send-email-lars@metafoo.de> <1297043521-21903-4-git-send-email-lars@metafoo.de> Message-ID: <000501cbd711$2499dbb0$6dcd9310$%kim@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Lars-Peter Clausen wrote: > > The gta02 mach file references the ohci device. > So we need to select S3C_DEV_USB_HOST to have the device available. > > This fixes the following linker errors: > arch/arm/mach-s3c2440/built-in.o: In function `gta02_machine_init': > mach-gta02.c:(.init.text+0x370): undefined reference to > `s3c_ohci_set_platdata' > arch/arm/mach-s3c2440/built-in.o:(.init.data+0xac): undefined > reference to `s3c_device_ohci' > > Signed-off-by: Lars-Peter Clausen > --- > arch/arm/mach-s3c2440/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig > index a0cb258..50825a3 100644 > --- a/arch/arm/mach-s3c2440/Kconfig > +++ b/arch/arm/mach-s3c2440/Kconfig > @@ -99,6 +99,7 @@ config MACH_NEO1973_GTA02 > select POWER_SUPPLY > select MACH_NEO1973 > select S3C2410_PWM > + select S3C_DEV_USB_HOST > help > Say Y here if you are using the Openmoko GTA02 / Freerunner GSM > Phone > > -- > 1.7.2.3 Ok, applied. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.