From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RddZc-00066N-8q for qemu-devel@nongnu.org; Thu, 22 Dec 2011 03:00:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RddZX-0007iM-7J for qemu-devel@nongnu.org; Thu, 22 Dec 2011 03:00:20 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:65336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RddZX-0007hZ-30 for qemu-devel@nongnu.org; Thu, 22 Dec 2011 03:00:15 -0500 Received: from euspt2 (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LWL00F9DI895W@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 22 Dec 2011 08:00:09 +0000 (GMT) Received: from solodkiyw764 ([106.109.9.43]) by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LWL0096WI87Q0@spt2.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 22 Dec 2011 08:00:09 +0000 (GMT) Date: Thu, 22 Dec 2011 12:00:07 +0400 From: Dmitry Solodkiy In-reply-to: <4EF1C7E2.5000106@ispras.ru> Message-id: <000701ccc07f$b92a2bb0$2b7e8310$%solodkiy@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-language: ru Content-transfer-encoding: 7BIT References: <1324295617-5798-1-git-send-email-e.voevodin@samsung.com> <1324295617-5798-12-git-send-email-e.voevodin@samsung.com> <4EF1C7E2.5000106@ispras.ru> Subject: Re: [Qemu-devel] [PATCH v4 11/11] Exynos4210: added display controller implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Dmitry Zhurikhin' Cc: 'Mitsyanko Igor' , 'Evgeny Voevodin' , qemu-devel@nongnu.org, 'Kirill Batuzov' , m.kozlov@samsung.com, jehyung.lee@samsung.com Dear Dmitry, Thank you for feedback. As you probably know, there is some decision making process in large corporations. We'll discuss naming conventions on project meeting, make proposal, send it to peers, get approve and apply. Regards, Dmitry Solodkiy, Mobile SW PL, Advanced Software Group, Moscow R&D center, Samsung Electronics -----Original Message----- From: Dmitry Zhurikhin [mailto:zhur@ispras.ru] Sent: Wednesday, December 21, 2011 3:50 PM To: Evgeny Voevodin Cc: qemu-devel@nongnu.org; m.kozlov@samsung.com; Mitsyanko Igor; d.solodkiy@samsung.com; Kirill Batuzov Subject: Re: [Qemu-devel] [PATCH v4 11/11] Exynos4210: added display controller implementation On 12/19/2011 03:53 PM, Evgeny Voevodin wrote: > From: Mitsyanko Igor > > Exynos4210 display controller (FIMD) has 5 hardware windows with alpha and > chroma key blending functions. > > Signed-off-by: Evgeny Voevodin Hello! Nice work you've done there. Seeing you took our LCD implementation as a starting point I've got a small suggestion (don't consider it a blocker or anything) to make the names of your devices more generic. Glancing through the public documents Dmitry gave a link to I had a feeling that they are pretty much the same as used in S5C-based devices (and from my memory in S3C-based, at least SMDK6410, as well). What I noticed is that some new registers appeared in many devices like this one or ADC and keypad while documentation for most devices remained the same literally (I think only interrupt controller is much different from that used in S5PC110 and am not sure about DMA controller as it uses PL330's as well but seems in different configuration). This probably means and is logical that Samsung uses mostly the same basic devices for its SOCs. Then I think there is no point giving them device-specific names. How much Exynos4210-special details are coded here? Is it hard to separate them to support e.g. S5PC110 FIMD with the same device? Next year Samsung will come out with S6C, Exynos5210, F-something or whatever (you should know better) and it will feature once again the same basic devices with once again slightly updated interfaces. Then your colleagues who will work on implementing support of these boards in QEMU will either invent their own way of emulation for pretty much the same devices or will need to rename already present in QEMU ones to be used inside of their new board emulation. So what do you think about naming them more generic from the start? Dmitry