From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99BA7C4167B for ; Tue, 8 Dec 2020 06:15:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64D5A23A6C for ; Tue, 8 Dec 2020 06:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbgLHGPP (ORCPT ); Tue, 8 Dec 2020 01:15:15 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:58137 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgLHGPO (ORCPT ); Tue, 8 Dec 2020 01:15:14 -0500 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20201208061431epoutp0298359d980b9519c282e97147b2ce0145~OqR-aNK3e2278622786epoutp02C for ; Tue, 8 Dec 2020 06:14:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20201208061431epoutp0298359d980b9519c282e97147b2ce0145~OqR-aNK3e2278622786epoutp02C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1607408071; bh=RCI9kK2tJsruhg/x5Ng5MDmJmukKeeFlhWN0LjRmvvk=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=CmcIsZop933nwm3GTUY3FUZnnBMzZvE6mCXSOh8mKbrrCgfvgIR5Lqmnsk9zrhn75 zrH3X2XXEW/zF7g9FYRcjRJiAC4Ojm1BVH3NeI01icBlSHDRxyjqkPg/pkhKDILLJm LShekHuLd18e8FvOAQ83VSWTsJrB8Y/D/MGikbcw= Received: from epsmges5p3new.samsung.com (unknown [182.195.42.75]) by epcas5p3.samsung.com (KnoxPortal) with ESMTP id 20201208061430epcas5p3896d33a10f201e81948e5a8971a15be4~OqR_8UogK3065330653epcas5p3T; Tue, 8 Dec 2020 06:14:30 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p3new.samsung.com (Symantec Messaging Gateway) with SMTP id 9B.9B.33964.6C91FCF5; Tue, 8 Dec 2020 15:14:30 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPA id 20201208061430epcas5p15cc5daed530a7f19846cca5743b2d738~OqR_P9W1E0329403294epcas5p10; Tue, 8 Dec 2020 06:14:30 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201208061430epsmtrp14b4084431e167c58693e8235d2812185~OqR_PGW1s0778207782epsmtrp11; Tue, 8 Dec 2020 06:14:30 +0000 (GMT) X-AuditID: b6c32a4b-ea1ff700000184ac-f6-5fcf19c69b74 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 4D.D3.08745.5C91FCF5; Tue, 8 Dec 2020 15:14:29 +0900 (KST) Received: from pankajdubey02 (unknown [107.122.12.6]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201208061427epsmtip1738da04f5a89b9598e7c7482f3692454~OqR71-aKz2198521985epsmtip1n; Tue, 8 Dec 2020 06:14:27 +0000 (GMT) From: "Pankaj Dubey" To: "'Krzysztof Kozlowski'" , , , Cc: "'Sylwester Nawrocki'" , "'Marek Szyprowski'" , "'Bartlomiej Zolnierkiewicz'" , "'Arnd Bergmann'" , "'Chanwoo Choi'" , "'Alim Akhtar'" , In-Reply-To: <20201207190517.262051-3-krzk@kernel.org> Subject: RE: [PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision register error Date: Tue, 8 Dec 2020 11:44:26 +0530 Message-ID: <000801d6cd29$635534d0$29ff9e70$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI3Sc44zrAFnNObXiIFTUqq/KcsYAFGGxnGAlj5SuepDsZbAA== Content-Language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKKsWRmVeSWpSXmKPExsWy7bCmhu4xyfPxBs9+a1k8mLeNzeLvpGPs FhtnrGe1uP7lOavF+fMb2C02Pb7GanF51xw2ixnn9zFZrD1yl92i/elLZosFGx8xOnB7/P41 idFj06pONo/NS+o9+rasYvT4vEkugDWKyyYlNSezLLVI3y6BK+P6hNesBev5K3rn97E3MH7l 6WLk4JAQMJHo7zfoYuTiEBLYzShxvvEwG4TziVHi44EmdgjnM6PEo+17gBxOsI7jJx6xQCR2 MUrsXLwcynnFKHGgYwMLSBWbgL7EuR/zWEESIgLzGCU2HfoENotZYBuTxOwpx8FmcQqYSfzq +MgIYgsLxEls7PvPBGKzCKhIzHtwmQ3E5hWwlHh+6SeULShxcuYTsA3MAvIS29/OYYa4SUHi 59NlrCC2iICTxPGrZ9khasQlXh49ArZYQmAth8SnyV2MEA0uEjNfbmKDsIUlXh3fAvWclMTL /jYoO1/ix+JJzBDNLYwSk4/PZYVI2EscuDKHBRR+zAKaEut36UMs45Po/f2ECRKsvBIdbUIQ 1WoS35+fgbpTRuJh81ImCNtDomfTPMYJjIqzkLw2C8lrs5C8MAth2QJGllWMkqkFxbnpqcWm BcZ5qeV6xYm5xaV56XrJ+bmbGMEpS8t7B+OjBx/0DjEycTAeYpTgYFYS4VWTOhsvxJuSWFmV WpQfX1Sak1p8iFGag0VJnFfpx5k4IYH0xJLU7NTUgtQimCwTB6dUA5POLcGsyz/kV17Zfz6o 4b207J3kFcpxT7de+nwiq+3cHCnLYyfMIw1e/rD9mvSTSfxxoHbDMrkqL2VzlZ7cwEz7+eY5 s25Iyn5lX+3wTFJ8w4rZe/qdXws/0VE4xJ/muEnNTFV+m0bMmir7j+KbpO6GbjTWUFhoc/xj t3Lfx0Smv3XG/ZYpL1tNuP/E35QKaL74Mc+WKbJ4amfdt1BZhly+l89C1y0/EfMs+7SNyLrz LIc15BkOnXcomSJWs3raAs4TdmErQi8cM+Zi7f6wRjxoXeCzVvuWJfd8Pb9/0N6n92v23Pf3 F1d++yfQ4drcf9YkPfDBgZNen+aWSWZMcP3722JmhlFRa1Px42fR95VYijMSDbWYi4oTAQOs AC7IAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWy7bCSnO5RyfPxBtP6zC0ezNvGZvF30jF2 i40z1rNaXP/ynNXi/PkN7BabHl9jtbi8aw6bxYzz+5gs1h65y27R/vQls8WCjY8YHbg9fv+a xOixaVUnm8fmJfUefVtWMXp83iQXwBrFZZOSmpNZllqkb5fAlXF9wmvWgvX8Fb3z+9gbGL/y dDFyckgImEgcP/GIpYuRi0NIYAejxOppu9ghEjISk1evYIWwhSVW/nsOFhcSeMEosX+6EIjN JqAvce7HPLAaEYEFjBLbf4aD2MwCu5gkZk/3gxi6kVHiQ+NasCJOATOJXx0fGUFsYYEYiYV9 35lAbBYBFYl5Dy6zgdi8ApYSzy/9hLIFJU7OfAJ0HQfQUD2Jto2MEPPlJba/ncMMcZuCxM+n y6BucJI4fvUsO0SNuMTLo0fYJzAKz0IyaRbCpFlIJs1C0rGAkWUVo2RqQXFuem6xYYFRXmq5 XnFibnFpXrpecn7uJkZwxGlp7WDcs+qD3iFGJg7GQ4wSHMxKIrxqUmfjhXhTEiurUovy44tK c1KLDzFKc7AoifNe6DoZLySQnliSmp2aWpBaBJNl4uCUamCaxRtoN23TRSl+9Zn24dvszjoq xRs9nuBhoVegvuTA7ozqSc/LtQUjNrOuWs19MWTWlOagyD88V1sKMrdknV0XNn1q96QPdzMC QqJkZvPlKzfP4rKbYdl4bbvIjeonNVx/mp3Nsx41s0VL8cccO8S15vCSzrQrh6bfMFs1x2st u2/+sylR3O1SJeWyxfxK/r94J4ezVk/uvafWJ2x+8mfciedSFX+uxtQHTNkiy3G3pcDzhtLu 5rak/T1JT9ezFfIG7U4I4w1k4nnRc2hzd890tz7HEwtmfbjUbmbNtj2TV7guY8mVSxmdUc1R rvZ7s1epMVxXmpx1XyY6l/94ZbzHjnmhFxPEF5v9WbV/thJLcUaioRZzUXEiALkjbaMnAwAA X-CMS-MailID: 20201208061430epcas5p15cc5daed530a7f19846cca5743b2d738 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P X-CMS-RootMailID: 20201207190540epcas5p34b9ceff8ee297536443a5fc65a7c49bc References: <20201207190517.262051-1-krzk@kernel.org> <20201207190517.262051-3-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Tuesday, December 8, 2020 12:35 AM > To: Krzysztof Kozlowski ; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: Sylwester Nawrocki ; Marek Szyprowski > ; Bartlomiej Zolnierkiewicz > ; Arnd Bergmann ; Chanwoo > Choi ; Alim Akhtar ; > Pankaj Dubey ; stable@vger.kernel.org > Subject: [PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision > register error > > If regmap_read() fails, the product_id local variable will contain random value > from the stack. Do not try to parse such value and fail the ASV driver probe. > > Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage > driver") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- > drivers/soc/samsung/exynos-asv.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/samsung/exynos-asv.c > b/drivers/soc/samsung/exynos-asv.c > index f653e3533f0f..5daeadc36382 100644 > --- a/drivers/soc/samsung/exynos-asv.c > +++ b/drivers/soc/samsung/exynos-asv.c > @@ -129,7 +129,13 @@ static int exynos_asv_probe(struct platform_device > *pdev) > return PTR_ERR(asv->chipid_regmap); > } > > - regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, > &product_id); > + ret = regmap_read(asv->chipid_regmap, > EXYNOS_CHIPID_REG_PRO_ID, > + &product_id); > + if (ret < 0) { > + dev_err(&pdev->dev, "Cannot read revision from > ChipID: %d\n", > + ret); > + return -ENODEV; > + } > > switch (product_id & EXYNOS_MASK) { > case 0xE5422000: > -- > 2.25.1 Reviewed-by: Pankaj Dubey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26073C4361B for ; Tue, 8 Dec 2020 06:16:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFCD223A57 for ; Tue, 8 Dec 2020 06:16:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFCD223A57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date:Subject: In-Reply-To:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MDXIT2/23hBbd1qFrKdPNTS37CgOIWiRkbiTpRrVWI4=; b=dONWCrQPSpKz3ETTs9QT2O0VL s+t/X3wYBx83jtSbehEjSYoh39C/EsBwyjXIz8y+3CN7zWszN9pZhFW08N5CQWwS11RiMRWZ6taCE txzuHe81ANAeFntFM0tVqsMCVnTLT/8pIKn39p5UxQSs8xi2edv4Z0gSzAR5zqMWb3A1YqURqXxtG M83mlPZbz9Uqnb64JaP7zAtot5npcIEDoCKgLwi2S9Qcj0MdnPhA+TqzMoX6T0ztaM6CaCGFna4wM M9C0e5Hk+CfrNMXzVdzWloTXIOdGcXsw981fkCGB2E9iEZOKY1gdpgzRrqL3maXGba2RfT0PfJmZ+ 9ZUFIW1Ww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmWGn-0000m0-Ac; Tue, 08 Dec 2020 06:14:41 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmWGj-0000le-Mn for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 06:14:39 +0000 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20201208061431epoutp04f77baf0b5061a8c788d9e19bf4aed367~OqR-aMzvC0811108111epoutp04j for ; Tue, 8 Dec 2020 06:14:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20201208061431epoutp04f77baf0b5061a8c788d9e19bf4aed367~OqR-aMzvC0811108111epoutp04j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1607408071; bh=RCI9kK2tJsruhg/x5Ng5MDmJmukKeeFlhWN0LjRmvvk=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=CmcIsZop933nwm3GTUY3FUZnnBMzZvE6mCXSOh8mKbrrCgfvgIR5Lqmnsk9zrhn75 zrH3X2XXEW/zF7g9FYRcjRJiAC4Ojm1BVH3NeI01icBlSHDRxyjqkPg/pkhKDILLJm LShekHuLd18e8FvOAQ83VSWTsJrB8Y/D/MGikbcw= Received: from epsmges5p3new.samsung.com (unknown [182.195.42.75]) by epcas5p3.samsung.com (KnoxPortal) with ESMTP id 20201208061430epcas5p3896d33a10f201e81948e5a8971a15be4~OqR_8UogK3065330653epcas5p3T; Tue, 8 Dec 2020 06:14:30 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p3new.samsung.com (Symantec Messaging Gateway) with SMTP id 9B.9B.33964.6C91FCF5; Tue, 8 Dec 2020 15:14:30 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPA id 20201208061430epcas5p15cc5daed530a7f19846cca5743b2d738~OqR_P9W1E0329403294epcas5p10; Tue, 8 Dec 2020 06:14:30 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201208061430epsmtrp14b4084431e167c58693e8235d2812185~OqR_PGW1s0778207782epsmtrp11; Tue, 8 Dec 2020 06:14:30 +0000 (GMT) X-AuditID: b6c32a4b-ea1ff700000184ac-f6-5fcf19c69b74 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 4D.D3.08745.5C91FCF5; Tue, 8 Dec 2020 15:14:29 +0900 (KST) Received: from pankajdubey02 (unknown [107.122.12.6]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201208061427epsmtip1738da04f5a89b9598e7c7482f3692454~OqR71-aKz2198521985epsmtip1n; Tue, 8 Dec 2020 06:14:27 +0000 (GMT) From: "Pankaj Dubey" To: "'Krzysztof Kozlowski'" , , , In-Reply-To: <20201207190517.262051-3-krzk@kernel.org> Subject: RE: [PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision register error Date: Tue, 8 Dec 2020 11:44:26 +0530 Message-ID: <000801d6cd29$635534d0$29ff9e70$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI3Sc44zrAFnNObXiIFTUqq/KcsYAFGGxnGAlj5SuepDsZbAA== Content-Language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKKsWRmVeSWpSXmKPExsWy7bCmhu4xyfPxBs9+a1k8mLeNzeLvpGPs FhtnrGe1uP7lOavF+fMb2C02Pb7GanF51xw2ixnn9zFZrD1yl92i/elLZosFGx8xOnB7/P41 idFj06pONo/NS+o9+rasYvT4vEkugDWKyyYlNSezLLVI3y6BK+P6hNesBev5K3rn97E3MH7l 6WLk4JAQMJHo7zfoYuTiEBLYzShxvvEwG4TziVHi44EmdgjnM6PEo+17gBxOsI7jJx6xQCR2 MUrsXLwcynnFKHGgYwMLSBWbgL7EuR/zWEESIgLzGCU2HfoENotZYBuTxOwpx8FmcQqYSfzq +MgIYgsLxEls7PvPBGKzCKhIzHtwmQ3E5hWwlHh+6SeULShxcuYTsA3MAvIS29/OYYa4SUHi 59NlrCC2iICTxPGrZ9khasQlXh49ArZYQmAth8SnyV2MEA0uEjNfbmKDsIUlXh3fAvWclMTL /jYoO1/ix+JJzBDNLYwSk4/PZYVI2EscuDKHBRR+zAKaEut36UMs45Po/f2ECRKsvBIdbUIQ 1WoS35+fgbpTRuJh81ImCNtDomfTPMYJjIqzkLw2C8lrs5C8MAth2QJGllWMkqkFxbnpqcWm BcZ5qeV6xYm5xaV56XrJ+bmbGMEpS8t7B+OjBx/0DjEycTAeYpTgYFYS4VWTOhsvxJuSWFmV WpQfX1Sak1p8iFGag0VJnFfpx5k4IYH0xJLU7NTUgtQimCwTB6dUA5POLcGsyz/kV17Zfz6o 4b207J3kFcpxT7de+nwiq+3cHCnLYyfMIw1e/rD9mvSTSfxxoHbDMrkqL2VzlZ7cwEz7+eY5 s25Iyn5lX+3wTFJ8w4rZe/qdXws/0VE4xJ/muEnNTFV+m0bMmir7j+KbpO6GbjTWUFhoc/xj t3Lfx0Smv3XG/ZYpL1tNuP/E35QKaL74Mc+WKbJ4amfdt1BZhly+l89C1y0/EfMs+7SNyLrz LIc15BkOnXcomSJWs3raAs4TdmErQi8cM+Zi7f6wRjxoXeCzVvuWJfd8Pb9/0N6n92v23Pf3 F1d++yfQ4drcf9YkPfDBgZNen+aWSWZMcP3722JmhlFRa1Px42fR95VYijMSDbWYi4oTAQOs AC7IAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWy7bCSnO5RyfPxBtP6zC0ezNvGZvF30jF2 i40z1rNaXP/ynNXi/PkN7BabHl9jtbi8aw6bxYzz+5gs1h65y27R/vQls8WCjY8YHbg9fv+a xOixaVUnm8fmJfUefVtWMXp83iQXwBrFZZOSmpNZllqkb5fAlXF9wmvWgvX8Fb3z+9gbGL/y dDFyckgImEgcP/GIpYuRi0NIYAejxOppu9ghEjISk1evYIWwhSVW/nsOFhcSeMEosX+6EIjN JqAvce7HPLAaEYEFjBLbf4aD2MwCu5gkZk/3gxi6kVHiQ+NasCJOATOJXx0fGUFsYYEYiYV9 35lAbBYBFYl5Dy6zgdi8ApYSzy/9hLIFJU7OfAJ0HQfQUD2Jto2MEPPlJba/ncMMcZuCxM+n y6BucJI4fvUsO0SNuMTLo0fYJzAKz0IyaRbCpFlIJs1C0rGAkWUVo2RqQXFuem6xYYFRXmq5 XnFibnFpXrpecn7uJkZwxGlp7WDcs+qD3iFGJg7GQ4wSHMxKIrxqUmfjhXhTEiurUovy44tK c1KLDzFKc7AoifNe6DoZLySQnliSmp2aWpBaBJNl4uCUamCaxRtoN23TRSl+9Zn24dvszjoq xRs9nuBhoVegvuTA7ozqSc/LtQUjNrOuWs19MWTWlOagyD88V1sKMrdknV0XNn1q96QPdzMC QqJkZvPlKzfP4rKbYdl4bbvIjeonNVx/mp3Nsx41s0VL8cccO8S15vCSzrQrh6bfMFs1x2st u2/+sylR3O1SJeWyxfxK/r94J4ezVk/uvafWJ2x+8mfciedSFX+uxtQHTNkiy3G3pcDzhtLu 5rak/T1JT9ezFfIG7U4I4w1k4nnRc2hzd890tz7HEwtmfbjUbmbNtj2TV7guY8mVSxmdUc1R rvZ7s1epMVxXmpx1XyY6l/94ZbzHjnmhFxPEF5v9WbV/thJLcUaioRZzUXEiALkjbaMnAwAA X-CMS-MailID: 20201208061430epcas5p15cc5daed530a7f19846cca5743b2d738 X-Msg-Generator: CA CMS-TYPE: 105P X-CMS-RootMailID: 20201207190540epcas5p34b9ceff8ee297536443a5fc65a7c49bc References: <20201207190517.262051-1-krzk@kernel.org> <20201207190517.262051-3-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_011438_285364_C30BD290 X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Arnd Bergmann' , 'Bartlomiej Zolnierkiewicz' , 'Sylwester Nawrocki' , stable@vger.kernel.org, 'Chanwoo Choi' , 'Alim Akhtar' , 'Marek Szyprowski' Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Tuesday, December 8, 2020 12:35 AM > To: Krzysztof Kozlowski ; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: Sylwester Nawrocki ; Marek Szyprowski > ; Bartlomiej Zolnierkiewicz > ; Arnd Bergmann ; Chanwoo > Choi ; Alim Akhtar ; > Pankaj Dubey ; stable@vger.kernel.org > Subject: [PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision > register error > > If regmap_read() fails, the product_id local variable will contain random value > from the stack. Do not try to parse such value and fail the ASV driver probe. > > Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage > driver") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- > drivers/soc/samsung/exynos-asv.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/samsung/exynos-asv.c > b/drivers/soc/samsung/exynos-asv.c > index f653e3533f0f..5daeadc36382 100644 > --- a/drivers/soc/samsung/exynos-asv.c > +++ b/drivers/soc/samsung/exynos-asv.c > @@ -129,7 +129,13 @@ static int exynos_asv_probe(struct platform_device > *pdev) > return PTR_ERR(asv->chipid_regmap); > } > > - regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, > &product_id); > + ret = regmap_read(asv->chipid_regmap, > EXYNOS_CHIPID_REG_PRO_ID, > + &product_id); > + if (ret < 0) { > + dev_err(&pdev->dev, "Cannot read revision from > ChipID: %d\n", > + ret); > + return -ENODEV; > + } > > switch (product_id & EXYNOS_MASK) { > case 0xE5422000: > -- > 2.25.1 Reviewed-by: Pankaj Dubey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel