All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] find_isa_irq_pin can't be __init
Date: Mon, 11 Oct 2004 00:39:55 -0600	[thread overview]
Message-ID: <000a01c4af5d$1ee3c740$6601a8c0@northbrook> (raw)
In-Reply-To: fa.fq3ot7q.1fgua9u@ifi.uio.no

Confirmed, taking the __init off find_isa_irq_pin prevents the oops on 
reboot for me.


----- Original Message ----- 
From: "Dave Jones" <davej@redhat.com>
Newsgroups: fa.linux.kernel
To: <torvalds@osdl.org>; <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Sent: Sunday, October 10, 2004 4:58 PM
Subject: [PATCH] find_isa_irq_pin can't be __init


> As spotted by one of our Fedora users, we sometimes
> oops during shutdown (http://www.roberthancock.com/kerneloops.png)
> because disable_IO_APIC() wants to call find_isa_irq_pin(),
> which we threw away during init.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.8/arch/i386/kernel/io_apic.c~ 2004-10-10 
> 18:54:27.490567168 -0400
> +++ linux-2.6.8/arch/i386/kernel/io_apic.c 2004-10-10 
> 18:54:44.660956872 -0400
> @@ -745,7 +745,7 @@ static int __init find_irq_entry(int api
> /*
>  * Find the pin to which IRQ[irq] (ISA) is connected
>  */
> -static int __init find_isa_irq_pin(int irq, int type)
> +static int find_isa_irq_pin(int irq, int type)
> {
>  int i;
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/ 


       reply	other threads:[~2004-10-11  6:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.fq3ot7q.1fgua9u@ifi.uio.no>
2004-10-11  6:39 ` Robert Hancock [this message]
2004-10-10 22:57 [PATCH] find_isa_irq_pin can't be __init Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000a01c4af5d$1ee3c740$6601a8c0@northbrook' \
    --to=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.