From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH 5/6] ARM: S5PC110: add support for otg usb gadget on Goni board Date: Fri, 10 Sep 2010 19:44:55 +0900 Message-ID: <000b01cb50d5$37981140$a6c833c0$%kim@samsung.com> References: <1284103403-10696-1-git-send-email-m.szyprowski@samsung.com> <1284103403-10696-6-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:60697 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798Ab0IJKon (ORCPT ); Fri, 10 Sep 2010 06:44:43 -0400 Received: from epmmp2 (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Sun Java(tm) System Messaging Server 7u3-15.01 64bit (built Feb 12 2010)) with ESMTP id <0L8J00AMU1UIAK00@mailout1.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 10 Sep 2010 19:44:42 +0900 (KST) Received: from kgenekim ([12.23.103.96]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0L8J00IP71UIUS@mmp2.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 10 Sep 2010 19:44:42 +0900 (KST) In-reply-to: <1284103403-10696-6-git-send-email-m.szyprowski@samsung.com> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Marek Szyprowski' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kyungmin.park@samsung.com, ben-linux@fluff.org Marek Szyprowski wrote: > > Add required platform definitions for s3c-hsotg driver to enable usb > gadget support on Samsung Goni board. > > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-s5pv210/Kconfig | 1 + > arch/arm/mach-s5pv210/mach-goni.c | 5 +++++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index b1f671d..f8bac5a 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -85,6 +85,7 @@ config MACH_GONI > select S3C_DEV_HSMMC2 > select S3C_DEV_I2C1 > select S5P_DEV_ONENAND > + select S3C_DEV_USB_HSOTG > select SAMSUNG_DEV_KEYPAD > select S5PV210_SETUP_FB_24BPP > select S5PV210_SETUP_I2C1 > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index 30da422..b28a42b 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -41,6 +41,8 @@ > #include > #include > #include > +#include > +#include Hmm...same 'extern struct clk_xusbxti' defined both. I will sort out :-) I think, just one inclusion is enough now. If any problems, please let me know. > > /* Following are default values for UCON, ULCON and UFCON UART registers */ > #define GONI_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | \ > @@ -569,6 +571,7 @@ static struct platform_device *goni_devices[] __initdata = { > &s3c_device_fb, > &s5p_device_onenand, > &goni_spi_gpio, > + &s3c_device_usb_hsotg, > &goni_i2c_gpio_pmic, > &goni_device_gpiokeys, > &s5p_device_fimc0, > @@ -613,6 +616,8 @@ static void __init goni_machine_init(void) > samsung_keypad_set_platdata(&keypad_data); > > platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); > + > + clk_xusbxti.rate = 24000000; > } > > MACHINE_START(GONI, "GONI") > -- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Fri, 10 Sep 2010 19:44:55 +0900 Subject: [PATCH 5/6] ARM: S5PC110: add support for otg usb gadget on Goni board In-Reply-To: <1284103403-10696-6-git-send-email-m.szyprowski@samsung.com> References: <1284103403-10696-1-git-send-email-m.szyprowski@samsung.com> <1284103403-10696-6-git-send-email-m.szyprowski@samsung.com> Message-ID: <000b01cb50d5$37981140$a6c833c0$%kim@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Marek Szyprowski wrote: > > Add required platform definitions for s3c-hsotg driver to enable usb > gadget support on Samsung Goni board. > > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-s5pv210/Kconfig | 1 + > arch/arm/mach-s5pv210/mach-goni.c | 5 +++++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index b1f671d..f8bac5a 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -85,6 +85,7 @@ config MACH_GONI > select S3C_DEV_HSMMC2 > select S3C_DEV_I2C1 > select S5P_DEV_ONENAND > + select S3C_DEV_USB_HSOTG > select SAMSUNG_DEV_KEYPAD > select S5PV210_SETUP_FB_24BPP > select S5PV210_SETUP_I2C1 > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index 30da422..b28a42b 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -41,6 +41,8 @@ > #include > #include > #include > +#include > +#include Hmm...same 'extern struct clk_xusbxti' defined both. I will sort out :-) I think, just one inclusion is enough now. If any problems, please let me know. > > /* Following are default values for UCON, ULCON and UFCON UART registers */ > #define GONI_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | \ > @@ -569,6 +571,7 @@ static struct platform_device *goni_devices[] __initdata = { > &s3c_device_fb, > &s5p_device_onenand, > &goni_spi_gpio, > + &s3c_device_usb_hsotg, > &goni_i2c_gpio_pmic, > &goni_device_gpiokeys, > &s5p_device_fimc0, > @@ -613,6 +616,8 @@ static void __init goni_machine_init(void) > samsung_keypad_set_platdata(&keypad_data); > > platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); > + > + clk_xusbxti.rate = 24000000; > } > > MACHINE_START(GONI, "GONI") > -- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.