From: "Daryl Van Vorst" <daryl@wideray.com>
To: "'Max Krasnyansky'" <maxk@qualcomm.com>,
"'Marcel Holtmann'" <marcel@rvs.uni-bielefeld.de>
Cc: "'BlueZ Mailing List'" <bluez-devel@lists.sourceforge.net>
Subject: RE: [Bluez-devel] Re: Qualification testing - rfcomm
Date: Tue, 22 Jul 2003 09:48:16 -0700 [thread overview]
Message-ID: <000c01c35071$0c788f60$1a01010a@baked> (raw)
In-Reply-To: <1058838934.3470.5.camel@localhost.localdomain>
> On Fri, 2003-07-11 at 01:18, Marcel Holtmann wrote:
> > Hi Daryl,
> >
> > > TP/RFC/BV-12-C:
> > > "Verify that the IUT handles aggregate flow control
> correctly when
> > > the Tester, acting as a device conforming to Bleutooth
> version 1.0B,
> > > controls the data flow using the Flow Control on/off
> commands FCon
> > > and FCoff. The IUT's device role is of no importance."
> > >
> > > The command and console output:
> > >
> > > root@jack-00000000:~>./rctest -s -P 1 -b 20 00:A0:96:1F:83:71
> > > rctest[362]: Connected
> > > rctest[362]: Sending ...
> > > rfcomm_recv_mcc: Unknown control type 0x18
> > > rfcomm_recv_mcc: Unknown control type 0x28
> > >
> > > The IUT does not respond to FCoff with FCoff, and
> continues sending
> > > data. It also does not respond to FCon with FCon.
> >
> > we don't have support for flow control on the entire RFCOMM
> session.
> > But it seems that the FCOFF and FCON should be supported.
> The attached
> > patch implements support for it, but I am not quite sure if
> it is the
> > right way to do this.
> Is it mandatory ? I always thought it's optional.
I asked the same question. Yes, apparently it is mandatory.
>
> > @@ -1533,6 +1591,9 @@
> > struct list_head *p, *n;
> >
> > BT_DBG("session %p state %ld", s, s->state);
> > +
> > + if (test_bit(RFCOMM_TX_THROTTLED, &s->flags))
> > + return;
> >
> > list_for_each_safe(p, n, &s->dlcs) {
> > d = list_entry(p, struct rfcomm_dlc, list);
> This part is not ok. We still have to check for timeout. Rest
> of patch is fine.
>
> Max
Ok. I'll see if it's not too late to stop testing it. :)
-Daryl.
next prev parent reply other threads:[~2003-07-22 16:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-08 18:16 Qualification testing - rfcomm Daryl Van Vorst
2003-07-08 21:47 ` [Bluez-devel] " James Courtier-Dutton
2003-07-08 23:23 ` Daryl Van Vorst
2003-07-18 19:35 ` James Courtier-Dutton
2003-07-11 8:18 ` [Bluez-devel] " Marcel Holtmann
2003-07-22 16:23 ` Max Krasnyansky
2003-07-22 16:46 ` Marcel Holtmann
2003-07-22 17:40 ` Max Krasnyansky
2003-07-22 19:13 ` Marcel Holtmann
2003-07-22 16:48 ` Daryl Van Vorst [this message]
2003-07-22 16:53 ` Marcel Holtmann
2003-07-22 17:01 ` Daryl Van Vorst
2003-07-11 8:55 ` Marcel Holtmann
2003-07-11 16:43 ` Daryl Van Vorst
2003-07-11 19:05 ` [Bluez-devel] " Daryl Van Vorst
2003-07-18 18:53 ` Daryl Van Vorst
2003-07-18 18:58 ` Marcel Holtmann
2003-07-18 19:07 ` Daryl Van Vorst
2003-07-18 19:12 ` Marcel Holtmann
2003-07-18 19:19 ` Daryl Van Vorst
2003-07-22 17:09 ` Max Krasnyansky
2003-07-22 18:13 ` David Woodhouse
2003-07-22 19:43 ` Max Krasnyansky
2003-07-22 16:26 ` Max Krasnyansky
2003-07-18 19:30 ` [Bluez-devel] " James Courtier-Dutton
2003-07-18 20:25 ` Daryl Van Vorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01c35071$0c788f60$1a01010a@baked' \
--to=daryl@wideray.com \
--cc=bluez-devel@lists.sourceforge.net \
--cc=marcel@rvs.uni-bielefeld.de \
--cc=maxk@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.