From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756256Ab1FJMWO (ORCPT ); Fri, 10 Jun 2011 08:22:14 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:19400 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755770Ab1FJMWK (ORCPT ); Fri, 10 Jun 2011 08:22:10 -0400 Date: Fri, 10 Jun 2011 14:22:05 +0200 From: Marek Szyprowski Subject: RE: [PATCH 02/10] lib: genalloc: Generic allocator improvements In-reply-to: <20110610122451.15af86d1@lxorguk.ukuu.org.uk> To: "'Alan Cox'" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, "'Michal Nazarewicz'" , "'Kyungmin Park'" , "'Andrew Morton'" , "'KAMEZAWA Hiroyuki'" , "'Ankita Garg'" , "'Daniel Walker'" , "'Johan MOSSBERG'" , "'Mel Gorman'" , "'Arnd Bergmann'" , "'Jesse Barker'" Message-id: <000c01cc2769$02669b70$0733d250$%szyprowski@samsung.com> Organization: SPRC MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=us-ascii Content-language: pl Content-transfer-encoding: 7BIT Thread-index: AcwnYP17pPSneA7YQdyCWHjWn5mKQgABykRQ References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <1307699698-29369-3-git-send-email-m.szyprowski@samsung.com> <20110610122451.15af86d1@lxorguk.ukuu.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Friday, June 10, 2011 1:25 PM Alan Cox wrote: > I am curious about one thing > > Why do we need this allocator. Why not use allocate_resource and friends. > The kernel generic resource handler already handles object alignment and > subranges. It just seems to be a surplus allocator that could perhaps be > mostly removed by using the kernel resource allocator we already have ? genalloc was used mainly for historical reasons (in the earlier version we were looking for direct replacement for first fit allocator). I plan to replace it with lib/bitmap.c bitmap_* based allocator (similar like it it is used by dma_declare_coherent_memory() and friends in drivers/base/dma-coherent.c). We need something really simple for CMA area management. IMHO allocate_resource and friends a bit too heavy here, but good to know that such allocator also exists. Best regards -- Marek Szyprowski Samsung Poland R&D Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 162AC6B004A for ; Fri, 10 Jun 2011 08:22:12 -0400 (EDT) Received: from eu_spt1 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LMK008R4QCXZC@mailout1.w1.samsung.com> for linux-mm@kvack.org; Fri, 10 Jun 2011 13:22:09 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LMK007GOQCWZU@spt1.w1.samsung.com> for linux-mm@kvack.org; Fri, 10 Jun 2011 13:22:08 +0100 (BST) Date: Fri, 10 Jun 2011 14:22:05 +0200 From: Marek Szyprowski Subject: RE: [PATCH 02/10] lib: genalloc: Generic allocator improvements In-reply-to: <20110610122451.15af86d1@lxorguk.ukuu.org.uk> Message-id: <000c01cc2769$02669b70$0733d250$%szyprowski@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-language: pl Content-transfer-encoding: 7BIT References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <1307699698-29369-3-git-send-email-m.szyprowski@samsung.com> <20110610122451.15af86d1@lxorguk.ukuu.org.uk> Sender: owner-linux-mm@kvack.org List-ID: To: 'Alan Cox' Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, 'Michal Nazarewicz' , 'Kyungmin Park' , 'Andrew Morton' , 'KAMEZAWA Hiroyuki' , 'Ankita Garg' , 'Daniel Walker' , 'Johan MOSSBERG' , 'Mel Gorman' , 'Arnd Bergmann' , 'Jesse Barker' Hello, On Friday, June 10, 2011 1:25 PM Alan Cox wrote: > I am curious about one thing > > Why do we need this allocator. Why not use allocate_resource and friends. > The kernel generic resource handler already handles object alignment and > subranges. It just seems to be a surplus allocator that could perhaps be > mostly removed by using the kernel resource allocator we already have ? genalloc was used mainly for historical reasons (in the earlier version we were looking for direct replacement for first fit allocator). I plan to replace it with lib/bitmap.c bitmap_* based allocator (similar like it it is used by dma_declare_coherent_memory() and friends in drivers/base/dma-coherent.c). We need something really simple for CMA area management. IMHO allocate_resource and friends a bit too heavy here, but good to know that such allocator also exists. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Fri, 10 Jun 2011 14:22:05 +0200 Subject: [PATCH 02/10] lib: genalloc: Generic allocator improvements In-Reply-To: <20110610122451.15af86d1@lxorguk.ukuu.org.uk> References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <1307699698-29369-3-git-send-email-m.szyprowski@samsung.com> <20110610122451.15af86d1@lxorguk.ukuu.org.uk> Message-ID: <000c01cc2769$02669b70$0733d250$%szyprowski@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Friday, June 10, 2011 1:25 PM Alan Cox wrote: > I am curious about one thing > > Why do we need this allocator. Why not use allocate_resource and friends. > The kernel generic resource handler already handles object alignment and > subranges. It just seems to be a surplus allocator that could perhaps be > mostly removed by using the kernel resource allocator we already have ? genalloc was used mainly for historical reasons (in the earlier version we were looking for direct replacement for first fit allocator). I plan to replace it with lib/bitmap.c bitmap_* based allocator (similar like it it is used by dma_declare_coherent_memory() and friends in drivers/base/dma-coherent.c). We need something really simple for CMA area management. IMHO allocate_resource and friends a bit too heavy here, but good to know that such allocator also exists. Best regards -- Marek Szyprowski Samsung Poland R&D Center