From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Rob Herring'" <robh@kernel.org> Cc: <devicetree@vger.kernel.org>, <linux-scsi@vger.kernel.org>, <krzk@kernel.org>, <avri.altman@wdc.com>, <martin.petersen@oracle.com>, <kwmad.kim@samsung.com>, <stanley.chu@mediatek.com>, <cang@codeaurora.org>, <linux-samsung-soc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v9 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Date: Wed, 27 May 2020 21:53:09 +0530 [thread overview] Message-ID: <001301d63443$1f9f6000$5ede2000$@samsung.com> (raw) In-Reply-To: <20200526180843.GA81537@bogus> Hi Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 26 May 2020 23:39 > To: Alim Akhtar <alim.akhtar@samsung.com> > Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org; > avri.altman@wdc.com; martin.petersen@oracle.com; > kwmad.kim@samsung.com; stanley.chu@mediatek.com; > cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 08/10] dt-bindings: ufs: Add DT binding documentation > for ufs > > On Thu, May 14, 2020 at 06:09:12AM +0530, Alim Akhtar wrote: > > This patch adds DT binding for samsung ufs hci > > Subject should indicate this is for Samsung in some way. > Sure will update the Subject as suggested by you. > > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > --- > > .../bindings/ufs/samsung,exynos-ufs.yaml | 91 +++++++++++++++++++ > > 1 file changed, 91 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > new file mode 100644 > > index 000000000000..eaa64cc32d52 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > @@ -0,0 +1,91 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/url?k=9995443c-c4461d82-9994cf73-0cc47a3 > > +1ba82- > 2c9d6322e4bc35a5&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2F > > +ufs%2Fsamsung%2Cexynos-ufs.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/url?k=70bd56cd-2d6e0f73-70bcdd82-0cc47a3 > > +1ba82-7865215595a4146c&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta- > schem > > +as%2Fcore.yaml%23 > > + > > +title: Samsung SoC series UFS host controller Device Tree Bindings > > + > > +maintainers: > > + - Alim Akhtar <alim.akhtar@samsung.com> > > + > > +description: | > > + Each Samsung UFS host controller instance should have its own node. > > + This binding define Samsung specific binding other then what is > > +used > > + in the common ufshcd bindings > > + [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > > + > > +properties: > > + > > + compatible: > > + enum: > > + - samsung,exynos7-ufs > > + > > + reg: > > + items: > > + - description: HCI register > > + - description: vendor specific register > > + - description: unipro register > > + - description: UFS protector register > > + > > + reg-names: > > + items: > > + - const: hci > > + - const: vs_hci > > + - const: unipro > > + - const: ufsp > > + > > + clocks: > > + maxItems: 2 > > maxItems is redundant. > Will drop it. > > + items: > > + - description: ufs link core clock > > + - description: unipro main clock > > + > > + clock-names: > > + maxItems: 2 > > Here too. Will drop it. > > > + items: > > + - const: core_clk > > + - const: sclk_unipro_main > > + > > + interrupts: > > + maxItems: 1 > > + > > + phys: > > + maxItems: 1 > > + > > + phy-names: > > + maxItems: 1 > > What's the name? (Though a name is kind of pointless when there is only > 1.) Not sure are you suggesting to drop the phy-names completely? Or just keep "phy-names:" only. I looked into how other bindings has handle it, I will change this as phy-names: const: ufs-phy Hope you are ok with this. > > With those fixed, > > Reviewed-by: Rob Herring <robh@kernel.org> > With adding "phy-names" entry, I will adds your Reviewed-by tag, will post the updated changes soon. Thank you!! > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - phys > > + - phy-names > > + - clocks > > + - clock-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/clock/exynos7-clk.h> > > + > > + ufs: ufs@15570000 { > > + compatible = "samsung,exynos7-ufs"; > > + reg = <0x15570000 0x100>, > > + <0x15570100 0x100>, > > + <0x15571000 0x200>, > > + <0x15572000 0x300>; > > + reg-names = "hci", "vs_hci", "unipro", "ufsp"; > > + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clock_fsys1 ACLK_UFS20_LINK>, > > + <&clock_fsys1 SCLK_UFSUNIPRO20_USER>; > > + clock-names = "core_clk", "sclk_unipro_main"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; > > + phys = <&ufs_phy>; > > + phy-names = "ufs-phy"; > > + }; > > +... > > -- > > 2.17.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Rob Herring'" <robh@kernel.org> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, krzk@kernel.org, kwmad.kim@samsung.com, avri.altman@wdc.com, cang@codeaurora.org, stanley.chu@mediatek.com, linux-arm-kernel@lists.infradead.org Subject: RE: [PATCH v9 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Date: Wed, 27 May 2020 21:53:09 +0530 [thread overview] Message-ID: <001301d63443$1f9f6000$5ede2000$@samsung.com> (raw) In-Reply-To: <20200526180843.GA81537@bogus> Hi Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 26 May 2020 23:39 > To: Alim Akhtar <alim.akhtar@samsung.com> > Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org; > avri.altman@wdc.com; martin.petersen@oracle.com; > kwmad.kim@samsung.com; stanley.chu@mediatek.com; > cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 08/10] dt-bindings: ufs: Add DT binding documentation > for ufs > > On Thu, May 14, 2020 at 06:09:12AM +0530, Alim Akhtar wrote: > > This patch adds DT binding for samsung ufs hci > > Subject should indicate this is for Samsung in some way. > Sure will update the Subject as suggested by you. > > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > --- > > .../bindings/ufs/samsung,exynos-ufs.yaml | 91 +++++++++++++++++++ > > 1 file changed, 91 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > new file mode 100644 > > index 000000000000..eaa64cc32d52 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > @@ -0,0 +1,91 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/url?k=9995443c-c4461d82-9994cf73-0cc47a3 > > +1ba82- > 2c9d6322e4bc35a5&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2F > > +ufs%2Fsamsung%2Cexynos-ufs.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/url?k=70bd56cd-2d6e0f73-70bcdd82-0cc47a3 > > +1ba82-7865215595a4146c&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta- > schem > > +as%2Fcore.yaml%23 > > + > > +title: Samsung SoC series UFS host controller Device Tree Bindings > > + > > +maintainers: > > + - Alim Akhtar <alim.akhtar@samsung.com> > > + > > +description: | > > + Each Samsung UFS host controller instance should have its own node. > > + This binding define Samsung specific binding other then what is > > +used > > + in the common ufshcd bindings > > + [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > > + > > +properties: > > + > > + compatible: > > + enum: > > + - samsung,exynos7-ufs > > + > > + reg: > > + items: > > + - description: HCI register > > + - description: vendor specific register > > + - description: unipro register > > + - description: UFS protector register > > + > > + reg-names: > > + items: > > + - const: hci > > + - const: vs_hci > > + - const: unipro > > + - const: ufsp > > + > > + clocks: > > + maxItems: 2 > > maxItems is redundant. > Will drop it. > > + items: > > + - description: ufs link core clock > > + - description: unipro main clock > > + > > + clock-names: > > + maxItems: 2 > > Here too. Will drop it. > > > + items: > > + - const: core_clk > > + - const: sclk_unipro_main > > + > > + interrupts: > > + maxItems: 1 > > + > > + phys: > > + maxItems: 1 > > + > > + phy-names: > > + maxItems: 1 > > What's the name? (Though a name is kind of pointless when there is only > 1.) Not sure are you suggesting to drop the phy-names completely? Or just keep "phy-names:" only. I looked into how other bindings has handle it, I will change this as phy-names: const: ufs-phy Hope you are ok with this. > > With those fixed, > > Reviewed-by: Rob Herring <robh@kernel.org> > With adding "phy-names" entry, I will adds your Reviewed-by tag, will post the updated changes soon. Thank you!! > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - phys > > + - phy-names > > + - clocks > > + - clock-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/clock/exynos7-clk.h> > > + > > + ufs: ufs@15570000 { > > + compatible = "samsung,exynos7-ufs"; > > + reg = <0x15570000 0x100>, > > + <0x15570100 0x100>, > > + <0x15571000 0x200>, > > + <0x15572000 0x300>; > > + reg-names = "hci", "vs_hci", "unipro", "ufsp"; > > + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clock_fsys1 ACLK_UFS20_LINK>, > > + <&clock_fsys1 SCLK_UFSUNIPRO20_USER>; > > + clock-names = "core_clk", "sclk_unipro_main"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; > > + phys = <&ufs_phy>; > > + phy-names = "ufs-phy"; > > + }; > > +... > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-27 16:23 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20200514005251epcas5p39ff05e1b6f4f8735f1516fbb670d6810@epcas5p3.samsung.com> 2020-05-14 0:39 ` [PATCH v9 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005254epcas5p27e2ef61a6d7f595ff2eaf4ec65940cf6@epcas5p2.samsung.com> 2020-05-14 0:39 ` [PATCH v9 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005256epcas5p3ccb5dcc7c96a5cdb9ee78baa8ec1e0d3@epcas5p3.samsung.com> 2020-05-14 0:39 ` [PATCH v9 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005258epcas5p14733cec8b9ca92e518a8d5a0c27f3f0b@epcas5p1.samsung.com> 2020-05-14 0:39 ` [PATCH v9 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005300epcas5p4ce7ba7fe62567e7ba0066c96473853b2@epcas5p4.samsung.com> 2020-05-14 0:39 ` [PATCH v9 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005302epcas5p1d2e99ba001cacc4d9e0d8dcf7de3155b@epcas5p1.samsung.com> 2020-05-14 0:39 ` [PATCH v9 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005304epcas5p37a311f813416383b6de8af6e809b350d@epcas5p3.samsung.com> 2020-05-14 0:39 ` [PATCH v9 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005307epcas5p28b00e2fb5e9526c447927b52127480f4@epcas5p2.samsung.com> 2020-05-14 0:39 ` [PATCH v9 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005309epcas5p3ccd2b44c1bf20634eea3e232d1c2b62e@epcas5p3.samsung.com> 2020-05-14 0:39 ` [PATCH v9 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar 2020-05-26 18:08 ` Rob Herring 2020-05-26 18:08 ` Rob Herring 2020-05-27 16:23 ` Alim Akhtar [this message] 2020-05-27 16:23 ` Alim Akhtar [not found] ` <CGME20200514005311epcas5p21eb58ec4a937e9c13589f81c33d77fe3@epcas5p2.samsung.com> 2020-05-14 0:39 ` [PATCH v9 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar [not found] ` <CGME20200514005313epcas5p3eac58d00d9f617b860a3ac607c8413ec@epcas5p3.samsung.com> 2020-05-14 0:39 ` [PATCH v9 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar 2020-05-14 0:39 ` Alim Akhtar 2020-05-19 7:16 ` Krzysztof Kozlowski 2020-05-19 7:16 ` Krzysztof Kozlowski 2020-05-21 16:49 ` Alim Akhtar 2020-05-21 16:49 ` Alim Akhtar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='001301d63443$1f9f6000$5ede2000$@samsung.com' \ --to=alim.akhtar@samsung.com \ --cc=avri.altman@wdc.com \ --cc=cang@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=krzk@kernel.org \ --cc=kwmad.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=robh@kernel.org \ --cc=stanley.chu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.