From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758716Ab0JZJFN (ORCPT ); Tue, 26 Oct 2010 05:05:13 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:16500 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757877Ab0JZJFL (ORCPT ); Tue, 26 Oct 2010 05:05:11 -0400 Message-ID: <001a01cb74ec$e3eb3ea0$66f8800a@maildom.okisemi.com> From: "Tomoya MORINAGA" To: "Jean Delvare" Cc: "Samuel Ortiz" , "Wolfram Sang" , "Ralf Baechle" , , "LKML" , "Ben Dooks \(embedded platforms\)" , "Linus Walleij" , "srinidhi kasagar" , "Tomoya MORINAGA" , "Wang Qi\"" , "Wang Yong Y\"" , , , References: <4CC645A1.5010509@dsn.okisemi.com> <20101026102048.316d0c04@endymion.delvare> Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 Date: Tue, 26 Oct 2010 18:05:07 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 26, 2010 5:20 PM, Jean Delvare wrote: > I don't like this driver name at all. For one thing, "pch" is too > short. Many other vendors could come up with names with acronym "PCH". > > For another, Intel has many PCH (Platform Controller Hub) chips, some > of them (5/3400 Series, Cougar Point, Patsburg) are or will be > supported by the i2c-i801 driver, some of them (Moorestown) will be > supported by the upcoming i2c-intel-mid driver (even though the name > "PCH" is surprisingly missing from the source code) and your driver > only supports one particular model. Yes, this driver suppors only Topcliff(Intel Atom E6xx series) now. > > So please find a name which accurately represents the hardware your > driver is for. i2c-topcliff would be fine with me, but you will have to > check with Intel, as I know they are quite picky with the usage of code > names. Most drivers for Topcliff have been accepted with "pch_" prefix. Only SPI driver, like you indicates, have accepted as spi_topcliff_pch.c. If you request, I can modify "pch_i2c.c" to "i2c-topcliff_pch.c". > > As for the driver code, I will not be able to review it, sorry. It's > not in my area, I don't have the time and I don't have the hardware. I > think it would make sense for Intel people to review and test it before > it gets upstream. No problem! After reviewing by Intel(:CCed), we started posting to LKML and we have already tested this patch on the EVA Board. Tuhs, I want you to merge to this patch to 2.6.37 ASAP. Thanks, Tomoya(OKI SEMICONDUCTOR CO., LTD.) ----- Original Message ----- From: "Jean Delvare" To: "Tomoya" Cc: "Samuel Ortiz" ; "Wolfram Sang" ; "Ralf Baechle" ; ; "LKML" ; "Ben Dooks (embedded platforms)" ; "Linus Walleij" ; "srinidhi kasagar" ; "Tomoya MORINAGA" ; "Wang Qi"" ; "Wang Yong Y"" ; ; ; Sent: Tuesday, October 26, 2010 5:20 PM Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 > Hi Tomoya, > > On Tue, 26 Oct 2010 12:06:09 +0900, Tomoya wrote: > > Could you merge this patch to 2.6.37 ? > > > > Change Summary > > - Change Author > > - Change Name of "Signed-off-by" > > > > Thanks, Tomoya(OKI SEMICONDUCTOR CO., LTD.) > > > > --- > > I2C driver of Topcliff PCH > > > > Topcliff PCH is the platform controller hub that is going to be used in > > Intel's upcoming general embedded platform. All IO peripherals in > > Topcliff PCH are actually devices sitting on AMBA bus. > > Topcliff PCH has I2C I/F. Using this I/F, it is able to access system > > devices connected to I2C. > > > > Signed-off-by: Tomoya MORINAGA > > Reviewed-by: Linus Walleij > > > > --- > > drivers/i2c/busses/Kconfig | 8 + > > drivers/i2c/busses/Makefile | 1 + > > drivers/i2c/busses/i2c-pch.c | 908 ++++++++++++++++++++++++++++++++++++++++++ > > I don't like this driver name at all. For one thing, "pch" is too > short. Many other vendors could come up with names with acronym "PCH". > > For another, Intel has many PCH (Platform Controller Hub) chips, some > of them (5/3400 Series, Cougar Point, Patsburg) are or will be > supported by the i2c-i801 driver, some of them (Moorestown) will be > supported by the upcoming i2c-intel-mid driver (even though the name > "PCH" is surprisingly missing from the source code) and your driver > only supports one particular model. > > So please find a name which accurately represents the hardware your > driver is for. i2c-topcliff would be fine with me, but you will have to > check with Intel, as I know they are quite picky with the usage of code > names. > > As for the driver code, I will not be able to review it, sorry. It's > not in my area, I don't have the time and I don't have the hardware. I > think it would make sense for Intel people to review and test it before > it gets upstream. > > -- > Jean Delvare > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tomoya MORINAGA" Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 Date: Tue, 26 Oct 2010 18:05:07 +0900 Message-ID: <001a01cb74ec$e3eb3ea0$66f8800a@maildom.okisemi.com> References: <4CC645A1.5010509@dsn.okisemi.com> <20101026102048.316d0c04@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: Samuel Ortiz , Wolfram Sang , Ralf Baechle , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , "Ben Dooks (embedded platforms)" , Linus Walleij , srinidhi kasagar , Tomoya MORINAGA , "Wang Qi\"" , "Wang Yong Y\"" , kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Tuesday, October 26, 2010 5:20 PM, Jean Delvare wrote: > I don't like this driver name at all. For one thing, "pch" is too > short. Many other vendors could come up with names with acronym "PCH". > > For another, Intel has many PCH (Platform Controller Hub) chips, some > of them (5/3400 Series, Cougar Point, Patsburg) are or will be > supported by the i2c-i801 driver, some of them (Moorestown) will be > supported by the upcoming i2c-intel-mid driver (even though the name > "PCH" is surprisingly missing from the source code) and your driver > only supports one particular model. Yes, this driver suppors only Topcliff(Intel Atom E6xx series) now. > > So please find a name which accurately represents the hardware your > driver is for. i2c-topcliff would be fine with me, but you will have to > check with Intel, as I know they are quite picky with the usage of code > names. Most drivers for Topcliff have been accepted with "pch_" prefix. Only SPI driver, like you indicates, have accepted as spi_topcliff_pch.c. If you request, I can modify "pch_i2c.c" to "i2c-topcliff_pch.c". > > As for the driver code, I will not be able to review it, sorry. It's > not in my area, I don't have the time and I don't have the hardware. I > think it would make sense for Intel people to review and test it before > it gets upstream. No problem! After reviewing by Intel(:CCed), we started posting to LKML and we have already tested this patch on the EVA Board. Tuhs, I want you to merge to this patch to 2.6.37 ASAP. Thanks, Tomoya(OKI SEMICONDUCTOR CO., LTD.) ----- Original Message ----- From: "Jean Delvare" To: "Tomoya" Cc: "Samuel Ortiz" ; "Wolfram Sang" ; "Ralf Baechle" ; ; "LKML" ; "Ben Dooks (embedded platforms)" ; "Linus Walleij" ; "srinidhi kasagar" ; "Tomoya MORINAGA" ; "Wang Qi"" ; "Wang Yong Y"" ; ; ; Sent: Tuesday, October 26, 2010 5:20 PM Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 > Hi Tomoya, > > On Tue, 26 Oct 2010 12:06:09 +0900, Tomoya wrote: > > Could you merge this patch to 2.6.37 ? > > > > Change Summary > > - Change Author > > - Change Name of "Signed-off-by" > > > > Thanks, Tomoya(OKI SEMICONDUCTOR CO., LTD.) > > > > --- > > I2C driver of Topcliff PCH > > > > Topcliff PCH is the platform controller hub that is going to be used in > > Intel's upcoming general embedded platform. All IO peripherals in > > Topcliff PCH are actually devices sitting on AMBA bus. > > Topcliff PCH has I2C I/F. Using this I/F, it is able to access system > > devices connected to I2C. > > > > Signed-off-by: Tomoya MORINAGA > > Reviewed-by: Linus Walleij > > > > --- > > drivers/i2c/busses/Kconfig | 8 + > > drivers/i2c/busses/Makefile | 1 + > > drivers/i2c/busses/i2c-pch.c | 908 ++++++++++++++++++++++++++++++++++++++++++ > > I don't like this driver name at all. For one thing, "pch" is too > short. Many other vendors could come up with names with acronym "PCH". > > For another, Intel has many PCH (Platform Controller Hub) chips, some > of them (5/3400 Series, Cougar Point, Patsburg) are or will be > supported by the i2c-i801 driver, some of them (Moorestown) will be > supported by the upcoming i2c-intel-mid driver (even though the name > "PCH" is surprisingly missing from the source code) and your driver > only supports one particular model. > > So please find a name which accurately represents the hardware your > driver is for. i2c-topcliff would be fine with me, but you will have to > check with Intel, as I know they are quite picky with the usage of code > names. > > As for the driver code, I will not be able to review it, sorry. It's > not in my area, I don't have the time and I don't have the hardware. I > think it would make sense for Intel people to review and test it before > it gets upstream. > > -- > Jean Delvare >