All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Avri Altman'" <Avri.Altman@wdc.com>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'James E . J . Bottomley'" <jejb@linux.ibm.com>,
	"'Martin K . Petersen'" <martin.petersen@oracle.com>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>
Cc: "'Bean Huo'" <beanhuo@micron.com>,
	"'Bart Van Assche'" <bvanassche@acm.org>,
	"'Adrian Hunter'" <adrian.hunter@intel.com>, <hch@infradead.org>,
	"'Can Guo'" <cang@codeaurora.org>,
	"'Jaegeuk Kim'" <jaegeuk@kernel.org>,
	"'Jaehoon Chung'" <jh80.chung@samsung.com>,
	"'Gyunghoon Kwon'" <goodjob.kwon@samsung.com>,
	"'Sowon Na'" <sowon.na@samsung.com>,
	<linux-samsung-soc@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	"'Kiwoong Kim'" <kwmad.kim@samsung.com>
Subject: RE: [PATCH v4 15/16] scsi: ufs: ufs-exynos: introduce exynosauto v9 virtual host
Date: Fri, 15 Oct 2021 21:13:38 +0900	[thread overview]
Message-ID: <001c01d7c1be$16180960$42481c20$@samsung.com> (raw)
In-Reply-To: <DM6PR04MB6575717817EDD8C549F2D539FCB89@DM6PR04MB6575.namprd04.prod.outlook.com>

> > +static int exynosauto_ufs_vh_link_startup_notify(struct ufs_hba *hba,
> > +                                                enum
> > +ufs_notify_change_status status) {
> > +       if (status == POST_CHANGE) {
> > +               ufshcd_set_link_active(hba);
> > +               ufshcd_set_ufs_dev_active(hba);
> > +               hba->wlun_dev_clr_ua = true;
> wlun_dev_clr_ua no longer exists - needs rebase

I found the commit. I'll remove this next patch.

> 
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> > +static int exynosauto_ufs_vh_wait_ph_ready(struct ufs_hba *hba) {
> > +       u32 mbox;
> > +       ktime_t start, stop;
> > +
> > +       start = ktime_get();
> > +       stop = ktime_add(start, ms_to_ktime(PH_READY_TIMEOUT_MS));
> > +
> > +       do {
> > +               mbox = ufshcd_readl(hba, PH2VH_MBOX);
> > +               if ((mbox & MH_MSG_MASK) == MH_MSG_PH_READY)
> > +                       return 0;
> Maybe add a comment here that the mbox protocol will be defined later.

Put some comments with TODO: tag.

Best Regards,
Chanho Park


  reply	other threads:[~2021-10-15 12:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20211007081133epcas2p31f973709609d82dbbc76bd7b51232cb2@epcas2p3.samsung.com>
2021-10-07  8:09 ` [PATCH v4 00/16] introduce exynosauto v9 ufs driver Chanho Park
     [not found]   ` <CGME20211007081133epcas2p3ca173361432aabe2ce9b923465a08570@epcas2p3.samsung.com>
2021-10-07  8:09     ` [PATCH v4 01/16] scsi: ufs: add quirk to handle broken UIC command Chanho Park
2021-10-14 10:48       ` Avri Altman
     [not found]   ` <CGME20211007081134epcas2p4b6c0673d5b47cd04d9aefcd3d07c75cc@epcas2p4.samsung.com>
2021-10-07  8:09     ` [PATCH v4 02/16] scsi: ufs: add quirk to enable host controller without ph configuration Chanho Park
2021-10-14 10:49       ` Avri Altman
     [not found]   ` <CGME20211007081134epcas2p27513b5eed7fc78424709f70fa651a877@epcas2p2.samsung.com>
2021-10-07  8:09     ` [PATCH v4 03/16] scsi: ufs: ufs-exynos: change pclk available max value Chanho Park
     [not found]   ` <CGME20211007081134epcas2p4af32ee0344c2c17f478709da5acc7a87@epcas2p4.samsung.com>
2021-10-07  8:09     ` [PATCH v4 04/16] scsi: ufs: ufs-exynos: simplify drv_data retrieval Chanho Park
     [not found]   ` <CGME20211007081134epcas2p4121be716aafc8900713e331026eceaa8@epcas2p4.samsung.com>
2021-10-07  8:09     ` [PATCH v4 05/16] scsi: ufs: ufs-exynos: add refclkout_stop control Chanho Park
     [not found]   ` <CGME20211007081134epcas2p46aebdd54f2e5263e0662a1adbd93613a@epcas2p4.samsung.com>
2021-10-07  8:09     ` [PATCH v4 06/16] scsi: ufs: ufs-exynos: add setup_clocks callback Chanho Park
     [not found]   ` <CGME20211007081134epcas2p49d174a4da55c5042e2bee42c249678c3@epcas2p4.samsung.com>
2021-10-07  8:09     ` [PATCH v4 07/16] scsi: ufs: ufs-exynos: correct timeout value setting registers Chanho Park
2021-10-14 12:12       ` Avri Altman
2021-10-15  9:53         ` Chanho Park
     [not found]   ` <CGME20211007081134epcas2p1f4e1d77c82c3cd7647c0fa9f1fdca053@epcas2p1.samsung.com>
2021-10-07  8:09     ` [PATCH v4 08/16] scsi: ufs: ufs-exynos: support custom version of ufs_hba_variant_ops Chanho Park
     [not found]   ` <CGME20211007081134epcas2p3cf933b0e8c52de665161fb978ec8e577@epcas2p3.samsung.com>
2021-10-07  8:09     ` [PATCH v4 09/16] scsi: ufs: ufs-exynos: add EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR option Chanho Park
     [not found]   ` <CGME20211007081134epcas2p2eb19706624f722e96aec7bbdda9f8e4d@epcas2p2.samsung.com>
2021-10-07  8:09     ` [PATCH v4 10/16] scsi: ufs: ufs-exynos: factor out priv data init Chanho Park
     [not found]   ` <CGME20211007081135epcas2p22a653765a6e520d1da1ba1ceb3f7fa25@epcas2p2.samsung.com>
2021-10-07  8:09     ` [PATCH v4 11/16] scsi: ufs: ufs-exynos: add pre/post_hce_enable drv callbacks Chanho Park
     [not found]   ` <CGME20211007081135epcas2p365e055851e41fa5e95e00e641037da41@epcas2p3.samsung.com>
2021-10-07  8:09     ` [PATCH v4 12/16] scsi: ufs: ufs-exynos: support exynosauto v9 ufs driver Chanho Park
     [not found]   ` <CGME20211007081135epcas2p2d577fc8dec75471cf42024eda6a45690@epcas2p2.samsung.com>
2021-10-07  8:09     ` [PATCH v4 13/16] dt-bindings: ufs: exynos-ufs: add io-coherency property Chanho Park
2021-10-15 13:50       ` Rob Herring
2021-10-18  0:26         ` Chanho Park
2021-10-18 13:23           ` Rob Herring
2021-10-18 11:07         ` Chanho Park
     [not found]   ` <CGME20211007081135epcas2p410e67850fdd25fc762b0bfa49c6e24f1@epcas2p4.samsung.com>
2021-10-07  8:09     ` [PATCH v4 14/16] scsi: ufs: ufs-exynos: multi-host configuration for exynosauto Chanho Park
2021-10-14 18:51       ` Avri Altman
2021-10-15 11:44         ` Chanho Park
2021-10-18  5:34       ` Inki Dae
     [not found]   ` <CGME20211007081135epcas2p372f122a0f601f0108bdd593ca0105f3c@epcas2p3.samsung.com>
2021-10-07  8:09     ` [PATCH v4 15/16] scsi: ufs: ufs-exynos: introduce exynosauto v9 virtual host Chanho Park
2021-10-14 19:03       ` Avri Altman
2021-10-15 12:13         ` Chanho Park [this message]
     [not found]   ` <CGME20211007081135epcas2p37b429e366099fd28e517d3d354a848b8@epcas2p3.samsung.com>
2021-10-07  8:09     ` [PATCH v4 16/16] dt-bindings: ufs: exynos-ufs: add exynosautov9 compatible Chanho Park
2021-10-14 10:04   ` [PATCH v4 00/16] introduce exynosauto v9 ufs driver Avri Altman
2021-10-15 11:57     ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001c01d7c1be$16180960$42481c20$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=Avri.Altman@wdc.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=goodjob.kwon@samsung.com \
    --cc=hch@infradead.org \
    --cc=jaegeuk@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=jh80.chung@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=kwmad.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sowon.na@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.