From: <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: "'Git List'" <git@vger.kernel.org>
Subject: RE: [Failure] Re: git 2.40.0-rc1
Date: Thu, 2 Mar 2023 15:08:29 -0500 [thread overview]
Message-ID: <001e01d94d42$c5213b50$4f63b1f0$@nexbridge.com> (raw)
In-Reply-To: <xmqq356mkjp1.fsf@gitster.g>
On Thursday, March 2, 2023 3:00 PM, Junio C Hamano wrote:
><rsbecker@nexbridge.com> writes:
>
>> On Thursday, March 2, 2023 1:44 PM, Junio C Hamano wrote:
>>><rsbecker@nexbridge.com> writes:
>>>
>>>> Git 2.40.0-rc2 was a regression from rc1. The following new tests failed:
>
>I think you are reporting -rc1 relative to -rc0.
>
>>>> t3206 - virtually all subtests failed. An example of this failure is
>>>> a results comparison in subtest 1 (seemingly relating to abbreviation):
>>>> + test_cmp expect actual
>>>> --- expect 2023-03-02 16:39:23 +0000
>>>> +++ actual 2023-03-02 16:39:23 +0000
>>>> @@ -1,4 +1,4 @@
>>>> -1: 4de457d = 1: 35b9b25 s/5/A/
>>>> -2: fccce22 = 2: de345ab s/4/A/
>>>> -3: 147e64e = 3: 9af6654 s/11/B/
>>>> -4: a63e992 = 4: 2901f77 s/12/B/
>>>> +1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:
>>>> 35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/
>>>
>>>Are any big endian machines involved?
>>>
>>>cf. https://lore.kernel.org/git/Y%2F+paI8WGSmEbv%2Fw@pobox.com/
>>
>> Oh yes. All NonStop variants are big-endian. That hasn't changed the
>> SHA-1 signatures though.
>
>There is a stupid sequence that slipped through the review
>
> char c = structPtr->intMember;
>
> if (c < 0)
> ... do something ...
>
>and where "char" is "unsigned char", the compiler thinks "do something" will never
>trigger and from there everything goes haywire.
>
>The tip of 'master' already has a fix (and no other changes as of this writing), and
>will be part of -rc2.
Thank you for the really fast fix on this 😊.
--Randall
next prev parent reply other threads:[~2023-03-02 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 16:43 [Failure] Re: git 2.40.0-rc1 rsbecker
2023-03-02 18:44 ` Junio C Hamano
2023-03-02 19:41 ` rsbecker
2023-03-02 20:00 ` Junio C Hamano
2023-03-02 20:08 ` rsbecker [this message]
2023-03-02 20:49 ` Junio C Hamano
2023-03-02 19:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001e01d94d42$c5213b50$4f63b1f0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.