From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INVALID_MSGID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A894CC07E96 for ; Thu, 8 Jul 2021 07:50:18 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id F0FC061C98 for ; Thu, 8 Jul 2021 07:50:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0FC061C98 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=trustnetic.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B61C4069C; Thu, 8 Jul 2021 09:50:17 +0200 (CEST) Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by mails.dpdk.org (Postfix) with ESMTP id 3E95840687 for ; Thu, 8 Jul 2021 09:50:13 +0200 (CEST) X-QQ-mid: bizesmtp33t1625730607tlsm60nl Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Thu, 08 Jul 2021 15:50:06 +0800 (CST) X-QQ-SSF: 01400000002000D0E000000A0000000 X-QQ-FEAT: VvqLbp3JaDNC9MvJOaGlLu+2yEednH+mt01eLxgrOhOYom3Av8hBI2qlWnTt4 pBUntAsM4hAHPPfarsU20Vu6NHqtSuVnTORoNAlOZZUlHaLKq9EEQL+L8hPpdu3w5BNdqaX 0IjNYvDcLljwe671ie//mcDdXvzJgpVD3vB5Szx1sy433yIbyVrHkOAb4446g/Gr0o642yX lGkkrF0kjg4mJIywkwqP4/wypl7tJEZxh7Olnr1BKsKKf0EgAj7IiPNKfg69vfmSPKa7nKq Y6erER8XKVvnlO5JFxbnFqqk5CQI/tgwdUa45dHUJbBYbgoC3HB/AUxTnVvezWK2zTtRHvR W+0pBF2WWngwUnQb+UakwQczGCdXBfQayq/hAo1 X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Andrew Rybchenko'" , References: <20210706095545.10776-1-jiawenwu@trustnetic.com> <20210706095545.10776-15-jiawenwu@trustnetic.com> <95f0f8d2-21f5-42c5-4c22-f811b5526f8d@oktetlabs.ru> <001f01d773bf$c175ce70$44616b50$@trustnetic.com> In-Reply-To: Date: Thu, 8 Jul 2021 15:50:06 +0800 Message-ID: <002001d773cd$de938a20$9bba9e60$@trustnetic.com>+AB7A973C6B637B9E MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLzOIuDxIImuXvqoTQ2pR2VqkNk+AK6t12bAZrmXuIBl0cPxQJAipb9qL+9rCA= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On July 8, 2021 3:37 PM, Andrew Rybchenko wrote: > On 7/8/21 9:09 AM, Jiawen Wu wrote: > > On July 7, 2021 10:05 PM, Andrew Rybchenko wrote: > >> On 7/6/21 12:55 PM, Jiawen Wu wrote: > >>> Setup MSI-X interrupt, complete PHY configuration and set device > >>> link speed to start device. Disable interrupt, stop hardware and > >>> clear queues to stop device. > >>> > >>> Signed-off-by: Jiawen Wu > >> > >> WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see > >> Documentation/timers/timers-howto.rst > >> #242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70: > >> + msleep(1); > >> > >> Any comments? > >> > > > > This depends on the design of the hardware. >=20 > Isn't is a problem if sleep will be longer in fact? I thought about replacing it with 'msec_delay', but it is working right = now. And 'msleep(1)' is also well used in the kernel driver, so I haven't = changed it yet.